From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757063AbcG0QKy (ORCPT ); Wed, 27 Jul 2016 12:10:54 -0400 Received: from down.free-electrons.com ([37.187.137.238]:34253 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755894AbcG0QKx (ORCPT ); Wed, 27 Jul 2016 12:10:53 -0400 From: Gregory CLEMENT To: Grzegorz Jaszczyk Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, jason@lakedaemon.net, andrew@lunn.ch, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, alior@marvell.com, robh+dt@kernel.org, mw@semihalf.com, thomas.petazzoni@free-electrons.com, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com Subject: Re: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND References: <1469105055-25181-1-git-send-email-jaz@semihalf.com> <1469105055-25181-6-git-send-email-jaz@semihalf.com> <87k2g7m5j1.fsf@free-electrons.com> Date: Wed, 27 Jul 2016 18:10:41 +0200 In-Reply-To: <87k2g7m5j1.fsf@free-electrons.com> (Gregory CLEMENT's message of "Wed, 27 Jul 2016 18:04:18 +0200") Message-ID: <8760rrm58e.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On mer., juil. 27 2016, Gregory CLEMENT wrote: > Hi Grzegorz, > > On jeu., juil. 21 2016, Grzegorz Jaszczyk wrote: > >> Signed-off-by: Grzegorz Jaszczyk > It looks good: > > Acked-by: Gregory CLEMENT And here again the title prefix should be change to: "ARM: dts: mvebu: a385-db-ap:" also do not forget fo add a commit log. Thanks, Gregory > >> --- >> arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++--- >> 1 file changed, 23 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts >> index a18f516..6648a3f 100644 >> --- a/arch/arm/boot/dts/armada-385-db-ap.dts >> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts >> @@ -182,15 +182,35 @@ >> >> nfc: flash@d0000 { >> status = "okay"; >> - #address-cells = <1>; >> - #size-cells = <1>; >> - >> num-cs = <1>; >> nand-ecc-strength = <4>; >> nand-ecc-step-size = <512>; >> marvell,nand-keep-config; >> marvell,nand-enable-arbiter; >> nand-on-flash-bbt; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + partition@0 { >> + label = "U-Boot"; >> + reg = <0x00000000 0x00800000>; >> + read-only; >> + }; >> + >> + partition@800000 { >> + label = "uImage"; >> + reg = <0x00800000 0x00400000>; >> + read-only; >> + }; >> + >> + partition@c00000 { >> + label = "Root"; >> + reg = <0x00c00000 0x3f400000>; >> + }; >> + }; >> }; >> >> usb3@f0000 { >> -- >> 1.8.3.1 >> > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 27 Jul 2016 18:10:41 +0200 Subject: [PATCH 05/18] ARM: mvebu: a385-db-ap: add default partition description for NAND In-Reply-To: <87k2g7m5j1.fsf@free-electrons.com> (Gregory CLEMENT's message of "Wed, 27 Jul 2016 18:04:18 +0200") References: <1469105055-25181-1-git-send-email-jaz@semihalf.com> <1469105055-25181-6-git-send-email-jaz@semihalf.com> <87k2g7m5j1.fsf@free-electrons.com> Message-ID: <8760rrm58e.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi, On mer., juil. 27 2016, Gregory CLEMENT wrote: > Hi Grzegorz, > > On jeu., juil. 21 2016, Grzegorz Jaszczyk wrote: > >> Signed-off-by: Grzegorz Jaszczyk > It looks good: > > Acked-by: Gregory CLEMENT And here again the title prefix should be change to: "ARM: dts: mvebu: a385-db-ap:" also do not forget fo add a commit log. Thanks, Gregory > >> --- >> arch/arm/boot/dts/armada-385-db-ap.dts | 26 +++++++++++++++++++++++--- >> 1 file changed, 23 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/armada-385-db-ap.dts b/arch/arm/boot/dts/armada-385-db-ap.dts >> index a18f516..6648a3f 100644 >> --- a/arch/arm/boot/dts/armada-385-db-ap.dts >> +++ b/arch/arm/boot/dts/armada-385-db-ap.dts >> @@ -182,15 +182,35 @@ >> >> nfc: flash at d0000 { >> status = "okay"; >> - #address-cells = <1>; >> - #size-cells = <1>; >> - >> num-cs = <1>; >> nand-ecc-strength = <4>; >> nand-ecc-step-size = <512>; >> marvell,nand-keep-config; >> marvell,nand-enable-arbiter; >> nand-on-flash-bbt; >> + >> + partitions { >> + compatible = "fixed-partitions"; >> + #address-cells = <1>; >> + #size-cells = <1>; >> + >> + partition at 0 { >> + label = "U-Boot"; >> + reg = <0x00000000 0x00800000>; >> + read-only; >> + }; >> + >> + partition at 800000 { >> + label = "uImage"; >> + reg = <0x00800000 0x00400000>; >> + read-only; >> + }; >> + >> + partition at c00000 { >> + label = "Root"; >> + reg = <0x00c00000 0x3f400000>; >> + }; >> + }; >> }; >> >> usb3 at f0000 { >> -- >> 1.8.3.1 >> > > -- > Gregory Clement, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com