From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40220)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1aTsGa-0005Od-3g
	for qemu-devel@nongnu.org; Thu, 11 Feb 2016 09:30:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1aTsGW-00015l-A7
	for qemu-devel@nongnu.org; Thu, 11 Feb 2016 09:30:43 -0500
Received: from roura.ac.upc.edu ([147.83.33.10]:37266 helo=roura.ac.upc.es)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <vilanova@ac.upc.edu>) id 1aTsGV-00015A-Tj
	for qemu-devel@nongnu.org; Thu, 11 Feb 2016 09:30:40 -0500
From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= <vilanova@ac.upc.edu>
References: <145505246212.4785.2237668256809452874.stgit@localhost>
	<145505247535.4785.10937373381145935912.stgit@localhost>
Date: Thu, 11 Feb 2016 15:30:34 +0100
In-Reply-To: <145505247535.4785.10937373381145935912.stgit@localhost>
	(=?utf-8?Q?=22Llu=C3=ADs?=
	Vilanova"'s message of "Tue, 9 Feb 2016 22:14:35 +0100")
Message-ID: <8760xv9v5h.fsf@fimbulvetr.bsc.es>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 2/4] trace: Remove unnecessary
	intermediate event copies
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@gmail.com>, Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>, Eduardo Habkost <ehabkost@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>

Llu=C3=ADs Vilanova writes:

> The current code forces the use of a chain of ".original" dereferences,
> which looks odd.

> Signed-off-by: Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>
> ---
>  scripts/tracetool/__init__.py        |    4 +---
>  scripts/tracetool/format/events_h.py |    4 ++--
>  scripts/tracetool/format/tcg_h.py    |    4 ++--
>  3 files changed, 5 insertions(+), 7 deletions(-)

> diff --git a/scripts/tracetool/__init__.py b/scripts/tracetool/__init__.py
> index 0663e7f..1bf9246 100644
> --- a/scripts/tracetool/__init__.py
> +++ b/scripts/tracetool/__init__.py
> @@ -6,7 +6,7 @@ Machinery for generating tracing-related intermediate fil=
es.
>  """
=20
>  __author__     =3D "Llu=C3=ADs Vilanova <vilanova@ac.upc.edu>"
> -__copyright__  =3D "Copyright 2012-2014, Llu=C3=ADs Vilanova <vilanova@a=
c.upc.edu>"
> +__copyright__  =3D "Copyright 2012-2016, Llu=C3=ADs Vilanova <vilanova@a=
c.upc.edu>"
>  __license__    =3D "GPL version 2 or (at your option) any later version"
=20
>  __maintainer__ =3D "Stefan Hajnoczi"
> @@ -287,8 +287,6 @@ def _read_events(fobj):
>                      event.args):
>                  if atrans =3D=3D aorig:
>                      args_trans.append(atrans)
> -            event_trans.args =3D Arguments(args_trans)
> -            event_trans =3D event_trans.copy()
=20
>              event_exec =3D event.copy()
>              event_exec.name +=3D "_exec"

I've detected an error in this piece. Please ignore this patch until v7.


Thanks,
  Lluis