From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872AbcANGql (ORCPT ); Thu, 14 Jan 2016 01:46:41 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:40797 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750701AbcANGqj (ORCPT ); Thu, 14 Jan 2016 01:46:39 -0500 From: Kalle Valo To: Arnd Bergmann Cc: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , Hauke Mehrtens , Michael Buesch , linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ssb: host_soc depends on sprom References: <8128014.DbbgBtKY3z@wuerfel> Date: Thu, 14 Jan 2016 08:46:29 +0200 In-Reply-To: <8128014.DbbgBtKY3z@wuerfel> (Arnd Bergmann's message of "Wed, 13 Jan 2016 23:51:43 +0100") Message-ID: <8760ywd5fe.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Arnd Bergmann writes: > Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' > from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in > a build failure unless at least one of the other drivers that selects > it is enabled: > > drivers/built-in.o: In function `ssb_host_soc_get_invariants': > (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' > > This adds the same select statement that is used elsewhere. > > Signed-off-by: Arnd Bergmann > Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") > --- > I'm not sure who the right person is to pick up the fix. The patch that > introduced the problem was merged by Kalle through the iwlwifi tree. I can take it. For historical reasons ssb patches go through my wireless-drivers trees. -- Kalle Valo From mboxrd@z Thu Jan 1 00:00:00 1970 From: kvalo@codeaurora.org (Kalle Valo) Date: Thu, 14 Jan 2016 08:46:29 +0200 Subject: [PATCH] ssb: host_soc depends on sprom In-Reply-To: <8128014.DbbgBtKY3z@wuerfel> (Arnd Bergmann's message of "Wed, 13 Jan 2016 23:51:43 +0100") References: <8128014.DbbgBtKY3z@wuerfel> Message-ID: <8760ywd5fe.fsf@kamboji.qca.qualcomm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Arnd Bergmann writes: > Drivers that use the SSB sprom functionality typically 'select SSB_SPROM' > from Kconfig, but CONFIG_SSB_HOST_SOC misses this, which results in > a build failure unless at least one of the other drivers that selects > it is enabled: > > drivers/built-in.o: In function `ssb_host_soc_get_invariants': > (.text+0x459494): undefined reference to `ssb_fill_sprom_with_fallback' > > This adds the same select statement that is used elsewhere. > > Signed-off-by: Arnd Bergmann > Fixes: 541c9a84cd85 ("ssb: pick SoC invariants code from MIPS BCM47xx arch") > --- > I'm not sure who the right person is to pick up the fix. The patch that > introduced the problem was merged by Kalle through the iwlwifi tree. I can take it. For historical reasons ssb patches go through my wireless-drivers trees. -- Kalle Valo