From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z84ix-0003P0-OP for qemu-devel@nongnu.org; Thu, 25 Jun 2015 06:49:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z84iw-0004NE-Mi for qemu-devel@nongnu.org; Thu, 25 Jun 2015 06:49:39 -0400 From: Markus Armbruster References: <1435068107-12594-1-git-send-email-peter.maydell@linaro.org> <87ioacyw93.fsf@blackfin.pond.sub.org> Date: Thu, 25 Jun 2015 12:49:31 +0200 In-Reply-To: (Peter Maydell's message of "Thu, 25 Jun 2015 10:35:51 +0100") Message-ID: <87616cvz9g.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v2 for-2.4 0/3] block: Improve warnings for doubly-connected drives List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Kevin Wolf , Stefan Hajnoczi , QEMU Developers , qemu-block@nongnu.org, Patch Tracking Peter Maydell writes: > On 25 June 2015 at 10:26, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> This patchset attempts to improve the warning and error messages for >>> bad user command lines that attempt to connect a drive up to two >>> devices. The motivation here is patch #4, which changes the default >>> interface for the virt board to virtio. That will break some existing >>> command lines which forgot to specify if=none, and so I would like >>> us to at least diagnose that user error in a helpful way that points >>> the user towards adding the missing if=none. > >> With the commit message of PATCH 3 amended, series >> Reviewed-by: Markus Armbruster > > Thanks. Do you want to take this through a block tree or are you happy > for me to put it through target-arm.next? I'm fine with target-arm. Copying Stefan in the unlikely case he's not.