From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39954) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbRaz-00075G-Qt for qemu-devel@nongnu.org; Fri, 27 Mar 2015 06:34:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YbRax-0007i2-3p for qemu-devel@nongnu.org; Fri, 27 Mar 2015 06:34:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51528) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YbRaw-0007hw-Uy for qemu-devel@nongnu.org; Fri, 27 Mar 2015 06:34:31 -0400 From: Markus Armbruster References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-27-git-send-email-eblake@redhat.com> Date: Fri, 27 Mar 2015 11:34:28 +0100 In-Reply-To: <1427227433-5030-27-git-send-email-eblake@redhat.com> (Eric Blake's message of "Tue, 24 Mar 2015 14:03:51 -0600") Message-ID: <87619mpw3v.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH v5 26/28] qapi: Drop inline nested type in query-version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, lcapitulino@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, wenchaoqemu@gmail.com Eric Blake writes: > A future patch will be using a 'name':{dictionary} entry in the > QAPI schema to specify a default value for an optional argument; > but existing use of inline nested structs conflicts with that goal. > This patch fixes one of only two commands relying on nested > types, by breaking the nesting into an explicit type; it means > that the type is now boxed instead of unboxed in C code, but the > QMP wire format is unaffected by this change. > > Prefer the safer g_new0() while making the conversion. > > Signed-off-by: Eric Blake Reviewed-by: Markus Armbruster