From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb2ad-0005V5-BG for qemu-devel@nongnu.org; Thu, 26 Mar 2015 03:52:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Yb2aY-0000cP-Bm for qemu-devel@nongnu.org; Thu, 26 Mar 2015 03:52:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Yb2aY-0000cA-4c for qemu-devel@nongnu.org; Thu, 26 Mar 2015 03:52:26 -0400 From: Markus Armbruster References: <1427227433-5030-1-git-send-email-eblake@redhat.com> <1427227433-5030-2-git-send-email-eblake@redhat.com> <87vbhpc4j7.fsf@blackfin.pond.sub.org> <55131689.8030107@redhat.com> Date: Thu, 26 Mar 2015 08:52:19 +0100 In-Reply-To: <55131689.8030107@redhat.com> (Eric Blake's message of "Wed, 25 Mar 2015 14:11:53 -0600") Message-ID: <87619o9owc.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 01/28] qapi: Document type-safety considerations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, famz@redhat.com, wenchaoqemu@gmail.com, Michael Roth , qemu-devel@nongnu.org, lcapitulino@redhat.com Copyright note question, copying Michael. Eric Blake writes: > On 03/25/2015 12:31 PM, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Go into more details about the various types of valid expressions >>> in a qapi schema, including tweaks to document fixes being done >>> later in the current patch series. Also fix some stale and missing >>> documentation in the QMP specification. >>> >>> Signed-off-by: Eric Blake >>> >>> --- >>> >>> I'm not sure if it is okay to assert GPLv2+ licensing without an >>> explicit Copyright, but as I am not the original author, I don't >>> know who to attribute any original Copyright to. Advice? Should >>> I split the license addition to a separate patch? > > No thoughts to this question? Missed it. I wish we didn't need to clutter copyright and licensing boiler plate everywhere, but I accept it's the prudent thing to do in a tree with so many differently licensed parts. Making GPLv2+ explicit is obviously fine, because anything without an explicit licensing note is GPLv2+ (see ./LICENSE). That leaves the copyright part, as you say. According to git-log, the file was created by Michael Roth. git-blame blames 219 out of 590 lines in current master on his initial commit. $ git-blame -w master docs/qapi-code-gen.txt | cut -c 11-28 | sort | uniq -= c | sort -nr 219 Michael Roth 124 Markus Armbruster 116 Kevin Wolf 95 Eric Blake 21 Wenchao Xia 10 Llu=C3=ADs Vilanova 2 Stefan Weil 2 Stefan Hajnoczi 1 Beno=C3=AEt Canet If you want to add a copyright note, I suggest to steal one from Michael's work elsewhere, and update it for later major contributors. Here's my stab at it: =3D How to use the QAPI code generator =3D Copyright IBM Corp. 2011 Copyright (C) 2012-2015 Red Hat, Inc. Authors: Michael Roth Kevin Wolf Markus Armbruster Eric Blake This work is licensed under the terms of the GNU GPL, version 2 or late= r. See the COPYING file in the top-level directory. =3D=3D Introduction =3D=3D QAPI is a native C API within QEMU which provides management-level functionality to internal and external users. For external The Authors paragraph is informational and could be omitted without compromising the copyright note. [...]