From: "Bjørn Mork" <bjorn-yOkvZcmFvRU@public.gmane.org>
To: Kevin Zhu <Mingying.Zhu-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org>
Cc: Enrico Mioso <mrkiko.rs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"Midge Shaojun Tan"
<ShaojunMidge.Tan-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org>,
Eli Britstein
<Eli.Britstein-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org>,
Alex Strizhevsky
<alexxst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"youtux\@gmail.com"
<youtux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
"linux-usb\@vger.kernel.org"
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"netdev\@vger.kernel.org"
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Is this 32-bit NCM?y
Date: Fri, 05 Dec 2014 10:42:46 +0100 [thread overview]
Message-ID: <8761dqjuuh.fsf@nemi.mork.no> (raw)
In-Reply-To: <54811670.5030703-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org> (Kevin Zhu's message of "Fri, 5 Dec 2014 02:20:36 +0000")
Kevin Zhu <Mingying.Zhu-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org> writes:
> Regarding the location of NDP, it should be easy to fix. It can be added
> to the end of the NTB only after it's ready to send.
Yes, but this will require a bit of redesign. Note that this code is
shared with cdc_mbim, which might have to add multiple NDPs for
multiplexed sessions. In theory up to 512 different, but that is so
unlinkely that we can ignore it. We could set a fixed limit
significantly lower than that if necessary.
I'd really like to refactor this code to simply queue the skbs, creating
the linear NTB only when the queue is flushed. Then we'll have all the
info we need and can order the contents any way we want without adding
unnecessary padding.
> Regarding the
> concern to other devices, as there's a particular driver for Huawei
> devices in kernel, which is huawei_cdc_ncm, maybe we can just fix the TX
> function there to avoid breaking other devices.
Sure. That is definitely an alternative if we don't want to touch the
generic driver.
But making the generic driver flexible enough to accommodate any device
would be preferable. I do hope we can do that.
Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-12-05 9:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-04 10:10 Is this 32-bit NCM?y Midge Shaojun Tan
[not found] ` <AMSPR06MB6011E001029C251790CB923EE780-MyG0ARRHH/drF+2gGhmTpL9PrO6axcR4XA4E9RH9d+qIuWR1G4zioA@public.gmane.org>
2014-12-04 10:24 ` Enrico Mioso
2014-12-04 10:33 ` Enrico Mioso
2014-12-04 11:44 ` Bjørn Mork
2014-12-04 12:17 ` Enrico Mioso
[not found] ` <877fy7myfb.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2014-12-04 12:28 ` Enrico Mioso
[not found] ` <alpine.LNX.2.03.1412041326160.9926-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-05 2:20 ` Kevin Zhu
[not found] ` <54811670.5030703-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org>
2014-12-05 9:42 ` Bjørn Mork [this message]
[not found] ` <8761dqjuuh.fsf-lbf33ChDnrE/G1V5fR+Y7Q@public.gmane.org>
2014-12-05 9:59 ` Enrico Mioso
2014-12-28 14:53 ` refactoring cdc_ncm Enrico Mioso
2015-01-19 16:51 ` [discuss] [cdc_ncm] Refactoring cdc_ncm Enrico Mioso
-- strict thread matches above, loose matches on Subject: below --
2014-11-26 21:51 Is this 32-bit NCM? Enrico Mioso
2014-11-27 18:34 ` Enrico Mioso
2014-11-28 9:29 ` Bjørn Mork
2014-12-01 21:11 ` Enrico Mioso
2014-12-01 22:02 ` Eli Britstein
2014-12-02 3:53 ` Kevin Zhu
2014-12-02 6:32 ` Enrico Mioso
2014-12-02 6:43 ` Kevin Zhu
2014-12-02 6:49 ` Enrico Mioso
2014-12-02 7:44 ` Kevin Zhu
2014-12-02 7:45 ` Eli Britstein
2014-12-02 8:03 ` Kevin Zhu
2014-12-02 10:32 ` Enrico Mioso
2014-12-02 11:21 ` Bjørn Mork
2014-12-02 13:11 ` Enrico Mioso
2014-12-02 13:37 ` Bjørn Mork
2014-12-02 13:53 ` Enrico Mioso
2014-12-02 15:04 ` Kevin Zhu
2014-12-02 15:28 ` Enrico Mioso
2014-12-03 5:38 ` Kevin Zhu
2014-12-03 6:00 ` Enrico Mioso
2014-12-03 6:05 ` Kevin Zhu
2014-12-04 6:31 ` Is this 32-bit NCM?y Enrico Mioso
2014-12-04 8:52 ` Kevin Zhu
2014-12-04 8:56 ` Enrico Mioso
[not found] ` <alpine.LNX.2.03.1412040955140.3516-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-12-04 9:01 ` Kevin Zhu
2014-12-04 9:19 ` Bjørn Mork
2014-12-04 9:26 ` Kevin Zhu
[not found] ` <548028A0.5000909-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org>
2014-12-04 9:28 ` Enrico Mioso
2014-12-04 9:55 ` Bjørn Mork
2014-12-04 9:53 ` Enrico Mioso
2014-12-04 10:02 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761dqjuuh.fsf@nemi.mork.no \
--to=bjorn-yokvzcmfvru@public.gmane.org \
--cc=Eli.Britstein-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org \
--cc=Mingying.Zhu-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org \
--cc=ShaojunMidge.Tan-6C2+4RG2qWF0ubjbjo6WXg@public.gmane.org \
--cc=alexxst-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mrkiko.rs-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=youtux-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.