From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755621Ab2D0WBx (ORCPT ); Fri, 27 Apr 2012 18:01:53 -0400 Received: from na3sys009aog101.obsmtp.com ([74.125.149.67]:57626 "EHLO na3sys009aog101.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754460Ab2D0WBv (ORCPT ); Fri, 27 Apr 2012 18:01:51 -0400 From: Kevin Hilman To: NeilBrown Cc: Tony Lindgren , Russell King , Samuel Ortiz , Thomas Gleixner , "Rafael J. Wysocki" , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, Santosh Shilimkar Subject: Re: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. Organization: Texas Instruments, Inc. References: <20120425025637.7832.14013.stgit@notabene.brown> <20120425030524.7832.52047.stgit@notabene.brown> <878vhi9qj8.fsf@ti.com> <20120427065040.3ba0fce2@notabene.brown> Date: Fri, 27 Apr 2012 15:01:52 -0700 In-Reply-To: <20120427065040.3ba0fce2@notabene.brown> (NeilBrown's message of "Fri, 27 Apr 2012 06:50:40 +1000") Message-ID: <8762ckzve7.fsf@ti.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org NeilBrown writes: > On Thu, 26 Apr 2012 13:39:07 -0700 Kevin Hilman wrote: > >> NeilBrown writes: >> >> > All interrupts can wake-from-sleep (I think) so it should be >> > permissible to call enable_irq_wake(). Setting this flag allows that. >> > >> > It is needed because without this, an interrupt which is delivered >> > during late suspend will get ignored but will not cause suspend to >> > abort. >> > If enable_irq_wake() is called and succeeds, check_wakuep_irqs() >> > will abort the suspend if the interrupt has fired. >> > >> > Signed-off-by: NeilBrown >> >> The name of this flag and the effect of setting it are somewhat >> confusing (e.g. why does skipping set_wake suddenly make wakeups work.) >> So I tried to make it clearer with a reworking of the changelog (below.) >> >> If I understood this correctly, and if you're OK with the updated >> changelog, I'll queue this up for v3.5. >> > > I'm very OK with your updated changelog - thanks. Filling in various bits > that I didn't know and clarifies the rest :-) Great, thanks. Adding ack from Santosh (thanks!) and queuing for v3.5[1] Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/pm-misc From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@ti.com (Kevin Hilman) Date: Fri, 27 Apr 2012 15:01:52 -0700 Subject: [PATCH 1/3] ARM: omap2+: set IRQCHIP_SKIP_SET_WAKE for INTC interrupts. In-Reply-To: <20120427065040.3ba0fce2@notabene.brown> (NeilBrown's message of "Fri, 27 Apr 2012 06:50:40 +1000") References: <20120425025637.7832.14013.stgit@notabene.brown> <20120425030524.7832.52047.stgit@notabene.brown> <878vhi9qj8.fsf@ti.com> <20120427065040.3ba0fce2@notabene.brown> Message-ID: <8762ckzve7.fsf@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org NeilBrown writes: > On Thu, 26 Apr 2012 13:39:07 -0700 Kevin Hilman wrote: > >> NeilBrown writes: >> >> > All interrupts can wake-from-sleep (I think) so it should be >> > permissible to call enable_irq_wake(). Setting this flag allows that. >> > >> > It is needed because without this, an interrupt which is delivered >> > during late suspend will get ignored but will not cause suspend to >> > abort. >> > If enable_irq_wake() is called and succeeds, check_wakuep_irqs() >> > will abort the suspend if the interrupt has fired. >> > >> > Signed-off-by: NeilBrown >> >> The name of this flag and the effect of setting it are somewhat >> confusing (e.g. why does skipping set_wake suddenly make wakeups work.) >> So I tried to make it clearer with a reworking of the changelog (below.) >> >> If I understood this correctly, and if you're OK with the updated >> changelog, I'll queue this up for v3.5. >> > > I'm very OK with your updated changelog - thanks. Filling in various bits > that I didn't know and clarifies the rest :-) Great, thanks. Adding ack from Santosh (thanks!) and queuing for v3.5[1] Kevin [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git for_3.5/pm-misc