All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Juan Quintela <quintela@redhat.com>, qemu-devel@nongnu.org
Cc: lvivier@redhat.com, dgilbert@redhat.com, peterx@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec when it is compiled in
Date: Wed, 22 Aug 2018 12:22:18 +0200	[thread overview]
Message-ID: <8769cf31-6c0d-1b48-a096-6ea36605d67e@redhat.com> (raw)
In-Reply-To: <20180822095421.11765-5-quintela@redhat.com>

On 2018-08-22 11:54, Juan Quintela wrote:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  tests/Makefile.include | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/Makefile.include b/tests/Makefile.include
> index 15296be246..9a918f7655 100644
> --- a/tests/Makefile.include
> +++ b/tests/Makefile.include
> @@ -290,8 +290,9 @@ endif
>  gcov-files-i386-$(CONFIG_USB_EHCI) += hw/usb/hcd-ehci.c
>  gcov-files-i386-y += hw/usb/dev-hid.c
>  gcov-files-i386-y += hw/usb/dev-storage.c
> -check-qtest-i386-y += tests/usb-hcd-xhci-test$(EXESUF)
> -gcov-files-i386-y += hw/usb/hcd-xhci.c
> +check-qtest-i386-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
> +gcov-files-i386-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c
> +gcov-files-i386-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci-nec.c
>  check-qtest-i386-y += tests/cpu-plug-test$(EXESUF)
>  check-qtest-i386-y += tests/q35-test$(EXESUF)
>  check-qtest-i386-y += tests/vmgenid-test$(EXESUF)
> @@ -349,8 +350,8 @@ check-qtest-ppc64-$(CONFIG_USB_OHCI) += tests/usb-hcd-ohci-test$(EXESUF)
>  gcov-files-ppc64-$(CONFIG_USB_OHCI) += hw/usb/hcd-ohci.c
>  check-qtest-ppc64-$(CONFIG_USB_UHCI) += tests/usb-hcd-uhci-test$(EXESUF)
>  gcov-files-ppc64-$(CONFIG_USB_UHCI) += hw/usb/hcd-uhci.c
> -check-qtest-ppc64-y += tests/usb-hcd-xhci-test$(EXESUF)
> -gcov-files-ppc64-y += hw/usb/hcd-xhci.c
> +check-qtest-ppc64-$(CONFIG_USB_XHCI_NEC) += tests/usb-hcd-xhci-test$(EXESUF)
> +gcov-files-ppc64-$(CONFIG_USB_XHCI) += hw/usb/hcd-xhci.c

Add hcd-xhci-nec.c here, too?

Anyway:

Reviewed-by: Thomas Huth <thuth@redhat.com>

  reply	other threads:[~2018-08-22 10:22 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-22  9:54 [Qemu-devel] [PATCH v3 00/10] Don't check disabled drivers Juan Quintela
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 01/10] configure: We don't want to clean configuration files Juan Quintela
2018-08-22 10:08   ` Thomas Huth
2018-08-22 14:24     ` Juan Quintela
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 02/10] check: Use land/lor when possible Juan Quintela
2018-08-22 10:13   ` Thomas Huth
2018-08-22 14:28     ` Juan Quintela
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 03/10] check: Only test isa-testdev when it is compiled in Juan Quintela
2018-08-22 10:18   ` Thomas Huth
2018-08-22 14:30     ` Juan Quintela
2018-08-22 16:34     ` Juan Quintela
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 04/10] check: Only test usb-xhci-nec " Juan Quintela
2018-08-22 10:22   ` Thomas Huth [this message]
2018-08-22 14:32     ` Juan Quintela
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 05/10] x86_64-softmmu: Configuration is identical to i386-softmmu Juan Quintela
2018-08-22 10:23   ` Thomas Huth
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 06/10] check: Only test ivshm when it is compiled in Juan Quintela
2018-08-22 10:26   ` Thomas Huth
2018-08-22 14:36     ` Juan Quintela
2018-08-22 14:43       ` Thomas Huth
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 07/10] check: Only test boot-serial when sga " Juan Quintela
2018-08-22 10:30   ` Thomas Huth
2018-08-22 14:37     ` Juan Quintela
2018-08-23  7:43       ` Gerd Hoffmann
2018-08-23  8:05         ` Thomas Huth
2018-08-23  9:48           ` Gerd Hoffmann
2018-08-23  9:53             ` Daniel P. Berrangé
2018-08-23 10:27               ` Gerd Hoffmann
2018-08-23 11:06               ` Juan Quintela
2018-08-27 10:53               ` Gerd Hoffmann
2018-08-28  8:19                 ` Daniel P. Berrangé
2018-08-28 10:20                   ` Gerd Hoffmann
2018-08-28 10:31                     ` Daniel P. Berrangé
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 08/10] check: Move VMXNET3 test to common Juan Quintela
2018-08-22 10:34   ` Thomas Huth
2018-08-22 10:41     ` Juan Quintela
2018-08-22 10:43       ` Thomas Huth
2018-08-22 14:39         ` Juan Quintela
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 09/10] check: Move endianess " Juan Quintela
2018-08-22 10:36   ` Thomas Huth
2018-08-22  9:54 ` [Qemu-devel] [PATCH v3 10/10] check: Move wdt_ib700 " Juan Quintela
2018-08-22 10:37   ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8769cf31-6c0d-1b48-a096-6ea36605d67e@redhat.com \
    --to=thuth@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.