From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64F8C432BE for ; Thu, 19 Aug 2021 14:31:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0B89610E5 for ; Thu, 19 Aug 2021 14:31:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240484AbhHSObm (ORCPT ); Thu, 19 Aug 2021 10:31:42 -0400 Received: from mga09.intel.com ([134.134.136.24]:44277 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238595AbhHSObl (ORCPT ); Thu, 19 Aug 2021 10:31:41 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10080"; a="216562207" X-IronPort-AV: E=Sophos;i="5.84,334,1620716400"; d="scan'208";a="216562207" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 07:31:03 -0700 X-IronPort-AV: E=Sophos;i="5.84,334,1620716400"; d="scan'208";a="489687511" Received: from mmdandap-mobl.amr.corp.intel.com (HELO [10.213.172.210]) ([10.213.172.210]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 07:31:02 -0700 Subject: Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373 To: Lukasz Majczak , Cezary Rojewski Cc: upstream@semihalf.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Curtis Malainey , stable@vger.kernel.org References: <20210819082414.39497-1-lma@semihalf.com> From: Pierre-Louis Bossart Message-ID: <87736cce-a96f-064e-6d60-71645ba46f13@linux.intel.com> Date: Thu, 19 Aug 2021 09:30:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210819082414.39497-1-lma@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/19/21 3:24 AM, Lukasz Majczak wrote: > Sparse warnings triggered truncating the IDs of some platform device > tables. Unfortunately kbl_da7219_max98373 was also truncated. > This patch is reverting the original ID. > Tested on Atlas chromebook. Instead of reverting, how about changing the remaining occurrences of the old name in the machine driver? sound/soc/intel/boards/kbl_da7219_max98927.c: if (!strcmp(pdev->name, "kbl_da7219_max98373") || sound/soc/intel/boards/kbl_da7219_max98927.c: .name = "kbl_da7219_max98373", > > Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters") > Cc: # 5.4+ > Tested-by: Lukasz Majczak > Signed-off-by: Lukasz Majczak > Suggested-by: Cezary Rojewski > --- > sound/soc/intel/common/soc-acpi-intel-kbl-match.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c > index 741bf2f9e081..8cab91a00b1a 100644 > --- a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c > +++ b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c > @@ -113,7 +113,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = { > }, > { > .id = "DLGS7219", > - .drv_name = "kbl_da7219_mx98373", > + .drv_name = "kbl_da7219_max98373", > .fw_filename = "intel/dsp_fw_kbl.bin", > .machine_quirk = snd_soc_acpi_codec_list, > .quirk_data = &kbl_7219_98373_codecs, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1667EC4338F for ; Thu, 19 Aug 2021 14:32:13 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 92A5D6112E for ; Thu, 19 Aug 2021 14:32:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 92A5D6112E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id A8F441678; Thu, 19 Aug 2021 16:31:19 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz A8F441678 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1629383529; bh=xOMozrX6bsutuK07v/c8+fqqeb5KY7vqYTpK1ntXWNo=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=GWdmVd4bvP491j3BSG0zW+zg2mvv82kLrnA26V31WbI3r0cwfIuBNSBEby0+ffSQI dnx6Wvt+2McuVk1xOEohDHMsYF+FSy43++jaRWNsQN++8Gw8gkmhMlhIdOa/mIEb8k W/etvhTt6IxZVyn6Ju+yn1HAWeh91rbdIwoxMqGE= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3E119F801EC; Thu, 19 Aug 2021 16:31:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B1E88F8026D; Thu, 19 Aug 2021 16:31:17 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id DA449F800F8 for ; Thu, 19 Aug 2021 16:31:06 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz DA449F800F8 X-IronPort-AV: E=McAfee;i="6200,9189,10080"; a="238684731" X-IronPort-AV: E=Sophos;i="5.84,334,1620716400"; d="scan'208";a="238684731" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 07:31:03 -0700 X-IronPort-AV: E=Sophos;i="5.84,334,1620716400"; d="scan'208";a="489687511" Received: from mmdandap-mobl.amr.corp.intel.com (HELO [10.213.172.210]) ([10.213.172.210]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2021 07:31:02 -0700 Subject: Re: [PATCH v2] ASoC: Intel: Fix platform ID matching for kbl_da7219_max98373 To: Lukasz Majczak , Cezary Rojewski References: <20210819082414.39497-1-lma@semihalf.com> From: Pierre-Louis Bossart Message-ID: <87736cce-a96f-064e-6d60-71645ba46f13@linux.intel.com> Date: Thu, 19 Aug 2021 09:30:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210819082414.39497-1-lma@semihalf.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Curtis Malainey , alsa-devel@alsa-project.org, upstream@semihalf.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 8/19/21 3:24 AM, Lukasz Majczak wrote: > Sparse warnings triggered truncating the IDs of some platform device > tables. Unfortunately kbl_da7219_max98373 was also truncated. > This patch is reverting the original ID. > Tested on Atlas chromebook. Instead of reverting, how about changing the remaining occurrences of the old name in the machine driver? sound/soc/intel/boards/kbl_da7219_max98927.c: if (!strcmp(pdev->name, "kbl_da7219_max98373") || sound/soc/intel/boards/kbl_da7219_max98927.c: .name = "kbl_da7219_max98373", > > Fixes: 94efd726b947 ("ASoC: Intel: kbl_da7219_max98357a: shrink platform_id below 20 characters") > Cc: # 5.4+ > Tested-by: Lukasz Majczak > Signed-off-by: Lukasz Majczak > Suggested-by: Cezary Rojewski > --- > sound/soc/intel/common/soc-acpi-intel-kbl-match.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c > index 741bf2f9e081..8cab91a00b1a 100644 > --- a/sound/soc/intel/common/soc-acpi-intel-kbl-match.c > +++ b/sound/soc/intel/common/soc-acpi-intel-kbl-match.c > @@ -113,7 +113,7 @@ struct snd_soc_acpi_mach snd_soc_acpi_intel_kbl_machines[] = { > }, > { > .id = "DLGS7219", > - .drv_name = "kbl_da7219_mx98373", > + .drv_name = "kbl_da7219_max98373", > .fw_filename = "intel/dsp_fw_kbl.bin", > .machine_quirk = snd_soc_acpi_codec_list, > .quirk_data = &kbl_7219_98373_codecs, >