From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8337C77B7F for ; Fri, 5 May 2023 15:24:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D87E42D19; Fri, 5 May 2023 17:23:29 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D87E42D19 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683300259; bh=kUfG6Wd4GMNewSYj6UQXSNBDwj+Q+xQXtoP9NNtmPaM=; h=Date:From:To:Subject:In-Reply-To:References:CC:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=d15HjN+iPArAYHgoLsfUffxkfsqcuXg+KPFcyEnd9JUi6hQE09ZGaMDxW2rYzn7hW cUBVtak4iauNneXYVXgsdQeWXYFcmdx9XqWyb6Eq8YBHGXkWUiEe5eHylyhvmtTPwo 8JgcY0JoKxUZLzoPS0HLLNcu1+qZPFi01PuTveCE= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id B733CF8052D; Fri, 5 May 2023 17:23:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 6E96EF8052D; Fri, 5 May 2023 17:23:01 +0200 (CEST) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 13D56F80520 for ; Fri, 5 May 2023 17:22:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 13D56F80520 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=YM+H7NWT; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=eezyx4TN Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 1CF74201B3; Fri, 5 May 2023 15:22:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1683300178; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bUYUgBFcb5VLakve7uhoDoLqc3SPNTwhofaFDHfciOU=; b=YM+H7NWT0Qh+1hBK81R3gT1xrp14R1//4d3+8gAjF2JfAVcevBq0GIpWK2AGREnnMuFqRd LOGjiX0mLjp4GzIxKRYigN5Mm7KKPv26Xa2KUP2x3sovqLnSM078dnGYGILvp5qSUDWQcY zVsYZTSzkM1sDqUniMIzglC8tEeD+v0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1683300178; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bUYUgBFcb5VLakve7uhoDoLqc3SPNTwhofaFDHfciOU=; b=eezyx4TNgPtBIUfSgaVxtIRrnAypT1ZL1E1SyP1cdtlGozLYL4dBFA3LxPMXpJRDLCXLOw W72zElKO07CrD1Dg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id E671613488; Fri, 5 May 2023 15:22:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id KsRBNVEfVWQtDgAAMHmgww (envelope-from ); Fri, 05 May 2023 15:22:57 +0000 Date: Fri, 05 May 2023 17:22:57 +0200 Message-ID: <877ctmiyzy.wl-tiwai@suse.de> From: Takashi Iwai To: Oswald Buddenhagen Subject: Re: [PATCH 2/7] ALSA: pcm: fix playback silence - use the actual new_hw_ptr for the threshold mode In-Reply-To: <20230505103140.2285622-2-oswald.buddenhagen@gmx.de> References: <20230505103140.2285622-1-oswald.buddenhagen@gmx.de> <20230505103140.2285622-2-oswald.buddenhagen@gmx.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Message-ID-Hash: 77FIIHMMRV2Q5CKX75C2AWWHRUTMQ6CZ X-Message-ID-Hash: 77FIIHMMRV2Q5CKX75C2AWWHRUTMQ6CZ X-MailFrom: tiwai@suse.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 05 May 2023 12:31:35 +0200, Oswald Buddenhagen wrote: > > From: Jaroslav Kysela > > The snd_pcm_playback_hw_avail() function uses runtime->status->hw_ptr. > Unfortunately, in case when we call this function from snd_pcm_update_hw_ptr0(), > this variable contains the previous hardware pointer. Use the new_hw_ptr > argument to calculate hw_avail (filled samples by the user space) to > correct the threshold comparison. > > The new_hw_ptr argument may also be set to ULONG_MAX which means the > initialization phase. In this case, use runtime->status->hw_ptr. > > Suggested-by: Oswald Buddenhagen > Signed-off-by: Jaroslav Kysela > Reviewed-by: Oswald Buddenhagen Here misses your Signed-off-by tag. Ditto for the patch 3. It's a legal requirement, and I can't apply patches without it. Could you resubmit the series quickly with your SOB? thanks, Takashi