Re: [PATCH v8] board: mntre: imx8mq: Add MNT Reform 2 board support

From: Vagrant Cascadian <vagrant@debian.org>
To: Patrick Wildt <patrick@blueri.se>, Stefano Babic <sbabic@denx.de>,
	Fabio Estevam <festevam@gmail.com>
Cc: u-boot@lists.denx.de, "Lukas F. Hartmann" <lukas@mntre.com>
Subject: Re: [PATCH v8] board: mntre: imx8mq: Add MNT Reform 2 board support
Date: Fri, 28 Apr 2023 14:39:26 -0700	[thread overview]
Message-ID: <877ctv8z5d.fsf@wireframe> (raw)
In-Reply-To: <87a5yr97ix.fsf@wireframe>

[-- Attachment #1: Type: text/plain, Size: 3240 bytes --]

On 2023-04-28, Vagrant Cascadian wrote:
> On 2023-02-05, Vagrant Cascadian wrote:
>> On 2023-02-06, Patrick Wildt wrote:
>>> The MNT Reform 2 is a modular DIY laptop.  In its initial version it
>>> is based on the BoundaryDevices i.MX8MQ SoM.  Some parts have been
>>> lifted from BoundaryDevices official U-Boot downstream project.
>>>
>>> Signed-off-by: Patrick Wildt <patrick@blueri.se>
>>
>> Tested booting Debian with a 6.1.x linux kernel on a mnt/reform2 using
>> nvme rootfs and microsd /boot. Some oddities with video and wifi that do
>> not occur with the vendor u-boot, but seems like huge progress.
>
> The patch still applies to master; could this be considered for merging
> soon?

I've also verified that the patch not only builds, but actually boots,
based on git commit c9c2c95d4cd27fe0cd41fe13a863899d268f973c (and also
works on v2023.04, for good measure)...

Tested-by: Vagrant Cascadian <vagrant@debian.org>

live well,
  vagrant

>>> ---
>>> Changes since v7:
>>> - Re-added lost ramdisk_addr_r.
>>> Changes since v6:
>>> - Cleaned up some CONFIG_* pollution.
>>> Changes since v5:
>>> - Adjusted to further Binman changes.
>>> - Adjusted to further Kconfig conversions.
>>> - Removed some phy init in favor of DM.
>>> - Removed some pinmux which are now handled by DM_SERIAL.
>>> - Compared with Librem5/EVK and adjusted for similarity.
>>> Changes since v4:
>>> - Adjusted to Kconfig conversions.
>>> - Removed U-Boot-specific device tree changes.
>>> - Synced device tree to Linux v5.19-rc3.
>>> Changes since v3:
>>> - Adjusted to Binman changes in main branch.
>>> - Cleaned up environment variables akin to i.MX8MM.
>>> - Added vendor-prefix to device tree filename.
>>> - Provided ramdisk_addr_r.
>>> Changes since v2:
>>> - Switched to Binman.
>>> Changes since v1:
>>> - Synced DTS with files in Linux git repo.
>>> - Added support for USB host ports.
>>>
>>>  arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi   |   11 +
>>>  arch/arm/mach-imx/imx8m/Kconfig               |    7 +
>>>  board/mntre/imx8mq_reform2/Kconfig            |   15 +
>>>  board/mntre/imx8mq_reform2/MAINTAINERS        |    7 +
>>>  board/mntre/imx8mq_reform2/Makefile           |   12 +
>>>  board/mntre/imx8mq_reform2/imx8mq_reform2.c   |  171 +++
>>>  board/mntre/imx8mq_reform2/lpddr4_timing.c    | 1014 +++++++++++++++++
>>>  .../mntre/imx8mq_reform2/lpddr4_timing_ch2.h  |   95 ++
>>>  board/mntre/imx8mq_reform2/spl.c              |  260 +++++
>>>  configs/imx8mq_reform2_defconfig              |  107 ++
>>>  include/configs/imx8mq_reform2.h              |   67 ++
>>>  11 files changed, 1766 insertions(+)
>>>  create mode 100644 arch/arm/dts/imx8mq-mnt-reform2-u-boot.dtsi
>>>  create mode 100644 board/mntre/imx8mq_reform2/Kconfig
>>>  create mode 100644 board/mntre/imx8mq_reform2/MAINTAINERS
>>>  create mode 100644 board/mntre/imx8mq_reform2/Makefile
>>>  create mode 100644 board/mntre/imx8mq_reform2/imx8mq_reform2.c
>>>  create mode 100644 board/mntre/imx8mq_reform2/lpddr4_timing.c
>>>  create mode 100644 board/mntre/imx8mq_reform2/lpddr4_timing_ch2.h
>>>  create mode 100644 board/mntre/imx8mq_reform2/spl.c
>>>  create mode 100644 configs/imx8mq_reform2_defconfig
>>>  create mode 100644 include/configs/imx8mq_reform2.h

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 227 bytes --]