From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3886C3DA7D for ; Thu, 5 Jan 2023 20:46:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 27DA210E816; Thu, 5 Jan 2023 20:46:21 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32AB610E816 for ; Thu, 5 Jan 2023 20:46:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672951578; x=1704487578; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Q6wh+vBimQsOwOrPDXPBkrNA8gvr1Z0AmthrcdsxsqI=; b=knZ7SgpFHi6o7o+Q0a32SqVH5fN92VClf0hoMhdnV8jMSRXcBgROGuu5 9nxZe8zFiW92zjlGM5s8WHiSbWer2h72zJLiRPlCJKxNZajo2IDJsMDqJ q+For5OCH5PBOnhCHTiXauxTDJCjiyhotvsD+hkE9Vg5x2l8+WwJ1g+OX y1pFHGcEQx867A7zJCRsW1wQrERzV8LbqIik3w2a8+d32JWkONcf+JAjl MGRZxzhc9tlER1bV6Zm1OmIDRwc7sxFXiL5+OEETs971DqcaMCOVs7Tw2 j42QbWdsR3gcnK37+wxR5Cd3AN2dvvIbAIoo4Q3dtXm/SbNFz+FKG7lwB w==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="386773236" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="386773236" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 12:46:17 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="688059855" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="688059855" Received: from adixit-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.62.238]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 12:46:17 -0800 Date: Thu, 05 Jan 2023 12:46:17 -0800 Message-ID: <877cy0g15y.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Nirmoy Das In-Reply-To: <20230105203843.30663-1-nirmoy.das@intel.com> References: <20230105203843.30663-1-nirmoy.das@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH] drm/i915: Update docs in intel_wakeref.h X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, andrzej.hajda@intel.com, chris.p.wilson@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 05 Jan 2023 12:38:43 -0800, Nirmoy Das wrote: > > Fix docs for __intel_wakeref_put() and intel_wakeref_get() to > reflect current behaviour. Reviewed-by: Ashutosh Dixit > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/intel_wakeref.h | 21 ++++++++++----------- > 1 file changed, 10 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_wakeref.h b/drivers/gpu/drm/i915/intel_wakeref.h > index 4f4c2e15e736..71b8a63f6f10 100644 > --- a/drivers/gpu/drm/i915/intel_wakeref.h > +++ b/drivers/gpu/drm/i915/intel_wakeref.h > @@ -68,11 +68,12 @@ void __intel_wakeref_put_last(struct intel_wakeref *wf, unsigned long flags); > * @wf: the wakeref > * > * Acquire a hold on the wakeref. The first user to do so, will acquire > - * the runtime pm wakeref and then call the @fn underneath the wakeref > - * mutex. > + * the runtime pm wakeref and then call the intel_wakeref_ops->get() > + * underneath the wakeref mutex. > * > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > - * will be released and the acquisition unwound, and an error reported. > + * Note that intel_wakeref_ops->get() is allowed to fail, in which case > + * the runtime-pm wakeref will be released and the acquisition unwound, > + * and an error reported. > * > * Returns: 0 if the wakeref was acquired successfully, or a negative error > * code otherwise. > @@ -130,19 +131,17 @@ intel_wakeref_might_get(struct intel_wakeref *wf) > } > > /** > - * intel_wakeref_put_flags: Release the wakeref > + * __intel_wakeref_put: Release the wakeref > * @wf: the wakeref > * @flags: control flags > * > * Release our hold on the wakeref. When there are no more users, > - * the runtime pm wakeref will be released after the @fn callback is called > - * underneath the wakeref mutex. > + * the runtime pm wakeref will be released after the intel_wakeref_ops->put() > + * callback is called underneath the wakeref mutex. > * > - * Note that @fn is allowed to fail, in which case the runtime-pm wakeref > - * is retained and an error reported. > + * Note that intel_wakeref_ops->put() is allowed to fail, in which case the > + * runtime-pm wakeref is retained. > * > - * Returns: 0 if the wakeref was released successfully, or a negative error > - * code otherwise. > */ > static inline void > __intel_wakeref_put(struct intel_wakeref *wf, unsigned long flags) > -- > 2.38.0 >