From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77131C433EF for ; Fri, 29 Apr 2022 01:21:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09EC810EB48; Fri, 29 Apr 2022 01:21:09 +0000 (UTC) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0123910EB48 for ; Fri, 29 Apr 2022 01:21:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651195267; x=1682731267; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=ZtILwKNKrvvWALpDyZrn8nhkcNgSle2qgRBeHK6uJYI=; b=MkCQ+MRLSHwdGPwlrnjEbU7kPtZSYBjCh4IwcJ9CZiN/+W4aSdYgZbwQ DGfRcCJ7r6ZuXL+Wg8BQ/zZaMluDtBDXYMO3fhmCH3isJ1qkZJy2r7eIL Of7VxuN8QVIBV3Ue1/rPgelzgFpf3FpKXkk2Fa7Rz0EqoKWQvqME7qyo1 KT3VEdZ0B5rAeuZqyyYVN/RpSzLADjAU1UdqPBUEUCeYNFVJGm1p5BEzr 5wmTGo8kU9RCELQ/euyK0Dw2HXe0ff9Z4IqpmE1VacOWsH/6qp7iPRuMu rr1rDS5N451v6CCmoeOhaIM21CAxMxLCTq+jpwqST2lCrf4LWViEtTKFM w==; X-IronPort-AV: E=McAfee;i="6400,9594,10331"; a="291653246" X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="291653246" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 18:21:07 -0700 X-IronPort-AV: E=Sophos;i="5.91,296,1647327600"; d="scan'208";a="560016549" Received: from adixit-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.209.8.103]) by orsmga007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2022 18:21:07 -0700 Date: Thu, 28 Apr 2022 18:21:07 -0700 Message-ID: <877d7865x8.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Andi Shyti In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [Intel-gfx] [PATCH 6/9] drm/i915/gt: Add media RP0/RPn to per-gt sysfs X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Sun, 24 Apr 2022 15:05:47 -0700, Andi Shyti wrote: > > Hi Ashutosh, > > [...] > > > +static ssize_t media_RP0_freq_mhz_show(struct device *dev, > > + struct device_attribute *attr, > > + char *buff) > > +{ > > + struct intel_gt *gt = intel_gt_sysfs_get_drvdata(dev, attr->attr.name); > > + u32 val; > > + int err; > > + > > + err = __intel_gt_pcode_read(gt, XEHPSDV_PCODE_FREQUENCY_CONFIG, > > + PCODE_MBOX_FC_SC_READ_FUSED_P0, > > + PCODE_MBOX_DOMAIN_MEDIAFF, &val); > > + > > + if (err) > > + return err; > > + > > + /* data_out - Fused P0 for domain ID in units of 50 MHz */ > > this comment doesn't say much, can we make it a bit clearer? The > same for the one below. Hopefully I've made it a bit clearer in v3. > > The rest looks good: > > Reviewed-by: Andi Shyti Retaining the R-b, since change in v3 is just s/gt/gt->uncore/.