From: "Marcin Niestrój" <m.niestroj@grinn-global.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency
Date: Thu, 28 Oct 2021 23:16:00 +0200 [thread overview]
Message-ID: <877ddwetpm.fsf@grinn-global.com> (raw)
In-Reply-To: <20211028160307.1123157-1-fontaine.fabrice@gmail.com>
Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> libcap is an optional dependency which is enabled by default since the
> addition of the package in commit
> 1d2bb469078b5818aa2390b9868cd632200f17a2
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/netdata/netdata.mk | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/package/netdata/netdata.mk b/package/netdata/netdata.mk
> index 1c20c49dee..d66a9602e2 100644
> --- a/package/netdata/netdata.mk
> +++ b/package/netdata/netdata.mk
> @@ -33,6 +33,13 @@ else
> NETDATA_CONF_OPTS += --disable-jsonc
> endif
>
> +ifeq ($(BR2_PACKAGE_LIBCAP),y)
> +NETDATA_CONF_OPTS += --with-libcap
> +NETDATA_DEPENDENCIES += libcap
> +else
> +NETDATA_CONF_OPTS += --without-libcap
> +endif
> +
> ifeq ($(BR2_PACKAGE_NFACCT),y)
> NETDATA_CONF_OPTS += --enable-plugin-nfacct
> NETDATA_DEPENDENCIES += nfacct
Reviewed-by: Marcin Niestroj <m.niestroj@grinn-global.com>
--
Marcin Niestrój
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-10-28 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-28 16:03 [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Fabrice Fontaine
2021-10-28 16:03 ` [Buildroot] [PATCH 2/2] package/netdata: disable unit tests Fabrice Fontaine
2021-10-28 21:16 ` Marcin Niestrój
2021-11-05 16:24 ` Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
2021-10-28 21:16 ` Marcin Niestrój [this message]
2021-11-05 16:23 ` [Buildroot] [PATCH 1/2] package/netdata: add libcap optional dependency Peter Korsgaard
2021-11-08 16:01 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ddwetpm.fsf@grinn-global.com \
--to=m.niestroj@grinn-global.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.