From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BDCEC433FE for ; Fri, 29 Oct 2021 12:34:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3441F6117A for ; Fri, 29 Oct 2021 12:34:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231493AbhJ2MhJ (ORCPT ); Fri, 29 Oct 2021 08:37:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:49460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231409AbhJ2MhJ (ORCPT ); Fri, 29 Oct 2021 08:37:09 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 2CE4461166; Fri, 29 Oct 2021 12:34:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1635510880; bh=urGBo3TyC1ivuzibef95x4hk4YwD63F00Hq8ev8XTyo=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=njV4Sknwn7bz0F8040IY2q+pzIl9x8AR5fNcKdM00v7Dky+E1w6+T3DhNV07zfhXP VW6L+lUZUhDurLgbpEFa2WCWbr/FpIeBYggoC0eEsWyyWJL5UVNViZodCk0nPwUi4l 1c2H5HeSW7H1UZhIVK4yAtEszj2f/6exCpqsHk2VfvsxUVXInK/ZybwlMxm7BILflU ttsMXHZYsT9J12BBvYUj1M8PU/TjzMx5hQvNoGUIhdH1qz82P0nzhEPpyaka4u74XO +lUMNxG5hsuTpGDfdGqjO9TmPjkaQ+9nNPbjSxsa4Wc3a0OyT3opwMxGwOGjzYRfeX s8OiGRD6OuY6A== References: <20211028211753.573480-1-jaschultzMS@gmail.com> <20211028211753.573480-3-jaschultzMS@gmail.com> <87fsskqvvc.fsf@kernel.org> User-agent: mu4e 1.6.6; emacs 28.0.60 From: Felipe Balbi To: Andy Shevchenko Cc: Jarrett Schultz , Rob Herring , Andy Gross , Bjorn Andersson , Hans de Goede , Mark Gross , Maximilian Luz , "linux-arm-msm@vger.kernel.org" , "platform-driver-x86@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jarrett Schultz Subject: Re: [PATCH 2/3] platform: surface: Add surface xbl Date: Fri, 29 Oct 2021 15:32:01 +0300 In-reply-to: Message-ID: <877ddwqaas.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi, Andy Shevchenko writes: > On Fri, Oct 29, 2021 at 7:48 AM Felipe Balbi wrote: >> Andy Shevchenko writes: > > ... > >> > Capital L will be better to read and understand the >> > abbreviation. Actually usually we do something like this: >> > >> > Extensible Boot Loader (EBL) >> >> nah, this is silly Andy. It's just capitalized as eXtensible Boot >> Loader, very much akin to eXtensible Host Controller Interface. > > My point here is to have a full name followed by the abbreviation. and > n(O)t in (F)ancy st(Y)le. too bad my patch removing acronyms from the kernel got rejects :-p Seriously, this is pretty pointless. You're vouching for something that will just cause confusion. Every piece of internal documentation refers to xbl and you want this to be renamed to ebl because it looks nicer for you. Thanks, but no thanks. >> > +static const struct attribute_group inputs_attr_group = { >> > + .attrs = inputs_attrs, >> > +}; >> > + >> > +static u8 surface_xbl_readb(void __iomem *base, u32 offset) >> > +{ >> > + return readb(base + offset); >> > +} >> > + >> > +static u16 surface_xbl_readw(void __iomem *base, u32 offset) >> > +{ >> > + return readw(base + offset); >> > +} >> > >> > Either use corresponding io accessors in-line, or make first parameter >> > to be sirface_xbl pointer. Otherwise these helpers useless. >> >> I agree with passing surface_xbl point as first parameter, but calling >> the accessors pointless is a bit much. At a minimum, they make it easier >> to ftrace the entire driver by simply ftracing surface_xbl_* > > My point is that the above seems half-baked. It's pointless to have a > func(a,b) { return readl(a + b); }. It doesn't add value. sure it does. echo surface_xbl_* > ftrace_filter_function (or whatever the filename was) it reason enough IMHO. Not to mention that these little accessors will likely be optimized by the compiler. -- balbi