All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>,
	Romain Naour <romain.naour@gmail.com>,
	"Yann E . MORIN" <yann.morin.1998@free.fr>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/mesa3d: remove unnecessary passing of CFLAGS
Date: Sat, 09 Oct 2021 13:46:54 +0200	[thread overview]
Message-ID: <877demv2s1.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20211004203535.923467-1-giulio.benetti@benettiengineering.com> (Giulio Benetti's message of "Mon, 4 Oct 2021 22:35:35 +0200")

>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:

 > This package uses meson-package infrastracture, so we don't need to
 > explicitly pass its additional CFLAGS to some variable. The only thing we
 > need to pass them is to use MESA3D_CFLAGS, because in package/pkg-meson.mk
 > we have:
 > $(2)_CFLAGS ?= $$(TARGET_CFLAGS)
 > that makes the work automatically, where $(2) is exactly the package name,
 > though $(2)_CFLAGS expands to MESA3D_CFLAGS.
 > So let's remove the MESA3D_CONF_OPTS += -DCMAKE_C_FLAGS="$(MESA3D_CFLAGS)"
 > line that has been added by mistake.

 > Note: this doesn't fix any bug, but remove an unnecessary and ambiguos line

 > Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Committed to 2021.02.x, 2021.05.x and 2021.08.x, thanks (together with
'package/mesa3d: fix build on m68k').

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      parent reply	other threads:[~2021-10-09 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-04 20:35 [Buildroot] [PATCH] package/mesa3d: remove unnecessary passing of CFLAGS Giulio Benetti
2021-10-07 20:13 ` Peter Korsgaard
2021-10-09 11:46 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877demv2s1.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=bernd.kuhls@t-online.de \
    --cc=buildroot@buildroot.org \
    --cc=giulio.benetti@benettiengineering.com \
    --cc=romain.naour@gmail.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.