From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78022C433F5 for ; Thu, 2 Sep 2021 18:03:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 512AA610A2 for ; Thu, 2 Sep 2021 18:03:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346877AbhIBSEf (ORCPT ); Thu, 2 Sep 2021 14:04:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:43310 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346676AbhIBSEd (ORCPT ); Thu, 2 Sep 2021 14:04:33 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E19A76109E; Thu, 2 Sep 2021 18:03:34 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mLr3k-008gvm-VA; Thu, 02 Sep 2021 19:03:33 +0100 Date: Thu, 02 Sep 2021 19:03:32 +0100 Message-ID: <877dfyx3bf.wl-maz@kernel.org> From: Marc Zyngier To: Jia He Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Liu Shixin , Eric Auger , Kees Cook , Nick Desaulniers , Shenming Lu , Sami Tolvanen , Lorenzo Pieralisi , Xiaoming Ni , Zenghui Yu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations In-Reply-To: <20210902002801.32618-1-justin.he@arm.com> References: <20210902002801.32618-1-justin.he@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: justin.he@arm.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, liushixin2@huawei.com, eric.auger@redhat.com, keescook@chromium.org, ndesaulniers@google.com, lushenming@huawei.com, samitolvanen@google.com, lorenzo.pieralisi@arm.com, nixiaoming@huawei.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jia, Once again: please add a cover letter when you have a patch series. It isn't rocket science, and Git will do it for you. On Thu, 02 Sep 2021 01:28:00 +0100, Jia He wrote: > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > allocations"), it would be better to make arm64 vgic consistent with > common kvm codes. > > The memory allocations of VM scope should be charged into VM process > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > There remained a case in vgic_set_kvm_info() since this allocation is > global, not in VM scope. > > Signed-off-by: Jia He > --- > arch/arm64/kvm/vgic/vgic-debug.c | 2 +- > arch/arm64/kvm/vgic/vgic-init.c | 2 +- > arch/arm64/kvm/vgic/vgic-irqfd.c | 2 +- > arch/arm64/kvm/vgic/vgic-its.c | 14 +++++++------- > arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- > arch/arm64/kvm/vgic/vgic-v4.c | 2 +- > 6 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c > index f38c40a76251..e6a01f210df9 100644 > --- a/arch/arm64/kvm/vgic/vgic-debug.c > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > @@ -92,7 +92,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > goto out; > } > > - iter = kmalloc(sizeof(*iter), GFP_KERNEL); > + iter = kmalloc(sizeof(*iter), GFP_KERNEL_ACCOUNT); This really isn't an allocation made in the context of a VM. I don't think this hunk belongs here. Thanks, M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9844DC433FE for ; Thu, 2 Sep 2021 18:03:43 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 0B8D1610CC for ; Thu, 2 Sep 2021 18:03:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0B8D1610CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 95C904B0EF; Thu, 2 Sep 2021 14:03:41 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 19qjirVqOeDq; Thu, 2 Sep 2021 14:03:40 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8F28D4B104; Thu, 2 Sep 2021 14:03:40 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A051D4B0EF for ; Thu, 2 Sep 2021 14:03:39 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qShbv-QgX-5X for ; Thu, 2 Sep 2021 14:03:36 -0400 (EDT) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id 062CC4B093 for ; Thu, 2 Sep 2021 14:03:36 -0400 (EDT) Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E19A76109E; Thu, 2 Sep 2021 18:03:34 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mLr3k-008gvm-VA; Thu, 02 Sep 2021 19:03:33 +0100 Date: Thu, 02 Sep 2021 19:03:32 +0100 Message-ID: <877dfyx3bf.wl-maz@kernel.org> From: Marc Zyngier To: Jia He Subject: Re: [PATCH 1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations In-Reply-To: <20210902002801.32618-1-justin.he@arm.com> References: <20210902002801.32618-1-justin.he@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: justin.he@arm.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, liushixin2@huawei.com, eric.auger@redhat.com, keescook@chromium.org, ndesaulniers@google.com, lushenming@huawei.com, samitolvanen@google.com, lorenzo.pieralisi@arm.com, nixiaoming@huawei.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Cc: Xiaoming Ni , Shenming Lu , Kees Cook , Will Deacon , Catalin Marinas , Nick Desaulniers , linux-kernel@vger.kernel.org, Liu Shixin , Lorenzo Pieralisi , Sami Tolvanen , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu Jia, Once again: please add a cover letter when you have a patch series. It isn't rocket science, and Git will do it for you. On Thu, 02 Sep 2021 01:28:00 +0100, Jia He wrote: > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > allocations"), it would be better to make arm64 vgic consistent with > common kvm codes. > > The memory allocations of VM scope should be charged into VM process > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > There remained a case in vgic_set_kvm_info() since this allocation is > global, not in VM scope. > > Signed-off-by: Jia He > --- > arch/arm64/kvm/vgic/vgic-debug.c | 2 +- > arch/arm64/kvm/vgic/vgic-init.c | 2 +- > arch/arm64/kvm/vgic/vgic-irqfd.c | 2 +- > arch/arm64/kvm/vgic/vgic-its.c | 14 +++++++------- > arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- > arch/arm64/kvm/vgic/vgic-v4.c | 2 +- > 6 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c > index f38c40a76251..e6a01f210df9 100644 > --- a/arch/arm64/kvm/vgic/vgic-debug.c > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > @@ -92,7 +92,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > goto out; > } > > - iter = kmalloc(sizeof(*iter), GFP_KERNEL); > + iter = kmalloc(sizeof(*iter), GFP_KERNEL_ACCOUNT); This really isn't an allocation made in the context of a VM. I don't think this hunk belongs here. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2D2C433EF for ; Thu, 2 Sep 2021 18:05:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6C24060F4B for ; Thu, 2 Sep 2021 18:05:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6C24060F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Message-ID:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iIjWCIed313ZsRWa+SowK1yod2R5eNTq4KJsdx5VcUw=; b=Qx4BBrPvEsfYy9 TkTraDHsbXTVqKjCWBKVsIvXlIefQSGYBdJfd3bY1J6XsaU4YdRu5dW5DIscd/mB4uvcsXAIz79Oh RWNVtUj4hK5hcLDM89JB204HdnJvMFYbn0XCTh+1899vfNOlB0H6a6bkGW+hp3wvEZFBJwFe7yVeR 8a2U/10rixVpBJl1OvFGC5zu4AoOohNMLus/wdFH8/Og2o7SuxFIOF9rKTbMTZaZU3pUaqC71mNvE ysr+6laluu8SrRJkjxDMxK2EoWTz/yau5n+HZ1pRrAiZUQfMSM5jecr+qMmmceCmNv0CWL8F/ho21 PKxvhk5fkEzOR1k+Ug9g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLr3r-00AGEc-V3; Thu, 02 Sep 2021 18:03:40 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mLr3n-00AGDy-R2 for linux-arm-kernel@lists.infradead.org; Thu, 02 Sep 2021 18:03:37 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E19A76109E; Thu, 2 Sep 2021 18:03:34 +0000 (UTC) Received: from sofa.misterjones.org ([185.219.108.64] helo=why.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mLr3k-008gvm-VA; Thu, 02 Sep 2021 19:03:33 +0100 Date: Thu, 02 Sep 2021 19:03:32 +0100 Message-ID: <877dfyx3bf.wl-maz@kernel.org> From: Marc Zyngier To: Jia He Cc: James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Liu Shixin , Eric Auger , Kees Cook , Nick Desaulniers , Shenming Lu , Sami Tolvanen , Lorenzo Pieralisi , Xiaoming Ni , Zenghui Yu , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] KVM: arm64: vgic: Add memcg accounting to vgic allocations In-Reply-To: <20210902002801.32618-1-justin.he@arm.com> References: <20210902002801.32618-1-justin.he@arm.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: justin.he@arm.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, catalin.marinas@arm.com, will@kernel.org, liushixin2@huawei.com, eric.auger@redhat.com, keescook@chromium.org, ndesaulniers@google.com, lushenming@huawei.com, samitolvanen@google.com, lorenzo.pieralisi@arm.com, nixiaoming@huawei.com, yuzenghui@huawei.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210902_110335_953828_4E26B103 X-CRM114-Status: GOOD ( 23.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Jia, Once again: please add a cover letter when you have a patch series. It isn't rocket science, and Git will do it for you. On Thu, 02 Sep 2021 01:28:00 +0100, Jia He wrote: > > Inspired by commit 254272ce6505 ("kvm: x86: Add memcg accounting to KVM > allocations"), it would be better to make arm64 vgic consistent with > common kvm codes. > > The memory allocations of VM scope should be charged into VM process > cgroup, hence change GFP_KERNEL to GFP_KERNEL_ACCOUNT. > > There remained a case in vgic_set_kvm_info() since this allocation is > global, not in VM scope. > > Signed-off-by: Jia He > --- > arch/arm64/kvm/vgic/vgic-debug.c | 2 +- > arch/arm64/kvm/vgic/vgic-init.c | 2 +- > arch/arm64/kvm/vgic/vgic-irqfd.c | 2 +- > arch/arm64/kvm/vgic/vgic-its.c | 14 +++++++------- > arch/arm64/kvm/vgic/vgic-mmio-v3.c | 2 +- > arch/arm64/kvm/vgic/vgic-v4.c | 2 +- > 6 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/kvm/vgic/vgic-debug.c b/arch/arm64/kvm/vgic/vgic-debug.c > index f38c40a76251..e6a01f210df9 100644 > --- a/arch/arm64/kvm/vgic/vgic-debug.c > +++ b/arch/arm64/kvm/vgic/vgic-debug.c > @@ -92,7 +92,7 @@ static void *vgic_debug_start(struct seq_file *s, loff_t *pos) > goto out; > } > > - iter = kmalloc(sizeof(*iter), GFP_KERNEL); > + iter = kmalloc(sizeof(*iter), GFP_KERNEL_ACCOUNT); This really isn't an allocation made in the context of a VM. I don't think this hunk belongs here. Thanks, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel