From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C2EBC4338F for ; Tue, 3 Aug 2021 13:45:44 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A4D5B60EE8 for ; Tue, 3 Aug 2021 13:45:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A4D5B60EE8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:54168 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mAujm-0003BP-L5 for qemu-devel@archiver.kernel.org; Tue, 03 Aug 2021 09:45:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50220) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAuiH-0002TU-Gl for qemu-devel@nongnu.org; Tue, 03 Aug 2021 09:44:09 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:47815) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mAuiG-0005ie-30 for qemu-devel@nongnu.org; Tue, 03 Aug 2021 09:44:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627998246; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lfRElWSU68uPwvgvwhMbvGCrMPhNaXguWC9QR4UQhbQ=; b=PQpk9f0egaG9jeZtB7Qty+DchOc6ylshMwevN1TtHaWMLSnK8Xttd9nYaHW7gIrWN/uA8/ C2WvSm7BKJ6zaObn3aRmbNxla6MIV6QIevQxqWm9uADLDNeT4FOMvzqpjMCG4En17Ounyq SXiXwBhVUs0JmVC/BMVOp6huiCwWOsA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-541-k-obqj3-PWysakhvUViqhg-1; Tue, 03 Aug 2021 09:44:05 -0400 X-MC-Unique: k-obqj3-PWysakhvUViqhg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0F672102622D for ; Tue, 3 Aug 2021 13:44:03 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-112-12.ams2.redhat.com [10.36.112.12]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6EFC317B4F; Tue, 3 Aug 2021 13:44:02 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id D3EDF11380A0; Tue, 3 Aug 2021 15:44:00 +0200 (CEST) From: Markus Armbruster To: marcandre.lureau@redhat.com Subject: Re: [PATCH v6 00/11] qapi: untie 'if' conditions from C preprocessor References: <20210618102507.3761128-1-marcandre.lureau@redhat.com> Date: Tue, 03 Aug 2021 15:44:00 +0200 In-Reply-To: <20210618102507.3761128-1-marcandre.lureau@redhat.com> (marcandre lureau's message of "Fri, 18 Jun 2021 14:24:56 +0400") Message-ID: <877dh2r6cf.fsf@dusky.pond.sub.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=armbru@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=armbru@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.699, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eric Blake , jsnow@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" marcandre.lureau@redhat.com writes: > From: Marc-Andr=C3=A9 Lureau > > Hi, > > This series makes the 'if' conditions less liberal, by formalizing a simp= le > expression tree based on bare boolean logic of configure option identifie= rs. > > (this allows to express conditions in Rust in my QAPI-Rust PoC series) > > thanks I like this overall. The commit messages are rather terse in places. I have a few questions, I asked for a few minor tweaks, and I also noted a few possible improvements that can be done on top. I wonder whether we can drop PATCH 04. Let's discuss my findings, then decide whether we want a respin. Thank you!