From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 662AAC48BCD for ; Wed, 9 Jun 2021 15:38:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4CD1961285 for ; Wed, 9 Jun 2021 15:38:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234966AbhFIPjy (ORCPT ); Wed, 9 Jun 2021 11:39:54 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:35137 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234629AbhFIPjw (ORCPT ); Wed, 9 Jun 2021 11:39:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623253077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aoPcTEuzpei3fqr/p6OooHtZD65GcAITgVzjPSwm+HY=; b=UJ8EmMvFzN2inwkFBO7zXo7ke34xqn1YJ/AdSJwIB9NcaRTNRURy+8+yMT7CaISSdxqjGi 6caYTszpd+vodQ1bLsUPKC66h/hZfgrGXhAF/ZF6WHLPvTyhgR/Gl6MdYCe7Gq0ld3gKwZ XqQX3AUmIfj09GKfIy0HiFMuqk9NB0g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-G0yU6th6OIe9agOZauWL6A-1; Wed, 09 Jun 2021 11:37:56 -0400 X-MC-Unique: G0yU6th6OIe9agOZauWL6A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9E21800D62; Wed, 9 Jun 2021 15:37:54 +0000 (UTC) Received: from localhost (ovpn-113-134.ams2.redhat.com [10.36.113.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1986F60CCC; Wed, 9 Jun 2021 15:37:50 +0000 (UTC) From: Cornelia Huck To: Laurent Vivier , Paolo Bonzini , Thomas Huth , Andrew Jones Cc: kvm@vger.kernel.org, David Hildenbrand , Janosch Frank , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org Subject: Re: [kvm-unit-tests PATCH v2 2/7] lib: unify header guards In-Reply-To: Organization: Red Hat GmbH References: <20210609143712.60933-1-cohuck@redhat.com> <20210609143712.60933-3-cohuck@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Wed, 09 Jun 2021 17:37:49 +0200 Message-ID: <877dj3122a.fsf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-s390@vger.kernel.org On Wed, Jun 09 2021, Laurent Vivier wrote: > On 09/06/2021 16:37, Cornelia Huck wrote: >> Standardize header guards to _LIB_HEADER_H_. >> >> Signed-off-by: Cornelia Huck >> --- >> lib/alloc_page.h | 4 ++-- >> lib/libcflat.h | 4 ++-- >> lib/list.h | 4 ++-- >> lib/pci-edu.h | 4 ++-- >> lib/pci-host-generic.h | 4 ++-- >> lib/setjmp.h | 4 ++-- >> lib/string.h | 6 +++--- >> lib/vmalloc.h | 4 ++-- >> 8 files changed, 17 insertions(+), 17 deletions(-) > > What about lib/argv.h and lib/pci.h? argv.h does not have a header guard yet (it probably should?) I forgot to commit my changes to pci.h, I think :( > > And there is also this instance of CONFIG_H in lib/config.h generated > by configure. Yeah, we should tweak the generator for that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F21A8C48BCF for ; Wed, 9 Jun 2021 15:38:01 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 69B6761359 for ; Wed, 9 Jun 2021 15:38:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69B6761359 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id D5200407EF; Wed, 9 Jun 2021 11:38:00 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0HogbHCGQUTC; Wed, 9 Jun 2021 11:37:59 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C608840CC5; Wed, 9 Jun 2021 11:37:59 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4B9FB40874 for ; Wed, 9 Jun 2021 11:37:58 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vyegadrshy8k for ; Wed, 9 Jun 2021 11:37:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 68E8D407EF for ; Wed, 9 Jun 2021 11:37:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1623253077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aoPcTEuzpei3fqr/p6OooHtZD65GcAITgVzjPSwm+HY=; b=UJ8EmMvFzN2inwkFBO7zXo7ke34xqn1YJ/AdSJwIB9NcaRTNRURy+8+yMT7CaISSdxqjGi 6caYTszpd+vodQ1bLsUPKC66h/hZfgrGXhAF/ZF6WHLPvTyhgR/Gl6MdYCe7Gq0ld3gKwZ XqQX3AUmIfj09GKfIy0HiFMuqk9NB0g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-G0yU6th6OIe9agOZauWL6A-1; Wed, 09 Jun 2021 11:37:56 -0400 X-MC-Unique: G0yU6th6OIe9agOZauWL6A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9E21800D62; Wed, 9 Jun 2021 15:37:54 +0000 (UTC) Received: from localhost (ovpn-113-134.ams2.redhat.com [10.36.113.134]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1986F60CCC; Wed, 9 Jun 2021 15:37:50 +0000 (UTC) From: Cornelia Huck To: Laurent Vivier , Paolo Bonzini , Thomas Huth , Andrew Jones Subject: Re: [kvm-unit-tests PATCH v2 2/7] lib: unify header guards In-Reply-To: Organization: Red Hat GmbH References: <20210609143712.60933-1-cohuck@redhat.com> <20210609143712.60933-3-cohuck@redhat.com> User-Agent: Notmuch/0.32.1 (https://notmuchmail.org) Date: Wed, 09 Jun 2021 17:37:49 +0200 Message-ID: <877dj3122a.fsf@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Cc: linux-s390@vger.kernel.org, Janosch Frank , kvm@vger.kernel.org, David Hildenbrand , kvm-ppc@vger.kernel.org, Claudio Imbrenda , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Wed, Jun 09 2021, Laurent Vivier wrote: > On 09/06/2021 16:37, Cornelia Huck wrote: >> Standardize header guards to _LIB_HEADER_H_. >> >> Signed-off-by: Cornelia Huck >> --- >> lib/alloc_page.h | 4 ++-- >> lib/libcflat.h | 4 ++-- >> lib/list.h | 4 ++-- >> lib/pci-edu.h | 4 ++-- >> lib/pci-host-generic.h | 4 ++-- >> lib/setjmp.h | 4 ++-- >> lib/string.h | 6 +++--- >> lib/vmalloc.h | 4 ++-- >> 8 files changed, 17 insertions(+), 17 deletions(-) > > What about lib/argv.h and lib/pci.h? argv.h does not have a header guard yet (it probably should?) I forgot to commit my changes to pci.h, I think :( > > And there is also this instance of CONFIG_H in lib/config.h generated > by configure. Yeah, we should tweak the generator for that. _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Date: Wed, 09 Jun 2021 15:37:49 +0000 Subject: Re: [kvm-unit-tests PATCH v2 2/7] lib: unify header guards Message-Id: <877dj3122a.fsf@redhat.com> List-Id: References: <20210609143712.60933-1-cohuck@redhat.com> <20210609143712.60933-3-cohuck@redhat.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Vivier , Paolo Bonzini , Thomas Huth , Andrew Jones Cc: kvm@vger.kernel.org, David Hildenbrand , Janosch Frank , Claudio Imbrenda , kvmarm@lists.cs.columbia.edu, kvm-ppc@vger.kernel.org, linux-s390@vger.kernel.org On Wed, Jun 09 2021, Laurent Vivier wrote: > On 09/06/2021 16:37, Cornelia Huck wrote: >> Standardize header guards to _LIB_HEADER_H_. >> >> Signed-off-by: Cornelia Huck >> --- >> lib/alloc_page.h | 4 ++-- >> lib/libcflat.h | 4 ++-- >> lib/list.h | 4 ++-- >> lib/pci-edu.h | 4 ++-- >> lib/pci-host-generic.h | 4 ++-- >> lib/setjmp.h | 4 ++-- >> lib/string.h | 6 +++--- >> lib/vmalloc.h | 4 ++-- >> 8 files changed, 17 insertions(+), 17 deletions(-) > > What about lib/argv.h and lib/pci.h? argv.h does not have a header guard yet (it probably should?) I forgot to commit my changes to pci.h, I think :( > > And there is also this instance of CONFIG_H in lib/config.h generated > by configure. Yeah, we should tweak the generator for that.