* [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency"
@ 2021-04-26 19:11 Fabrice Fontaine
2021-04-26 19:11 ` [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic Fabrice Fontaine
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2021-04-26 19:11 UTC (permalink / raw)
To: buildroot
This reverts commit 4b4d98e2c5165c3121e670192970fc909cae6d8a as
Boost::date_time is still used by domoticz (in pmain/Scheduler.cpp and
push/BasePush.cpp)
Fixes:
- http://autobuild.buildroot.org/results/493a2e93fe6121f118293a268f986ee51009b7e8
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/domoticz/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in
index f9672056ee..83ae2035b2 100644
--- a/package/domoticz/Config.in
+++ b/package/domoticz/Config.in
@@ -11,6 +11,7 @@ config BR2_PACKAGE_DOMOTICZ
depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-thread
depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
select BR2_PACKAGE_BOOST
+ select BR2_PACKAGE_BOOST_DATE_TIME
select BR2_PACKAGE_BOOST_SYSTEM
select BR2_PACKAGE_BOOST_THREAD
select BR2_PACKAGE_CEREAL
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic
2021-04-26 19:11 [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Fabrice Fontaine
@ 2021-04-26 19:11 ` Fabrice Fontaine
2021-04-26 19:50 ` [Buildroot] [PATCH v2, 2/2] " Yann E. MORIN
2021-04-26 21:07 ` Peter Korsgaard
2021-04-26 19:49 ` [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Yann E. MORIN
2021-04-26 21:07 ` Peter Korsgaard
2 siblings, 2 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2021-04-26 19:11 UTC (permalink / raw)
To: buildroot
domoticz does not use Boost::atomic but cmake is so "smart" that it
(wrongly) assumes that Boost::thread depends on Boost:date_time and
Boost::atomic since boost version 1.54:
set(_Boost_THREAD_DEPENDENCIES chrono date_time atomic)
Extracted from:
- https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindBoost.cmake#L1113
As we can't patch every cmake on the field, just select boost atomic
It should be noted that build failures are only raised since commit
8a46b41b4a5d1c2f5ebefd7fc23fec7e8ba0598c as this commit drop the patch
that was decreasing cmake version but also removing:
target_link_libraries(domoticz Boost::thread Boost::system)
Fixes:
- http://autobuild.buildroot.org/results/4306c0a725ed9a34bd55550df428866db6e4f052
- http://autobuild.buildroot.org/results/2478e7a2ec1c63dcc2b36d29a39004468b230211
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v1 -> v2:
- Fix patch title
package/domoticz/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in
index 83ae2035b2..26e79c18b7 100644
--- a/package/domoticz/Config.in
+++ b/package/domoticz/Config.in
@@ -11,6 +11,7 @@ config BR2_PACKAGE_DOMOTICZ
depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-thread
depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
select BR2_PACKAGE_BOOST
+ select BR2_PACKAGE_BOOST_ATOMIC
select BR2_PACKAGE_BOOST_DATE_TIME
select BR2_PACKAGE_BOOST_SYSTEM
select BR2_PACKAGE_BOOST_THREAD
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency"
2021-04-26 19:11 [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Fabrice Fontaine
2021-04-26 19:11 ` [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic Fabrice Fontaine
@ 2021-04-26 19:49 ` Yann E. MORIN
2021-04-26 21:07 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2021-04-26 19:49 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2021-04-26 21:11 +0200, Fabrice Fontaine spake thusly:
> This reverts commit 4b4d98e2c5165c3121e670192970fc909cae6d8a as
> Boost::date_time is still used by domoticz (in pmain/Scheduler.cpp and
> push/BasePush.cpp)
>
> Fixes:
> - http://autobuild.buildroot.org/results/493a2e93fe6121f118293a268f986ee51009b7e8
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> package/domoticz/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in
> index f9672056ee..83ae2035b2 100644
> --- a/package/domoticz/Config.in
> +++ b/package/domoticz/Config.in
> @@ -11,6 +11,7 @@ config BR2_PACKAGE_DOMOTICZ
> depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-thread
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
> select BR2_PACKAGE_BOOST
> + select BR2_PACKAGE_BOOST_DATE_TIME
> select BR2_PACKAGE_BOOST_SYSTEM
> select BR2_PACKAGE_BOOST_THREAD
> select BR2_PACKAGE_CEREAL
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 2/2] package/domoticz: select boost atomic
2021-04-26 19:11 ` [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic Fabrice Fontaine
@ 2021-04-26 19:50 ` Yann E. MORIN
2021-04-26 21:07 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Yann E. MORIN @ 2021-04-26 19:50 UTC (permalink / raw)
To: buildroot
Fabrice, All,
On 2021-04-26 21:11 +0200, Fabrice Fontaine spake thusly:
> domoticz does not use Boost::atomic but cmake is so "smart" that it
> (wrongly) assumes that Boost::thread depends on Boost:date_time and
> Boost::atomic since boost version 1.54:
>
> set(_Boost_THREAD_DEPENDENCIES chrono date_time atomic)
>
> Extracted from:
> - https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindBoost.cmake#L1113
>
> As we can't patch every cmake on the field, just select boost atomic
>
> It should be noted that build failures are only raised since commit
> 8a46b41b4a5d1c2f5ebefd7fc23fec7e8ba0598c as this commit drop the patch
> that was decreasing cmake version but also removing:
>
> target_link_libraries(domoticz Boost::thread Boost::system)
>
> Fixes:
> - http://autobuild.buildroot.org/results/4306c0a725ed9a34bd55550df428866db6e4f052
> - http://autobuild.buildroot.org/results/2478e7a2ec1c63dcc2b36d29a39004468b230211
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Yann E. MORIN.
> ---
> Changes v1 -> v2:
> - Fix patch title
>
> package/domoticz/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/domoticz/Config.in b/package/domoticz/Config.in
> index 83ae2035b2..26e79c18b7 100644
> --- a/package/domoticz/Config.in
> +++ b/package/domoticz/Config.in
> @@ -11,6 +11,7 @@ config BR2_PACKAGE_DOMOTICZ
> depends on BR2_TOOLCHAIN_SUPPORTS_ALWAYS_LOCKFREE_ATOMIC_INTS # boost-thread
> depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # exception_ptr
> select BR2_PACKAGE_BOOST
> + select BR2_PACKAGE_BOOST_ATOMIC
> select BR2_PACKAGE_BOOST_DATE_TIME
> select BR2_PACKAGE_BOOST_SYSTEM
> select BR2_PACKAGE_BOOST_THREAD
> --
> 2.30.2
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency"
2021-04-26 19:11 [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Fabrice Fontaine
2021-04-26 19:11 ` [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic Fabrice Fontaine
2021-04-26 19:49 ` [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Yann E. MORIN
@ 2021-04-26 21:07 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-04-26 21:07 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> This reverts commit 4b4d98e2c5165c3121e670192970fc909cae6d8a as
> Boost::date_time is still used by domoticz (in pmain/Scheduler.cpp and
> push/BasePush.cpp)
> Fixes:
> - http://autobuild.buildroot.org/results/493a2e93fe6121f118293a268f986ee51009b7e8
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2021.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v2, 2/2] package/domoticz: select boost atomic
2021-04-26 19:11 ` [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic Fabrice Fontaine
2021-04-26 19:50 ` [Buildroot] [PATCH v2, 2/2] " Yann E. MORIN
@ 2021-04-26 21:07 ` Peter Korsgaard
1 sibling, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2021-04-26 21:07 UTC (permalink / raw)
To: buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> domoticz does not use Boost::atomic but cmake is so "smart" that it
> (wrongly) assumes that Boost::thread depends on Boost:date_time and
> Boost::atomic since boost version 1.54:
> set(_Boost_THREAD_DEPENDENCIES chrono date_time atomic)
> Extracted from:
> - https://gitlab.kitware.com/cmake/cmake/-/blob/master/Modules/FindBoost.cmake#L1113
> As we can't patch every cmake on the field, just select boost atomic
> It should be noted that build failures are only raised since commit
> 8a46b41b4a5d1c2f5ebefd7fc23fec7e8ba0598c as this commit drop the patch
> that was decreasing cmake version but also removing:
> target_link_libraries(domoticz Boost::thread Boost::system)
> Fixes:
> - http://autobuild.buildroot.org/results/4306c0a725ed9a34bd55550df428866db6e4f052
> - http://autobuild.buildroot.org/results/2478e7a2ec1c63dcc2b36d29a39004468b230211
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2:
> - Fix patch title
Committed to 2021.02.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-04-26 21:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-26 19:11 [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Fabrice Fontaine
2021-04-26 19:11 ` [Buildroot] [PATCH v2,2/2] package/domoticz: select boost atomic Fabrice Fontaine
2021-04-26 19:50 ` [Buildroot] [PATCH v2, 2/2] " Yann E. MORIN
2021-04-26 21:07 ` Peter Korsgaard
2021-04-26 19:49 ` [Buildroot] [PATCH v2, 1/2] Revert "package/domoticz: drop boost date-time dependency" Yann E. MORIN
2021-04-26 21:07 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.