From: John Ogness <john.ogness@linutronix.de>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, "J. Avila" <elavila@google.com>,
Oliver Sang <oliver.sang@intel.com>
Subject: Re: [PATCH] printk: avoid prb_first_valid_seq() where possible
Date: Wed, 10 Feb 2021 19:06:07 +0106 [thread overview]
Message-ID: <877dnf4xco.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <87ft26oqya.fsf@jogness.linutronix.de>
On 2021-02-08, Sergey Senozhatsky <sergey.senozhatsky@gmail.com> wrote:
>> Can we please also ask the kernel test robot to test this patch?
Oliver Sang from LKP was able to verify that the RCU stall problem is
not seen anymore on their side. See his response below.
Thanks Oliver!
John Ogness
On 2021-02-10, Oliver Sang <oliver.sang@intel.com> wrote:
> On Mon, Feb 08, 2021 at 10:35:27AM +0106, John Ogness wrote:
>> Hello LKP Project,
>>
>> Thank you for your valuable and excellent work!
>>
>> You recently detected a problem:
>>
>> https://lists.01.org/hyperkitty/list/lkp@lists.01.org/thread/STZF3OODVA5KOG447JR2AJJXREWIPRXD/
>>
>> We have posted a patch to fix the issue:
>>
>> https://lkml.kernel.org/r/20210205141728.18117-1-john.ogness@linutronix.de
>
> Hi John Ogness,
>
> by applying the patch upon below commit:
> commit: b031a684bfd01d633c79d281bd0cf11c2f834ada ("printk: remove logbuf_lock writer-protection of ringbuffer")
>
> we didn't reproduce the previous INFO:rcu_tasks_detected_stalls_on_tasks
> issue in 30 runs:
>
> b031a684bfd01d63: ("printk: remove logbuf_lock writer-protection of ringbuffer")
> 7e926a042bfad8b7: ("printk: avoid prb_first_valid_seq() where possible")
>
> b031a684bfd01d63 7e926a042bfad8b7334b4677d3
> ---------------- --------------------------
> fail:runs %reproduction fail:runs
> | | |
> 10:21 -48% :30 dmesg.INFO:rcu_tasks_detected_stalls_on_tasks
> 19:21 -90% :30 last_state.is_incomplete_run
> 1:21 -5% :30 last_state.post_run
>
>
>>
>> Using a local lkp installation I can verify the problem is fixed. But we
>> would like to know if there possibilities to verify fixes using the LKP
>> test robot? Or is there any way to check that the test robot sees the
>> problem is fixed?
>>
>> Thanks.
>>
>> John Ogness
next prev parent reply other threads:[~2021-02-10 18:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 14:17 [PATCH] printk: avoid prb_first_valid_seq() where possible John Ogness
2021-02-08 6:44 ` Sergey Senozhatsky
2021-02-08 9:21 ` John Ogness
2021-02-09 0:15 ` J. Avila
2021-02-10 18:00 ` John Ogness [this message]
2021-02-09 2:17 ` Sergey Senozhatsky
2021-02-09 17:47 ` Petr Mladek
2021-02-10 18:26 ` John Ogness
2021-02-11 11:05 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dnf4xco.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=elavila@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.