From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6D9C433E0 for ; Tue, 12 Jan 2021 13:33:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E425820771 for ; Tue, 12 Jan 2021 13:33:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730433AbhALNdX (ORCPT ); Tue, 12 Jan 2021 08:33:23 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:47608 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727691AbhALNdW (ORCPT ); Tue, 12 Jan 2021 08:33:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610458316; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zKKsToTCsHKK+pVPuk9zw5RNKK0D4uDQCytCR/8mFAA=; b=VHytFgskteiEUCdP6W35LZt72g+ISRLNTrhuOso+hV1G/8IQIBwExqu8xhG6HZtahcslyh oc9KmUbjf7WS+lNkyc5JMsayzeWjLEYR20jhmo8kvS3E94L7M7P5/cquuMT2Ya6Tc0wyNV F3RXlVWvRrHD5S+LSn+I48N22CaZhok= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-za5grBJhMtGTUsXh0knBLw-1; Tue, 12 Jan 2021 08:31:52 -0500 X-MC-Unique: za5grBJhMtGTUsXh0knBLw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A1BE107ACF7; Tue, 12 Jan 2021 13:31:50 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-67.ams2.redhat.com [10.36.114.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55DF35D9D2; Tue, 12 Jan 2021 13:31:47 +0000 (UTC) From: Florian Weimer To: Lukas Wunner Cc: Linus Torvalds , Will Deacon , Peter Zijlstra , Arnd Bergmann , Russell King - ARM Linux admin , linux-toolchains@vger.kernel.org, Mark Rutland , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andreas Dilger , Ext4 Developers List , Linux ARM Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues References: <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> <20210108092655.GA4031@willie-the-truck> <20210112132049.GA26096@wunner.de> Date: Tue, 12 Jan 2021 14:31:45 +0100 In-Reply-To: <20210112132049.GA26096@wunner.de> (Lukas Wunner's message of "Tue, 12 Jan 2021 14:20:49 +0100") Message-ID: <877doii8n2.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Lukas Wunner: > On Fri, Jan 08, 2021 at 12:02:53PM -0800, Linus Torvalds wrote: >> I appreciate Arnd pointing out "--std=gnu11", though. What are the >> actual relevant language improvements? >> >> Variable declarations in for-loops is the only one I can think of. I >> think that would clean up some code (and some macros), but might not >> be compelling on its own. > > Anonymous structs/unions. I used to have a use case for that in > struct efi_dev_path in include/linux/efi.h, but Ard Biesheuvel > refactored it in a gnu89-compatible way for v5.7 with db8952e7094f. Aren't those a GNU extension supported since GCC 3.0? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA568C433DB for ; Tue, 12 Jan 2021 13:33:46 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4BB9622285 for ; Tue, 12 Jan 2021 13:33:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4BB9622285 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To:Date:References: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qJL4Je5nBeaGfroKRpKCmwjf0a5Wky8DduJ+fyPaYqM=; b=mUGgdcmhuD6k0VAD7HQufJ0T7 juuGzfUkxFE4TxM2qKDDkLiZIQUJmFZ5ctwpZ+momihff62Myky7RSNw+7K8UpnOhwPLSyb6BQumO 9LDsZVXWvqvACOUilvUHsd7UVBgIvdAhf4iGocqSdYBreYjMSzg1uT0a5QW+w2EcYLYhi4LyW+w8H xOkyr4ZAc21IQbE+yTU63lXf7bu+aytCx/5PajjFPIqb+eldJ1Rzmi1hg+dD2tldZZVMYPlsBGzCy RlsXxCbegZQa2ETjTWgqgySSXN+C6WDVdhbm6ShpQBVNARcqMKdSZxCUQSS7MOrREli1TrI72gMQG n3mesEdTQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzJmF-0005AW-2Y; Tue, 12 Jan 2021 13:32:03 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzJmA-00058S-M9 for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 13:32:01 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610458317; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zKKsToTCsHKK+pVPuk9zw5RNKK0D4uDQCytCR/8mFAA=; b=G4ZmfqGgYnK+eUCV/27ckUoYS2a+iAcCabmSA7k/5Svtm65huXlzytMVggon+Zg+2Tl/nl p//v6jcRylxlcRLy2xGD0twRcYZbRnWVFmGUm+pfQvDvlQfT9F+0qwsx0V/Us5ZRwLKZVX PcWg6XhltQamJkYxxp7bA0HW0e1J5FM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-236-za5grBJhMtGTUsXh0knBLw-1; Tue, 12 Jan 2021 08:31:52 -0500 X-MC-Unique: za5grBJhMtGTUsXh0knBLw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5A1BE107ACF7; Tue, 12 Jan 2021 13:31:50 +0000 (UTC) Received: from oldenburg2.str.redhat.com (ovpn-114-67.ams2.redhat.com [10.36.114.67]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 55DF35D9D2; Tue, 12 Jan 2021 13:31:47 +0000 (UTC) From: Florian Weimer To: Lukas Wunner Subject: Re: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues References: <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> <20210108092655.GA4031@willie-the-truck> <20210112132049.GA26096@wunner.de> Date: Tue, 12 Jan 2021 14:31:45 +0100 In-Reply-To: <20210112132049.GA26096@wunner.de> (Lukas Wunner's message of "Tue, 12 Jan 2021 14:20:49 +0100") Message-ID: <877doii8n2.fsf@oldenburg2.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_083158_783980_0E09415B X-CRM114-Status: GOOD ( 16.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Theodore Ts'o , Peter Zijlstra , Linus Torvalds , Russell King - ARM Linux admin , "linux-kernel@vger.kernel.org" , Andreas Dilger , linux-toolchains@vger.kernel.org, Ext4 Developers List , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org * Lukas Wunner: > On Fri, Jan 08, 2021 at 12:02:53PM -0800, Linus Torvalds wrote: >> I appreciate Arnd pointing out "--std=gnu11", though. What are the >> actual relevant language improvements? >> >> Variable declarations in for-loops is the only one I can think of. I >> think that would clean up some code (and some macros), but might not >> be compelling on its own. > > Anonymous structs/unions. I used to have a use case for that in > struct efi_dev_path in include/linux/efi.h, but Ard Biesheuvel > refactored it in a gnu89-compatible way for v5.7 with db8952e7094f. Aren't those a GNU extension supported since GCC 3.0? Thanks, Florian -- Red Hat GmbH, https://de.redhat.com/ , Registered seat: Grasbrunn, Commercial register: Amtsgericht Muenchen, HRB 153243, Managing Directors: Charles Cachera, Brian Klemm, Laurie Krebs, Michael O'Neill _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel