From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96C6CC433E7 for ; Sat, 10 Oct 2020 22:59:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 57F4C2075E for ; Sat, 10 Oct 2020 22:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602370751; bh=WLVv8CvFvUSELyadEZBT+16ZDWG3WBn4ipBP0xto/UI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From; b=J5aEQ4YZGVaJ0ZK+FCIC8CRTlM4ufLGbDX095f1fTz6VdOcq8Ty0vPbzroZtTtZIU jOFLNOBMuK534tEwA7Bj8lIPf4vDlz4Ui1ZK32+9rlkIP4Vjq9wHQDe0EICu40jVTD TRyWICBKh2a4zRHSxp5zso6dRBXSr7zgV91NP+Pc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728605AbgJJW7J (ORCPT ); Sat, 10 Oct 2020 18:59:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:57040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732256AbgJJTyJ (ORCPT ); Sat, 10 Oct 2020 15:54:09 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 300442083B; Sat, 10 Oct 2020 09:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602322453; bh=WLVv8CvFvUSELyadEZBT+16ZDWG3WBn4ipBP0xto/UI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C2qzrFwQ4NGh6/r2VdskQK5E6p3UUaAAAJbND3+98N866PwxsItCbqLVe0OZ5vURN Cws/paLlMbQLPhoflox7jxIpofiMkcDX5PL8QNmutaJGWXjfSaP5qix3va/qGANLsi uzlMj5VQvOrZ6ofV32j9e7L7TYoF2pZ0pSjrpGf4= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRBGU-001GJz-Tk; Sat, 10 Oct 2020 10:34:11 +0100 Date: Sat, 10 Oct 2020 10:34:04 +0100 Message-ID: <877drypgqb.wl-maz@kernel.org> From: Marc Zyngier To: Masayoshi Mizuma Cc: Sumit Garg , catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, daniel.thompson@linaro.org, jason@lakedaemon.net, kgdb-bugreport@lists.sourceforge.net, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jason.wessel@windriver.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com Subject: Re: [PATCH v4 1/5] arm64: Add framework to turn IPI as NMI In-Reply-To: <20201010015855.vksetnj4luft5enc@gabell> References: <1599830924-13990-1-git-send-email-sumit.garg@linaro.org> <1599830924-13990-2-git-send-email-sumit.garg@linaro.org> <20201010015855.vksetnj4luft5enc@gabell> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: msys.mizuma@gmail.com, sumit.garg@linaro.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, daniel.thompson@linaro.org, jason@lakedaemon.net, kgdb-bugreport@lists.sourceforge.net, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jason.wessel@windriver.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 10 Oct 2020 02:58:55 +0100, Masayoshi Mizuma wrote: [...] > > +void ipi_nmi_setup(int cpu) > > +{ > > + if (!ipi_desc) > > + return; > > ipi_nmi_setup() may be called twice for CPU0: > > set_smp_ipi_range => set_smp_ipi_nmi => ipi_nmi_setup > => ipi_setup => ipi_nmi_setup > > Actually, I got the following error message via the second ipi_nmi_setup(): > > GICv3: Pseudo-NMIs enabled using relaxed ICC_PMR_EL1 synchronisation > GICv3: Cannot set NMI property of enabled IRQ 8 > genirq: Failed to setup NMI delivery: irq 8 > > Why don't we have a check to prevent that? Like as: > > if (cpumask_test_cpu(cpu, ipi_desc->percpu_enabled)) > return; That's definitely the wrong thing to do. prepare_nmi_setup() shouldn't be called twice, and papering over it isn't acceptable. M. -- Without deviation from the norm, progress is not possible. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53F39C433E7 for ; Sat, 10 Oct 2020 09:35:38 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F092F21655 for ; Sat, 10 Oct 2020 09:35:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NofO58Aw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="C2qzrFwQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F092F21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Subject:To:From: Message-ID:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=pd+TLYEX4mUlXqQLVLI1XhqPnAtVQFBde9ZsAEi8l38=; b=NofO58AwAH7K+ogyBAavaf2ZA OQ1kq5F8gk7yD5YbqEgU3mMXxeOglJBOVfqUJ3BuA1n+Wjjv/bnCfhE/e8UvlJWiZ3ihqq4EORNOM fP/5JjG+WoepUEx98nx5TUsUOBEDMIkizxU2If5ZCc1foumRKJ6TgnNAvcmpIQt5fnknSSNDUc9fl c8c4qZAuIawlt2MFFyxgyGgAHOr5Gjeu89C0abjpbIGGawz0tI5I6E1n45TotKTOAO6+oFobiIhDY pDRImr1CX33SVjK/cZj7SZFvbBQpag8nGCN6JSixBAirwXdImWUiFY6PFR7ALofjkmAX5SKPpKMnX QoDdZko/Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRBGb-0002je-DV; Sat, 10 Oct 2020 09:34:17 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kRBGY-0002j6-JA for linux-arm-kernel@lists.infradead.org; Sat, 10 Oct 2020 09:34:15 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 300442083B; Sat, 10 Oct 2020 09:34:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1602322453; bh=WLVv8CvFvUSELyadEZBT+16ZDWG3WBn4ipBP0xto/UI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=C2qzrFwQ4NGh6/r2VdskQK5E6p3UUaAAAJbND3+98N866PwxsItCbqLVe0OZ5vURN Cws/paLlMbQLPhoflox7jxIpofiMkcDX5PL8QNmutaJGWXjfSaP5qix3va/qGANLsi uzlMj5VQvOrZ6ofV32j9e7L7TYoF2pZ0pSjrpGf4= Received: from 78.163-31-62.static.virginmediabusiness.co.uk ([62.31.163.78] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kRBGU-001GJz-Tk; Sat, 10 Oct 2020 10:34:11 +0100 Date: Sat, 10 Oct 2020 10:34:04 +0100 Message-ID: <877drypgqb.wl-maz@kernel.org> From: Marc Zyngier To: Masayoshi Mizuma Subject: Re: [PATCH v4 1/5] arm64: Add framework to turn IPI as NMI In-Reply-To: <20201010015855.vksetnj4luft5enc@gabell> References: <1599830924-13990-1-git-send-email-sumit.garg@linaro.org> <1599830924-13990-2-git-send-email-sumit.garg@linaro.org> <20201010015855.vksetnj4luft5enc@gabell> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 EasyPG/1.0.0 Emacs/26.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") X-SA-Exim-Connect-IP: 62.31.163.78 X-SA-Exim-Rcpt-To: msys.mizuma@gmail.com, sumit.garg@linaro.org, catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, daniel.thompson@linaro.org, jason@lakedaemon.net, kgdb-bugreport@lists.sourceforge.net, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jason.wessel@windriver.com, tglx@linutronix.de, julien.thierry.kdev@gmail.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201010_053414_704361_20D799B2 X-CRM114-Status: GOOD ( 17.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, Sumit Garg , daniel.thompson@linaro.org, jason@lakedaemon.net, catalin.marinas@arm.com, jason.wessel@windriver.com, dianders@chromium.org, linux-kernel@vger.kernel.org, julien.thierry.kdev@gmail.com, kgdb-bugreport@lists.sourceforge.net, tglx@linutronix.de, will@kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, 10 Oct 2020 02:58:55 +0100, Masayoshi Mizuma wrote: [...] > > +void ipi_nmi_setup(int cpu) > > +{ > > + if (!ipi_desc) > > + return; > > ipi_nmi_setup() may be called twice for CPU0: > > set_smp_ipi_range => set_smp_ipi_nmi => ipi_nmi_setup > => ipi_setup => ipi_nmi_setup > > Actually, I got the following error message via the second ipi_nmi_setup(): > > GICv3: Pseudo-NMIs enabled using relaxed ICC_PMR_EL1 synchronisation > GICv3: Cannot set NMI property of enabled IRQ 8 > genirq: Failed to setup NMI delivery: irq 8 > > Why don't we have a check to prevent that? Like as: > > if (cpumask_test_cpu(cpu, ipi_desc->percpu_enabled)) > return; That's definitely the wrong thing to do. prepare_nmi_setup() shouldn't be called twice, and papering over it isn't acceptable. M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel