From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/meson: fix shabang in deep build trees
Date: Mon, 03 Feb 2020 12:08:31 +0100 [thread overview]
Message-ID: <877e14lyhc.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20200113180322.5618-1-yann.morin.1998@free.fr> (Yann E. MORIN's message of "Mon, 13 Jan 2020 19:03:22 +0100")
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:
> The meson script includes the full path to the python interpreter. In
> deep build trees, this path can be more than 128 characters long, which
> is the limit a shabang might be.
NIT: It is called shebang, not shabang.
NIT2: This has actually been bumped to 256 bytes in linux 5.1:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6eb3c3d0a52dca337e327ae8868ca1f44a712e02
> +# Avoid interpreter shabang longer than 127 chars
127? Off by one? ;) In fact, 128 bytes is the size of the entire buffer
read from the file, so including the leading #! and trailing \0 and the
actual path can AFAIK only be 125 bytes long. I changed it to 128 for
consistency.
Committed with these minor fixes, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2020-02-03 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-13 18:03 [Buildroot] [PATCH] package/meson: fix shabang in deep build trees Yann E. MORIN
2020-01-13 20:58 ` Arnout Vandecappelle
2020-02-03 11:08 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877e14lyhc.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.