From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43641CA9EB9 for ; Wed, 23 Oct 2019 21:09:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1373621929 for ; Wed, 23 Oct 2019 21:09:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LYC3Yyw8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404204AbfJWVJP (ORCPT ); Wed, 23 Oct 2019 17:09:15 -0400 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:42059 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732586AbfJWVJP (ORCPT ); Wed, 23 Oct 2019 17:09:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571864954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p2Bt+TeFORfohjlF3bqI3+Mu+yeYbBVrSueSOmuZILw=; b=LYC3Yyw8uwS259WWLUIauNHEQYWj+ZTaCvzECsD6Y54l+sBbIER67GK4jODVjb/4jS5tga I1oqSFE4MhkHeVCAPY9Txp7hby6NDIHm/uWP0xghzhyI27eUJoW7Zk/O6Y0JRQt9os9D/H oXA/nUi6JJqTw5POnX3GeufpUEFU00U= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-118-1hhKc0CgN66roA3cOsx91w-1; Wed, 23 Oct 2019 17:09:12 -0400 Received: by mail-lf1-f72.google.com with SMTP id k30so1428125lfj.5 for ; Wed, 23 Oct 2019 14:09:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=j8uth/YyCcw2cd/AKaSr6zH2GVsN12xt/bp7qE7X9Ng=; b=B+NRPJ8+DEVY/5UNvi6Dsqrm4ErKu5RLcZI6vwEwF0NPa0YmBZpVZO3ckgZs4SqABZ de/EIVFR2x4a8eUEJeYhwBxNiXL7Ow9MyfYHgotgGBrVo+n2mFgXOBlttfJALOMi0GNd LYATFyjqna/+bJ1WEvqmg6KjDHDoiauLsU6g6kv71IwuuH/xJcEE+/fOQ6aOJKI0Q4LU e279RZhfL6rhKL6NZ9/KqW4Bwg5Lqo1Roxea5NOFJ79wtUr4tChg+ByD6wQhYQUyXEoO CcH57KcfRcAceHI1i5Jg4wzw7Aw3/3GV+3+avViFzr9J7OYvQFdSxwqkoqiuLC7MZucF xrXQ== X-Gm-Message-State: APjAAAVTQNpW8JqXchb9Naz20JNihAsxBAWIM97suIRgAlqLFVqDiAN4 Sj2/cOrOLVydi3khRtsSGWKJQ8w7CnQbVWvkgdy2ilhc8KB5evtO1VNFUsOXyBL6tqriWeEWn/w sdeWZv3tfFi8DhPvfOzhlElPc9V4= X-Received: by 2002:a2e:9e4c:: with SMTP id g12mr24328846ljk.103.1571864950206; Wed, 23 Oct 2019 14:09:10 -0700 (PDT) X-Google-Smtp-Source: APXvYqzYFFtiQHnJ5LqHgsHhFH7IcaoyXeT9h2Tuo3q9/5F1AX2go+DSXHCEgirMEaZeL4pFglNNZQ== X-Received: by 2002:a2e:9e4c:: with SMTP id g12mr24328834ljk.103.1571864950024; Wed, 23 Oct 2019 14:09:10 -0700 (PDT) Received: from alrua-x1.borgediget.toke.dk ([2a00:7660:6da:443::2]) by smtp.gmail.com with ESMTPSA id z1sm9491454ljh.88.2019.10.23.14.09.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 14:09:09 -0700 (PDT) Received: by alrua-x1.borgediget.toke.dk (Postfix, from userid 1000) id 1DE0C1804B1; Wed, 23 Oct 2019 23:09:08 +0200 (CEST) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: Kan Yan Cc: Johannes Berg , linux-wireless@vger.kernel.org, Make-Wifi-fast , ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Rajkumar Manoharan , Kevin Hayes Subject: Re: [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue In-Reply-To: References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> <871rv5ovwr.fsf@toke.dk> <87tv7znact.fsf@toke.dk> <87lftbn60t.fsf@toke.dk> X-Clacks-Overhead: GNU Terry Pratchett Date: Wed, 23 Oct 2019 23:09:08 +0200 Message-ID: <877e4vmaob.fsf@toke.dk> MIME-Version: 1.0 X-MC-Unique: 1hhKc0CgN66roA3cOsx91w-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Kan Yan writes: >> >> Aha! Turns out I was doing the sta lookup completely wrong in >> ieee80211_report_used_skb(); so anything frames that were dropped and >> went through there would not get its airtime subtracted correctly. Will >> send a v6 with a fix :) > > Awesome, thanks! That looks very promising. The symptom I see with > previous patch is the interface's pending airtime count looks fine, but t= he > station's airtime get wrong, either due to airtime is credited to the wro= ng > station or wrong AC. Right, if the interface count is fine that means it's not a missing call to the subtraction. So hopefully it will be fixed with v6 :) -Toke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-1.mimecast.com ([205.139.110.61] helo=us-smtp-delivery-1.mimecast.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNNse-0002Kz-Ba for ath10k@lists.infradead.org; Wed, 23 Oct 2019 21:09:21 +0000 Received: by mail-lf1-f72.google.com with SMTP id v204so2672116lfa.0 for ; Wed, 23 Oct 2019 14:09:11 -0700 (PDT) From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [PATCH v4 4/4] mac80211: Use Airtime-based Queue Limits (AQL) on packet dequeue In-Reply-To: References: <157148503415.2989444.7391437309981941226.stgit@toke.dk> <157148503865.2989444.7118792679603045723.stgit@toke.dk> <871rv5ovwr.fsf@toke.dk> <87tv7znact.fsf@toke.dk> <87lftbn60t.fsf@toke.dk> Date: Wed, 23 Oct 2019 23:09:08 +0200 Message-ID: <877e4vmaob.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Kan Yan Cc: Rajkumar Manoharan , Kevin Hayes , Make-Wifi-fast , linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Johannes Berg , Lorenzo Bianconi , Felix Fietkau Kan Yan writes: >> >> Aha! Turns out I was doing the sta lookup completely wrong in >> ieee80211_report_used_skb(); so anything frames that were dropped and >> went through there would not get its airtime subtracted correctly. Will >> send a v6 with a fix :) > > Awesome, thanks! That looks very promising. The symptom I see with > previous patch is the interface's pending airtime count looks fine, but the > station's airtime get wrong, either due to airtime is credited to the wrong > station or wrong AC. Right, if the interface count is fine that means it's not a missing call to the subtraction. So hopefully it will be fixed with v6 :) -Toke _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k