From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kuninori Morimoto Subject: Re: [PATCH resend 25/47] ASoC: samsung: snow: don't select unnecessary Platform Date: 25 Jun 2019 17:25:45 +0900 Message-ID: <877e9a2hvn.wl-kuninori.morimoto.gx@renesas.com> References: <877e9iwf9f.wl-kuninori.morimoto.gx@renesas.com> <874l4mv0h8.wl-kuninori.morimoto.gx@renesas.com> <9cfc8505-2903-033f-f68b-8ccc1c70132b@samsung.com> <87d0j232wg.wl-kuninori.morimoto.gx@renesas.com> <80c5c575-6f28-c6a6-91b2-d701bb9fbce8@samsung.com> Mime-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <80c5c575-6f28-c6a6-91b2-d701bb9fbce8@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To: Marek Szyprowski Cc: 'Linux Samsung SOC' , Linux-ALSA , Mark Brown , Krzysztof Kozlowski , Sylwester Nawrocki List-Id: linux-samsung-soc@vger.kernel.org Hi Marek > > I have no idea so far, but one capability is that if your system > > used / based dummy platform, and if your CPU driver didn't use/have > > snd_soc_set_runtime_hwparams() / snd_pcm_lib_ioctl, > > it might be happen, but this patch seems not related to it... > > Reverting this patch fixes the issue, so it is definitely related somehow. Ahh... OK now I think I could understand your issue. Your CPU is using devm_snd_dmaengine_pcm_register() with same *dev. In such case, indeed this patch breaks sound card. Can I confirm it ? In local email, I asked printing component name list. Can you please replace it to below ? I think disappear component is "snd_dmaengine_pcm". If so, above my patch is the bug. --------------------------- diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c index 4cd77cd..4b1f8ae 100644 --- a/sound/soc/soc-core.c +++ b/sound/soc/soc-core.c @@ -313,6 +313,7 @@ static int snd_soc_rtdcom_add(struct snd_soc_pcm_runtime *rtd, new_rtdcom->component = component; INIT_LIST_HEAD(&new_rtdcom->list); + printk("-----%s : %s\n", component->name, component->driver->name); list_add_tail(&new_rtdcom->list, &rtd->component_list); return 0; --------------------------- Thank you for your help !! Best regards --- Kuninori Morimoto