From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 08/12] drm/i915: Generalize intel_is_dram_symmetric() Date: Mon, 04 Mar 2019 21:57:30 +0200 Message-ID: <877edee7kl.fsf@intel.com> References: <20190225202907.731-1-ville.syrjala@linux.intel.com> <20190225202907.731-9-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id E872989CD5 for ; Mon, 4 Mar 2019 19:55:22 +0000 (UTC) In-Reply-To: <20190225202907.731-9-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville Syrjala , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyNSBGZWIgMjAxOSwgVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+IHdyb3RlOgo+IEZyb206IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20+Cj4KPiBEZWNvdXBsZSBpbnRlbF9pc19kcmFtX3N5bW1ldHJpYygpIGZy b20gdGhlIHJhdyByZWdpc3RlciB2YWx1ZXMKPiBieSBjb21wYXJpbmcganVzdCB0aGUgZHJhbV9j aGFubmVsX2luZm8gc3RydWN0cy4KClRoZSBpZGVhIGlzIHNvdW5kLgoKPgo+IFNpZ25lZC1vZmYt Ynk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gLS0t Cj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmMgfCAyOCArKysrKysrKysrKystLS0t LS0tLS0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCAxNiBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5j IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IGluZGV4IDNkNmEwOGU5MDdlMy4u OTI2MWJkMGRjY2Q2IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2 LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gQEAgLTExNTUsMTQg KzExNTUsMTIgQEAgc2tsX2RyYW1fZ2V0X2NoYW5uZWxfaW5mbyhzdHJ1Y3QgZHJhbV9jaGFubmVs X2luZm8gKmNoLAo+ICB9Cj4gIAo+ICBzdGF0aWMgYm9vbAo+IC1pbnRlbF9pc19kcmFtX3N5bW1l dHJpYyh1MzIgdmFsX2NoMCwgdTMyIHZhbF9jaDEsCj4gLQkJCXN0cnVjdCBkcmFtX2NoYW5uZWxf aW5mbyAqY2gwKQo+ICtpbnRlbF9pc19kcmFtX3N5bW1ldHJpYyhjb25zdCBzdHJ1Y3QgZHJhbV9j aGFubmVsX2luZm8gKmNoMCwKPiArCQkJY29uc3Qgc3RydWN0IGRyYW1fY2hhbm5lbF9pbmZvICpj aDEpCj4gIHsKPiAtCXJldHVybiAodmFsX2NoMCA9PSB2YWxfY2gxICYmCj4gKwlyZXR1cm4gIW1l bWNtcChjaDAsIGNoMSwgc2l6ZW9mKCpjaDApKSAmJgo+ICAJCShjaDAtPnNfaW5mby5zaXplID09 IDAgfHwKPiAtCQkgKGNoMC0+bF9pbmZvLnNpemUgPT0gY2gwLT5zX2luZm8uc2l6ZSAmJgo+IC0J CSAgY2gwLT5sX2luZm8ud2lkdGggPT0gY2gwLT5zX2luZm8ud2lkdGggJiYKPiAtCQkgIGNoMC0+ bF9pbmZvLnJhbmtzID09IGNoMC0+c19pbmZvLnJhbmtzKSkpOwo+ICsJCSAhbWVtY21wKCZjaDAt PmxfaW5mbywgJmNoMC0+c19pbmZvLCBzaXplb2YoY2gwLT5sX2luZm8pKSk7CgpIb3dldmVyIHVz aW5nIG1lbWNtcCBsaWtlIHRoaXMgZ2l2ZXMgbWUgdGhlIGNyZWVwcy4gSXQncyBwcm9iYWJseSBn b2luZwp0byB3b3JrIGp1c3QgZmluZS4gSXQncyBqdXN0IHRoZSBrbm93bGVkZ2UgdGhhdCBpdCdz IG5vdCBndWFyYW50ZWVkIHRvCndvcmsgdGhhdCBidWdzIG1lLgoKT2ggd2VsbC4KClJldmlld2Vk LWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgoKPiAgfQo+ICAKPiAgc3Rh dGljIGludAo+IEBAIC0xMTcwLDE2ICsxMTY4LDE2IEBAIHNrbF9kcmFtX2dldF9jaGFubmVsc19p bmZvKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiAgewo+ICAJc3RydWN0IGRy YW1faW5mbyAqZHJhbV9pbmZvID0gJmRldl9wcml2LT5kcmFtX2luZm87Cj4gIAlzdHJ1Y3QgZHJh bV9jaGFubmVsX2luZm8gY2gwID0ge30sIGNoMSA9IHt9Owo+IC0JdTMyIHZhbF9jaDAsIHZhbF9j aDE7Cj4gKwl1MzIgdmFsOwo+ICAJaW50IHJldDsKPiAgCj4gLQl2YWxfY2gwID0gSTkxNV9SRUFE KFNLTF9NQURfRElNTV9DSDBfMF8wXzBfTUNIQkFSX01DTUFJTik7Cj4gLQlyZXQgPSBza2xfZHJh bV9nZXRfY2hhbm5lbF9pbmZvKCZjaDAsIDAsIHZhbF9jaDApOwo+ICsJdmFsID0gSTkxNV9SRUFE KFNLTF9NQURfRElNTV9DSDBfMF8wXzBfTUNIQkFSX01DTUFJTik7Cj4gKwlyZXQgPSBza2xfZHJh bV9nZXRfY2hhbm5lbF9pbmZvKCZjaDAsIDAsIHZhbCk7Cj4gIAlpZiAocmV0ID09IDApCj4gIAkJ ZHJhbV9pbmZvLT5udW1fY2hhbm5lbHMrKzsKPiAgCj4gLQl2YWxfY2gxID0gSTkxNV9SRUFEKFNL TF9NQURfRElNTV9DSDFfMF8wXzBfTUNIQkFSX01DTUFJTik7Cj4gLQlyZXQgPSBza2xfZHJhbV9n ZXRfY2hhbm5lbF9pbmZvKCZjaDEsIDEsIHZhbF9jaDEpOwo+ICsJdmFsID0gSTkxNV9SRUFEKFNL TF9NQURfRElNTV9DSDFfMF8wXzBfTUNIQkFSX01DTUFJTik7Cj4gKwlyZXQgPSBza2xfZHJhbV9n ZXRfY2hhbm5lbF9pbmZvKCZjaDEsIDEsIHZhbCk7Cj4gIAlpZiAocmV0ID09IDApCj4gIAkJZHJh bV9pbmZvLT5udW1fY2hhbm5lbHMrKzsKPiAgCj4gQEAgLTEyMDUsMTIgKzEyMDMsMTAgQEAgc2ts X2RyYW1fZ2V0X2NoYW5uZWxzX2luZm8oc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 KQo+ICAKPiAgCWRyYW1faW5mby0+aXNfMTZnYl9kaW1tID0gY2gwLmlzXzE2Z2JfZGltbSB8fCBj aDEuaXNfMTZnYl9kaW1tOwo+ICAKPiAtCWRldl9wcml2LT5kcmFtX2luZm8uc3ltbWV0cmljX21l bW9yeSA9IGludGVsX2lzX2RyYW1fc3ltbWV0cmljKHZhbF9jaDAsCj4gLQkJCQkJCQkJICAgICAg IHZhbF9jaDEsCj4gLQkJCQkJCQkJICAgICAgICZjaDApOwo+ICsJZHJhbV9pbmZvLT5zeW1tZXRy aWNfbWVtb3J5ID0gaW50ZWxfaXNfZHJhbV9zeW1tZXRyaWMoJmNoMCwgJmNoMSk7Cj4gIAo+IC0J RFJNX0RFQlVHX0tNUygibWVtb3J5IGNvbmZpZ3VyYXRpb24gaXMgJXNTeW1tZXRyaWMgbWVtb3J5 XG4iLAo+IC0JCSAgICAgIGRldl9wcml2LT5kcmFtX2luZm8uc3ltbWV0cmljX21lbW9yeSA/ICIi IDogIm5vdCAiKTsKPiArCURSTV9ERUJVR19LTVMoIk1lbW9yeSBjb25maWd1cmF0aW9uIGlzIHN5 bW1ldHJpYz8gJXNcbiIsCj4gKwkJICAgICAgeWVzbm8oZHJhbV9pbmZvLT5zeW1tZXRyaWNfbWVt b3J5KSk7Cj4gIAlyZXR1cm4gMDsKPiAgfQoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNv dXJjZSBHcmFwaGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v aW50ZWwtZ2Z4