From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Felipe Balbi Subject: Re: [PATCH 1/3] usb: dwc3: Add reference clock properties In-Reply-To: References: Date: Tue, 06 Nov 2018 13:26:14 +0200 Message-ID: <877ehqv44p.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" To: Thinh Nguyen , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland Cc: John Youn List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable hi, Thinh Nguyen writes: > Add two new device properties to program the reference clock period and > to enable low power management using the reference clock. This allows a > higher demand to go in low power for Audio Device Class devices. This > feature is currently only valid for DWC_usb31 peripheral controller > v1.80a and higher. > > Set "snps,refclk-period-ns" to program the reference clock period. The > valid input periods are as follow: > +-------------+-----------------+ > | Period (ns) | Freq (MHz) | > +-------------+-----------------+ > | 25 | 39.7/40 | > | 41 | 24.4 | > | 50 | 20 | > | 52 | 19.2 | > | 58 | 17.2 | > | 62 | 16.1 | > +-------------+-----------------+ > > Set "snps,refclk-lpm" to enable low power scheduling of isochronous > transfers by running SOF/ITP counters using the reference clock. Both > "snps,dis_u2_susphy_quirk" and "snps,dis_enblslpm_quirk" must not be > set for this feature to be enabled. > > Signed-off-by: Thinh Nguyen > --- > Documentation/devicetree/bindings/usb/dwc3.txt | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentati= on/devicetree/bindings/usb/dwc3.txt > index 636630fb92d7..712b344c3a31 100644 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ b/Documentation/devicetree/bindings/usb/dwc3.txt > @@ -95,6 +95,24 @@ Optional properties: > this and tx-thr-num-pkt-prd to a valid, non-zero value > 1-16 (DWC_usb31 programming guide section 1.2.3) to > enable periodic ESS TX threshold. > + - snps,refclk-period-ns: set to program the reference clock period. The= valid > + input periods are as follow: > + +-------------+-----------------+ > + | Period (ns) | Freq (MHz) | > + +-------------+-----------------+ > + | 25 | 39.7/40 | > + | 41 | 24.4 | > + | 50 | 20 | > + | 52 | 19.2 | > + | 58 | 17.2 | > + | 62 | 16.1 | > + +-------------+-----------------+ > + - snps,enable-refclk-lpm: set to enable low power scheduling of isochro= nous > + transfers by running SOF/ITP counters using the > + reference clock. Only valid for DWC_usb31 peripheral > + controller v1.80a and higher. Both > + "snps,dis_u2_susphy_quirk" and > + "snps,dis_enblslpm_quirk" must not be set. sounds like you should rely on clk API here. Then on driver call clk_get_rate() to computer whatever you need to compute. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlvhelYACgkQzL64meEa mQY9Ww//TSMHef35QJXBbKfU5kmP5+eljRPtLqbCHT8+XTEpF1nqpXrCaUCFrjZG SLeMSNxDZ+MmUDoNSG962qogZ1K/U8KuFwiG7/ovKHPuNdGjMF66wqg1kzpVXYCR Xyq3e1iXxWzIYHRNADd64w2KRmwCAt2kHLY72sj8OmH+Q6m7MqDKMQ+C60xtf3B5 x+HMi2BT6c0eDTnVWrbZ2M6VeJV0RUGteOJWiIzNJO8SaMxsyBmediQ71s8pyoQB lhBt28+c5ZBgbXeKDSOhLglb86Iw5a2YTDQd7l+fwqckxD4hnSyweMHYRpJUS1zo 5ltSvBphtbGA/VpyZFCgG1VbES3UvAotcjFbjEPlUdIbmUbhJcSkGcqr4SsWEgnz 0yw5OLktf7EPTNiyd5HwfjLan8sfxg2Jonw7D6iKDvHd+IhqKABfULCn6SAk7w80 yPask6ZwSgYHoH7XBmmVhmEJICIaRK7TAiOCA9o+Q1VP+hKmPjX7GRntpvOy7d68 btZqdo2OegVOWGgfgMh2QYTV2PUcvmPhW/8cJPhMBGNvX7zdc9tVkbWoViZYtMoA dQxjMQEYML5OnUspGTDcp7/WJGeIdgM2ps4/IXqpPVQkcK0uiQjlf4uowVLL5E5N lHE+az5vBmHcblvG7Z3IQLN7PQO7C3PnnsYOZPtnHcvrPilAHa4= =oeZF -----END PGP SIGNATURE----- --=-=-=-- From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [1/3] usb: dwc3: Add reference clock properties From: Felipe Balbi Message-Id: <877ehqv44p.fsf@linux.intel.com> Date: Tue, 06 Nov 2018 13:26:14 +0200 To: Thinh Nguyen , linux-usb@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Mark Rutland Cc: John Youn List-ID: aGksCgpUaGluaCBOZ3V5ZW4gPHRoaW5oLm5ndXllbkBzeW5vcHN5cy5jb20+IHdyaXRlczoKPiBB ZGQgdHdvIG5ldyBkZXZpY2UgcHJvcGVydGllcyB0byBwcm9ncmFtIHRoZSByZWZlcmVuY2UgY2xv Y2sgcGVyaW9kIGFuZAo+IHRvIGVuYWJsZSBsb3cgcG93ZXIgbWFuYWdlbWVudCB1c2luZyB0aGUg cmVmZXJlbmNlIGNsb2NrLiBUaGlzIGFsbG93cyBhCj4gaGlnaGVyIGRlbWFuZCB0byBnbyBpbiBs b3cgcG93ZXIgZm9yIEF1ZGlvIERldmljZSBDbGFzcyBkZXZpY2VzLiBUaGlzCj4gZmVhdHVyZSBp cyBjdXJyZW50bHkgb25seSB2YWxpZCBmb3IgRFdDX3VzYjMxIHBlcmlwaGVyYWwgY29udHJvbGxl cgo+IHYxLjgwYSBhbmQgaGlnaGVyLgo+Cj4gU2V0ICJzbnBzLHJlZmNsay1wZXJpb2QtbnMiIHRv IHByb2dyYW0gdGhlIHJlZmVyZW5jZSBjbG9jayBwZXJpb2QuIFRoZQo+IHZhbGlkIGlucHV0IHBl cmlvZHMgYXJlIGFzIGZvbGxvdzoKPiAgKy0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0r Cj4gIHwgUGVyaW9kIChucykgfCBGcmVxIChNSHopICAgICAgfAo+ICArLS0tLS0tLS0tLS0tLSst LS0tLS0tLS0tLS0tLS0tLSsKPiAgfCAyNSAgICAgICAgICB8IDM5LjcvNDAgICAgICAgICB8Cj4g IHwgNDEgICAgICAgICAgfCAyNC40ICAgICAgICAgICAgfAo+ICB8IDUwICAgICAgICAgIHwgMjAg ICAgICAgICAgICAgIHwKPiAgfCA1MiAgICAgICAgICB8IDE5LjIgICAgICAgICAgICB8Cj4gIHwg NTggICAgICAgICAgfCAxNy4yICAgICAgICAgICAgfAo+ICB8IDYyICAgICAgICAgIHwgMTYuMSAg ICAgICAgICAgIHwKPiAgKy0tLS0tLS0tLS0tLS0rLS0tLS0tLS0tLS0tLS0tLS0rCj4KPiBTZXQg InNucHMscmVmY2xrLWxwbSIgdG8gZW5hYmxlIGxvdyBwb3dlciBzY2hlZHVsaW5nIG9mIGlzb2No cm9ub3VzCj4gdHJhbnNmZXJzIGJ5IHJ1bm5pbmcgU09GL0lUUCBjb3VudGVycyB1c2luZyB0aGUg cmVmZXJlbmNlIGNsb2NrLiBCb3RoCj4gInNucHMsZGlzX3UyX3N1c3BoeV9xdWlyayIgYW5kICJz bnBzLGRpc19lbmJsc2xwbV9xdWlyayIgbXVzdCBub3QgYmUKPiBzZXQgZm9yIHRoaXMgZmVhdHVy ZSB0byBiZSBlbmFibGVkLgo+Cj4gU2lnbmVkLW9mZi1ieTogVGhpbmggTmd1eWVuIDx0aGluaG5A c3lub3BzeXMuY29tPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3Mv dXNiL2R3YzMudHh0IHwgMTggKysrKysrKysrKysrKysrKysrCj4gIDEgZmlsZSBjaGFuZ2VkLCAx OCBpbnNlcnRpb25zKCspCj4KPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVl L2JpbmRpbmdzL3VzYi9kd2MzLnR4dCBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy91c2IvZHdjMy50eHQKPiBpbmRleCA2MzY2MzBmYjkyZDcuLjcxMmIzNDRjM2EzMSAxMDA2NDQK PiAtLS0gYS9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvdXNiL2R3YzMudHh0Cj4g KysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3VzYi9kd2MzLnR4dAo+IEBA IC05NSw2ICs5NSwyNCBAQCBPcHRpb25hbCBwcm9wZXJ0aWVzOgo+ICAJCQl0aGlzIGFuZCB0eC10 aHItbnVtLXBrdC1wcmQgdG8gYSB2YWxpZCwgbm9uLXplcm8gdmFsdWUKPiAgCQkJMS0xNiAoRFdD X3VzYjMxIHByb2dyYW1taW5nIGd1aWRlIHNlY3Rpb24gMS4yLjMpIHRvCj4gIAkJCWVuYWJsZSBw ZXJpb2RpYyBFU1MgVFggdGhyZXNob2xkLgo+ICsgLSBzbnBzLHJlZmNsay1wZXJpb2QtbnM6IHNl dCB0byBwcm9ncmFtIHRoZSByZWZlcmVuY2UgY2xvY2sgcGVyaW9kLiBUaGUgdmFsaWQKPiArICAg CQkJaW5wdXQgcGVyaW9kcyBhcmUgYXMgZm9sbG93Ogo+ICsJCQkrLS0tLS0tLS0tLS0tLSstLS0t LS0tLS0tLS0tLS0tLSsKPiArCQkJfCBQZXJpb2QgKG5zKSB8IEZyZXEgKE1IeikgICAgICB8Cj4g KwkJCSstLS0tLS0tLS0tLS0tKy0tLS0tLS0tLS0tLS0tLS0tKwo+ICsJCQl8IDI1ICAgICAgICAg IHwgMzkuNy80MCAgICAgICAgIHwKPiArCQkJfCA0MSAgICAgICAgICB8IDI0LjQgICAgICAgICAg ICB8Cj4gKwkJCXwgNTAgICAgICAgICAgfCAyMCAgICAgICAgICAgICAgfAo+ICsJCQl8IDUyICAg ICAgICAgIHwgMTkuMiAgICAgICAgICAgIHwKPiArCQkJfCA1OCAgICAgICAgICB8IDE3LjIgICAg ICAgICAgICB8Cj4gKwkJCXwgNjIgICAgICAgICAgfCAxNi4xICAgICAgICAgICAgfAo+ICsJCQkr LS0tLS0tLS0tLS0tLSstLS0tLS0tLS0tLS0tLS0tLSsKPiArIC0gc25wcyxlbmFibGUtcmVmY2xr LWxwbTogc2V0IHRvIGVuYWJsZSBsb3cgcG93ZXIgc2NoZWR1bGluZyBvZiBpc29jaHJvbm91cwo+ ICsJCQl0cmFuc2ZlcnMgYnkgcnVubmluZyBTT0YvSVRQIGNvdW50ZXJzIHVzaW5nIHRoZQo+ICsJ CQlyZWZlcmVuY2UgY2xvY2suIE9ubHkgdmFsaWQgZm9yIERXQ191c2IzMSBwZXJpcGhlcmFsCj4g KwkJCWNvbnRyb2xsZXIgdjEuODBhIGFuZCBoaWdoZXIuIEJvdGgKPiArCQkJInNucHMsZGlzX3Uy X3N1c3BoeV9xdWlyayIgYW5kCj4gKwkJCSJzbnBzLGRpc19lbmJsc2xwbV9xdWlyayIgbXVzdCBu b3QgYmUgc2V0LgoKc291bmRzIGxpa2UgeW91IHNob3VsZCByZWx5IG9uIGNsayBBUEkgaGVyZS4g VGhlbiBvbiBkcml2ZXIgY2FsbApjbGtfZ2V0X3JhdGUoKSB0byBjb21wdXRlciB3aGF0ZXZlciB5 b3UgbmVlZCB0byBjb21wdXRlLgo=