From mboxrd@z Thu Jan 1 00:00:00 1970 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= Subject: Re: [Cake] [PATCH iproute2-next v3] Add support for cake qdisc Date: Tue, 24 Apr 2018 17:38:24 +0200 Message-ID: <877eow7gy7.fsf@toke.dk> References: <20180424114407.5939-2-toke@toke.dk> <20180424123046.21247-1-toke@toke.dk> <20180424074552.397564a5@xeon-e3> <87efj47j1y.fsf@toke.dk> <20180424081008.2ad7eaa7@xeon-e3> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: netdev@vger.kernel.org, cake@lists.bufferbloat.net To: Stephen Hemminger Return-path: Received: from mail.toke.dk ([52.28.52.200]:44667 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbeDXPi0 (ORCPT ); Tue, 24 Apr 2018 11:38:26 -0400 In-Reply-To: <20180424081008.2ad7eaa7@xeon-e3> Sender: netdev-owner@vger.kernel.org List-ID: Stephen Hemminger writes: > On Tue, 24 Apr 2018 16:52:57 +0200 > Toke H=C3=B8iland-J=C3=B8rgensen wrote: > >> Well, this is leftover from keeping track of different versions of the >> out-of-tree patch, and we already broke compatibility pretty thoroughly >> as a preparation for upstreaming. So I'm fine with dropping the version >> check; will resend. >>=20 >> That being said, the versioning comes from the XSTATS API, which does >> not use netlink attributes for its members, but rather passes through as >> struct. So what is one supposed to do in this case? > > If a structure is likely to change, then it should be decomposed into nes= ted > netlink attributes. Once you send a structure over userspace API in netli= nk > it is fixed forever. Right. Is decomposing stats into netlink attributes actually possible within the qdisc dump_stats callback? Could we do something like: nla_start_nest(d->skb, TCA_CAKE_STATS); from within cake_dump_stats() and read it in cake_print_xstats in tc? -Toke