From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/2] usb: host: xhci-plat: Fix clock resource by adding a register clock From: Gregory CLEMENT Message-Id: <877eqe1who.fsf@bootlin.com> Date: Wed, 14 Mar 2018 16:56:51 +0100 To: Mathias Nyman , Rob Herring Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, Antoine Tenart , =?utf-8?Q?Miqu=C3=A8l?= Raynal , Nadav Haklai , Shadi Ammouri , Omri Itach , Hanna Hawa , Igal Liberman , Marcin Wojtas List-ID: SGkgUm9iLAoKKHJlc2VudCBiZWNhdXNlIG9mIG1hbGZvcm1lZCBjYyBsaXN0KQogCiBPbiBtZXIu LCBmw6l2ci4gMjggMjAxOCwgTWF0aGlhcyBOeW1hbiA8bWF0aGlhcy5ueW1hbkBpbnRlbC5jb20+ IHdyb3RlOgoKPiBPbiAxNC4wMi4yMDE4IDE4OjE2LCBHcmVnb3J5IENMRU1FTlQgd3JvdGU6Cj4+ IE9uIEFybWFkYSA3Sy84SyB3ZSBuZWVkIHRvIGV4cGxpY2l0bHkgZW5hYmxlIHRoZSByZWdpc3Rl ciBjbG9jay4gVGhpcwo+PiBjbG9jayBpcyBvcHRpb25hbCBiZWNhdXNlIG5vdCBhbGwgdGhlIFNv Q3MgdXNpbmcgdGhpcyBJUCBuZWVkIGl0IGJ1dCBhdAo+PiBsZWFzdCBmb3IgQXJtYWRhIDdLLzhL IGl0IGlzIGFjdHVhbGx5IG1hbmRhdG9yeS4KPj4KPj4gVGhlIGNoYW5nZSB3YXMgZG9uZSBhdCB4 aGNpLXBsYXQgbGV2ZWwgYW5kIG5vdCBhdCBhIHhoY2ktbXZlYnUuYyBiZWNhdXNlLAo+PiBpdCBp cyBleHBlY3RlZCB0aGF0IG90aGVyIFNvQyB3b3VsZCBoYXZlIHRoaXMga2luZCBvZiBjb25zdHJh aW50Lgo+Pgo+PiBUaGUgYmluZGluZyBkb2N1bWVudGF0aW9uIGlzIHVwZGF0aW5nIGFjY29yZGlu Z2x5Lgo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBHcmVnb3J5IENMRU1FTlQgPGdyZWdvcnkuY2xlbWVu dEBib290bGluLmNvbT4KPj4gLS0tCj4+ICAgRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3VzYi91c2IteGhjaS50eHQgfCAgNSArKystCj4+ICAgZHJpdmVycy91c2IvaG9zdC94aGNp LXBsYXQuYyAgICAgICAgICAgICAgICAgICAgICAgfCAzMyArKysrKysrKysrKysrKysrKystLS0t Cj4+ICAgZHJpdmVycy91c2IvaG9zdC94aGNpLmggICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgMyArLQo+PiAgIDMgZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlv bnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5n cy91c2IvdXNiLXhoY2kudHh0IGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3Vz Yi91c2IteGhjaS50eHQKPj4gaW5kZXggZTJlYTU5YmJjYTkzLi5lNGIxNDUxMWY0ZjggMTAwNjQ0 Cj4+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvdXNiLXhoY2ku dHh0Cj4+ICsrKyBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy91c2IvdXNiLXho Y2kudHh0Cj4+IEBAIC0yNyw3ICsyNywxMCBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOgo+PiAgICAg LSBpbnRlcnJ1cHRzOiBvbmUgWEhDSSBpbnRlcnJ1cHQgc2hvdWxkIGJlIGRlc2NyaWJlZCBoZXJl Lgo+PiAgICAgT3B0aW9uYWwgcHJvcGVydGllczoKPj4gLSAgLSBjbG9ja3M6IHJlZmVyZW5jZSB0 byBhIGNsb2NrCj4+ICsgIC0gY2xvY2tzOiByZWZlcmVuY2UgdG8gdGhlIGNsb2Nrcwo+PiArICAt IGNsb2NrLW5hbWVzOiBtYW5kYXRvcnkgaWYgdGhlcmUgaXMgYSBzZWNvbmQgY2xvY2ssIGluIHRo aXMgY2FzZQo+PiArICAgIHRoZSBuYW1lIG11c3QgYmUgImNvcmUiIGZvciB0aGUgZmlyc3QgY2xv Y2sgYW5kICJyZWciIGZvciB0aGUKPj4gKyAgICBzZWNvbmQgb25lCj4+ICAgICAtIHVzYjItbHBt LWRpc2FibGU6IGluZGljYXRlIGlmIHdlIGRvbid0IHdhbnQgdG8gZW5hYmxlIFVTQjIgSFcgTFBN Cj4+ICAgICAtIHVzYjMtbHBtLWNhcGFibGU6IGRldGVybWluZXMgaWYgcGxhdGZvcm0gaXMgVVNC MyBMUE0gY2FwYWJsZQo+PiAgICAgLSBxdWlyay1icm9rZW4tcG9ydC1wZWQ6IHNldCBpZiB0aGUg Y29udHJvbGxlciBoYXMgYnJva2VuIHBvcnQgZGlzYWJsZSBtZWNoYW5pc20KPgo+IFdvdWxkIGJl IGdvb2QgdG8gZ2V0IGEgQWNrIG9yIHJldmlldyBieSBSb2IgSGVycmluZyBmb3IgdGhlIGFib3Zl CgpXb3VsZCB5b3UgbWluZCB0byBoYXZlIGEgbG9vayBvbiB0aGlzIGJpbmRpbmcgdXBkYXRlID8K CkluaXRpYWxseSBJIGRpZG4ndCBjb3B5IHlvdSB0cnlpbmcgdG8gbm90IG92ZXJmbG93IHlvdSBi ZWNhdXNlIHRoaXMKY2hhbmdlIGlzIG9ubHkgYWJvdXQgYWRkaW5nIGEgbmV3IGNsb2NrLCB3aGlj aCBpcyBwcmV0dHkgY29tbW9uLiBCdXQgSQp0aGluayBNYXRoaWFzIHdvdWxkIGJlIG1vcmUgY29u ZmlkZW50IHdpdGggYSBBY2sgb3IgcmV2aWV3IGJ5IHlvdS4KClRoYW5rcywKCkdyZWdvcnkK From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@bootlin.com (Gregory CLEMENT) Date: Wed, 14 Mar 2018 16:56:51 +0100 Subject: [PATCH 2/2] usb: host: xhci-plat: Fix clock resource by adding a register clock In-Reply-To: <0643f36a-cee7-8e4a-77c3-c60672ca385f@intel.com> (Mathias Nyman's message of "Wed, 28 Feb 2018 18:05:20 +0200") References: <20180214161620.4401-1-gregory.clement@bootlin.com> <20180214161620.4401-3-gregory.clement@bootlin.com> <0643f36a-cee7-8e4a-77c3-c60672ca385f@intel.com> Message-ID: <877eqe1who.fsf@bootlin.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Rob, (resent because of malformed cc list) On mer., f?vr. 28 2018, Mathias Nyman wrote: > On 14.02.2018 18:16, Gregory CLEMENT wrote: >> On Armada 7K/8K we need to explicitly enable the register clock. This >> clock is optional because not all the SoCs using this IP need it but at >> least for Armada 7K/8K it is actually mandatory. >> >> The change was done at xhci-plat level and not at a xhci-mvebu.c because, >> it is expected that other SoC would have this kind of constraint. >> >> The binding documentation is updating accordingly. >> >> Signed-off-by: Gregory CLEMENT >> --- >> Documentation/devicetree/bindings/usb/usb-xhci.txt | 5 +++- >> drivers/usb/host/xhci-plat.c | 33 ++++++++++++++++++---- >> drivers/usb/host/xhci.h | 3 +- >> 3 files changed, 33 insertions(+), 8 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/usb/usb-xhci.txt b/Documentation/devicetree/bindings/usb/usb-xhci.txt >> index e2ea59bbca93..e4b14511f4f8 100644 >> --- a/Documentation/devicetree/bindings/usb/usb-xhci.txt >> +++ b/Documentation/devicetree/bindings/usb/usb-xhci.txt >> @@ -27,7 +27,10 @@ Required properties: >> - interrupts: one XHCI interrupt should be described here. >> Optional properties: >> - - clocks: reference to a clock >> + - clocks: reference to the clocks >> + - clock-names: mandatory if there is a second clock, in this case >> + the name must be "core" for the first clock and "reg" for the >> + second one >> - usb2-lpm-disable: indicate if we don't want to enable USB2 HW LPM >> - usb3-lpm-capable: determines if platform is USB3 LPM capable >> - quirk-broken-port-ped: set if the controller has broken port disable mechanism > > Would be good to get a Ack or review by Rob Herring for the above Would you mind to have a look on this binding update ? Initially I didn't copy you trying to not overflow you because this change is only about adding a new clock, which is pretty common. But I think Mathias would be more confident with a Ack or review by you. Thanks, Gregory -- Gregory Clement, Bootlin (formerly Free Electrons) Embedded Linux and Kernel engineering http://bootlin.com