From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 11/12] drm: vc4: Use drm_atomic_helper_shutdown() to disable planes on removal Date: Wed, 17 Jan 2018 21:44:26 -0800 Message-ID: <877esf3emd.fsf@anholt.net> References: <20180117215535.16517-1-laurent.pinchart+renesas@ideasonboard.com> <20180117215535.16517-12-laurent.pinchart+renesas@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1053583444==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 57FA06E3A1 for ; Thu, 18 Jan 2018 05:44:30 +0000 (UTC) In-Reply-To: <20180117215535.16517-12-laurent.pinchart+renesas@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1053583444== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Laurent Pinchart writes: > The plane cleanup handler currently calls drm_plane_helper_disable(), > which is a legacy helper function. Replace it with a call to > drm_atomic_helper_shutdown() at removal time. The plane .destroy() > handler now consisting only of a call to drm_plane_cleanup(), replace it > with direct calls to that function. > > Signed-off-by: Laurent Pinchart Looks like debug changes to Kconfigs slipped in. Other than that, the actual change sounds good. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlpgNDoACgkQtdYpNtH8 nuiuDw/9HzonNd7kJIW6aL5zhMdLsK+2O5g01ZAR8Xrkz/WQhsSunU/lHT+UwB54 ZdyfpnR8YN9IrcYv35bR08vCdMpuzcrpFgEaI3bKdSST+k7lGkalB9HOOot/oX8B xpRwbmGZP/3aqnUC4ylJzeykkFKQwyaXo94PoiILhElTVmgTKqLUozypEPwQTq4F cwjT5qDDSvvfwJLU4LWd8sPRbQ6bDQNeEt2T2bd4UENggdZ2+tJRW+Yjv2thI+AS woOP+YmFZ+q+iBovrq2U9vj2R1el0Y0/kbupzRFrWTUTIVPVcV1NsryNUgK/EPMk UMQ89l48KaCNjnpGjGUgvksSRbC+RPNQ0VT5kf8d/u9NggxtZ6x3dd/nABXFc5w3 px47aoyvLwlW1T8hZOqENW7/BK1tLKiK/kLv66dpuIOoDoBPQioNQWk2JqELjGE6 vWgJpBOs0LHShcCUlqBz3whM47nYDonvP+lsuxq4j0ajTg0KjHYxEwENVWrgOo6D aFZTrtRC6CuJ8hS3brHLqbbfeflUS7zivm5Fo5R+b9Qhh1yNmpf2rR3iOZJEJfn+ 8/zUl5a5YPLqTZ3rV5N5KF9b6b7HF8bEDJ/80njBLPWKEudLYZfYXQLBcoT+SPkC SKP3p9zTDS3NY/q5P3C3Ovp9mjeXb93zSho2VkKdruP4sMDihp4= =YCIG -----END PGP SIGNATURE----- --=-=-=-- --===============1053583444== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1053583444==--