From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755487AbcI2MYN (ORCPT ); Thu, 29 Sep 2016 08:24:13 -0400 Received: from mga04.intel.com ([192.55.52.120]:39734 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753722AbcI2MYF (ORCPT ); Thu, 29 Sep 2016 08:24:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,414,1470726000"; d="asc'?scan'208";a="14596082" From: Felipe Balbi To: Greg KH , Manish Narani Cc: k.opasiak@samsung.com, r.baldyga@samsung.com, peter.chen@freescale.com, mnarani@xilinx.com, John.Youn@synopsys.com, eu@felipetonello.com, i.kotrasinsk@samsung.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, anuragku@xilinx.com, punnaia@xilinx.com Subject: Re: [LINUX PATCH] usb: gadget: Configure bulk maxburst through module parameter in gadget zero. In-Reply-To: <20160929085405.GA8895@kroah.com> References: <1475138804-3335-1-git-send-email-mnarani@xilinx.com> <20160929085405.GA8895@kroah.com> Date: Thu, 29 Sep 2016 15:23:39 +0300 Message-ID: <877f9usxmc.fsf@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Greg KH writes: > On Thu, Sep 29, 2016 at 02:16:44PM +0530, Manish Narani wrote: >> This patch adds support to configure bulk maxburst through >> module parameter. This parameter can be used to modify bulk >> maxburst in case if one wants to measure peak Bulk/Isoc-IN/OUT >> performance. > > Eeek, this isn't the 1990's, please don't add new module parameters :) > > We have much better ways of handling configuration options for a device, > why not use them (configfs, sysfs files, etc.)? > > Ugh, it looks like iso_maxburst is handled this way as well. > > Felipe, why is this? Yeah, g_zero has a few module parameters. In fact many of the gadget drivers have them. This is all legacy stuff, pre-configfs. We can't simply remove the legacy gadget drivers and tell everybody to start using configfs ;-) That's what we want, no doubt. That being said, we're not taking any new module parameters to any of the gadget drivers OR UDC drivers. Anything new is configfs-only. Legacy gadgets only get bug fixes. =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJX7QfLAAoJEMy+uJnhGpkG3lYQAN4+NZPkZJKeR/9V6q13SYnS WnXzOSgujLbS7LiDS8EPLx79O6u6+kYizHOqY5OXLXXiuCUv0O2RAhzCFzAVnH53 sa0BYslhLSZoCEXeQ/BEo2WBqr0YXLoWnVdZKQCMjAqK4w3sNyZOFdmCPtFG9lM0 1dwYAP7ux14mLc4c//+s/Ta2i8ENh6gcrFZhyzizzaJcNyieTpqhGRBl5ikG4T6l qpVDSS5WsgWEpdj4U/4kbZ9W877RDGfv68IAtglvm3Evy/j6XAVBcrVPUBJOQuHp hVOmf2Zi0rUDrZI+fpB6bCaEyFwiXKp1ZAXTfZa4xTqlypf6ODWWpwxIAG58vP0r E0/KfRdScFs3HuoyHRfN3Qjq/I+sf/f9ElNvEURnMS/9jf2YJIUIiic0z7XtfIpP zYI985I4mS0WlL6fEAW+xb6ifNMO6hPyrmq3eMjMy4BPqDnPqSZ+EHp2zpLEKo9E SIhxRDODLo+i9N0GP5O38EDgeNA1UmMC4VhDOZ98d1SGlgxDsc5jq9VQI0V9PnPq 1BeMQqauZfAfliBE694eZ5YJOSFUi8NQfznP/tHu/8g8Up7Kb6JOvRl6PTXycrVV b5m5mdtXb175wCBDk3qyLQ/QnBeBsx+SADu77/I38p3Qonln4kZqUCTWdotpT6On 1ln037v1lEMa1MvnSmeA =G0AY -----END PGP SIGNATURE----- --=-=-=--