From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjsZM-0000It-6L for qemu-devel@nongnu.org; Tue, 13 Sep 2016 14:36:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjsZI-00035v-Fq for qemu-devel@nongnu.org; Tue, 13 Sep 2016 14:36:31 -0400 Received: from roura.ac.upc.es ([147.83.33.10]:50643) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjsZI-00034Y-4A for qemu-devel@nongnu.org; Tue, 13 Sep 2016 14:36:28 -0400 From: =?utf-8?Q?Llu=C3=ADs_Vilanova?= References: <1470756748-18933-1-git-send-email-berrange@redhat.com> <87vay6ed9t.fsf@fimbulvetr.bsc.es> <20160913170804.GD30949@redhat.com> Date: Tue, 13 Sep 2016 20:36:25 +0200 In-Reply-To: <20160913170804.GD30949@redhat.com> (Daniel P. Berrange's message of "Tue, 13 Sep 2016 18:08:04 +0100") Message-ID: <877faffxzq.fsf@fimbulvetr.bsc.es> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH for-2.8 v1 00/60] Modular build of trace event files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Stefan Hajnoczi Daniel P Berrange writes: > On Thu, Sep 08, 2016 at 03:23:26PM +0200, Llu=C3=ADs Vilanova wrote: >> Daniel P Berrange writes: >>=20 >> > I previously split the global trace-events file up into one file >> > per-subdirectory to avoid merge conflict hell. >> [...] >>=20 >> Sorry, I could not find the message where the infrastructure is modified= to >> provide this. But I think there's a more efficient way to provide modular >> auto-generated tracing code without the hierarchical indexing you propos= ed. > NB, the simpletrace backend requires a globally unique 32-bit integer ID > to be assigned to each trace event, so even with the approach you suggest > below we still need to be able to assign a global ID for each event. > So while your suggest below avoids having to pass around the dstate > arrays, which is nice, we still have to assign event id offsets to > each trace-event file in some manner TBD. Corect me if I'm wrong, but if we only require these consecutive IDs for simpletrace, they don't need to be visible to the tracing headers (these ID= s are only used in "trace/generated-tracers.c"). Therefore, we can get them from = the trace-events-all file, and minimize the complexity of the changes to tracet= ool. Cheers, Lluis