From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33533)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bX6Nn-0003Il-5D
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:43:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bX6Nj-0007WU-Tp
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:43:47 -0400
Received: from mx1.redhat.com ([209.132.183.28]:59086)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bX6Nj-0007WP-Ol
	for qemu-devel@nongnu.org; Tue, 09 Aug 2016 08:43:43 -0400
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 57E7C3DE41
	for <qemu-devel@nongnu.org>; Tue,  9 Aug 2016 12:43:43 +0000 (UTC)
From: Markus Armbruster <armbru@redhat.com>
References: <20160808141439.16908-1-marcandre.lureau@redhat.com>
	<20160808141439.16908-13-marcandre.lureau@redhat.com>
Date: Tue, 09 Aug 2016 14:43:41 +0200
In-Reply-To: <20160808141439.16908-13-marcandre.lureau@redhat.com> (marcandre
	lureau's message of "Mon, 8 Aug 2016 18:14:36 +0400")
Message-ID: <877fbqglj6.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v3 12/15] monitor: use qmp_dispatch()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, Eric Blake <eblake@redhat.com>

marcandre.lureau@redhat.com writes:

> From: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>
>
> Replace the old manual dispatch and validation code by the generic one
> provided by qapi common code.
>
> Note that it is now possible to call the following commands that used to
> be disabled by compile-time conditionals:
> - dump-skeys
> - query-spice
> - rtc-reset-reinjection
> - query-gic-capabilities
>
> Their fallback functions return an appropriate "feature disabled" error.
>
> Signed-off-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

Means query-qmp-schema no longer shows whether these commands are
supported, doesn't it?

Eric, could this create difficulties for libvirt or other introspection
users?