From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:56264)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bDa27-0006Ra-89
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:20:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bDa21-0002Da-K9
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:20:42 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44682)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <armbru@redhat.com>) id 1bDa21-0002DJ-8D
	for qemu-devel@nongnu.org; Thu, 16 Jun 2016 12:20:37 -0400
From: Markus Armbruster <armbru@redhat.com>
References: <1465526889-8339-1-git-send-email-eblake@redhat.com>
	<1465526889-8339-3-git-send-email-eblake@redhat.com>
Date: Thu, 16 Jun 2016 18:20:32 +0200
In-Reply-To: <1465526889-8339-3-git-send-email-eblake@redhat.com> (Eric
	Blake's message of "Thu, 9 Jun 2016 20:48:07 -0600")
Message-ID: <877fdpw1f3.fsf@dusky.pond.sub.org>
MIME-Version: 1.0
Content-Type: text/plain
Subject: Re: [Qemu-devel] [PATCH 2/4] checkpatch: There is no qemu_strtod()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>

Eric Blake <eblake@redhat.com> writes:

> Maybe there should be; but until there is, we should not flag
> strtod() calls as something to replaced with qemu_strtod().
>
> We also lack qemu_strtof() and qemu_strtold(), but as no one
> has been using strtof() or strtold(), it's not worth complicating
> the regex for them.
>
> (Ironically, I had to use 'git commit -n' since checkpatch uses
> TAB indents, in violation of its own recommendations.)
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index c939a32..cf32c8f 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -2453,7 +2453,7 @@ sub process {
>  		}
>
>  # recommend qemu_strto* over strto* for numeric conversions
> -		if ($line =~ /\b(strto[^k].*?)\s*\(/) {
> +		if ($line =~ /\b(strto[^kd].*?)\s*\(/) {
>  			WARN("consider using qemu_$1 in preference to $1\n" . $herecurr);
>  		}
>  # check for module_init(), use category-specific init macros explicitly please

Reviewed-by: Markus Armbruster <armbru@redhat.com>

Paolo, if you want me to smuggle this into master via qapi-next, let me
know.