From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751672AbcFNHDx (ORCPT ); Tue, 14 Jun 2016 03:03:53 -0400 Received: from relmlor1.renesas.com ([210.160.252.171]:34976 "EHLO relmlie4.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751304AbcFNHDu (ORCPT ); Tue, 14 Jun 2016 03:03:50 -0400 X-IronPort-AV: E=Sophos;i="5.22,559,1449500400"; d="scan'";a="212927818" Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=kuninori.morimoto.gx@renesas.com; Message-ID: <877fdscl6o.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Zhang Rui CC: "edubezval@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "yoshihiro.shimoda.uh@renesas.com" , "cm-hiep@jinso.co.jp" Subject: Re: lm-senser can't detect thermal on thermal_zone In-Reply-To: <1465885934.4001.4.camel@intel.com> References: <87posrn1oj.wl%kuninori.morimoto.gx@renesas.com> <1463100287.15071.8.camel@rzhang1-mobl4> <874ma2lnvw.wl%kuninori.morimoto.gx@renesas.com> <87zir89iai.wl%kuninori.morimoto.gx@renesas.com> <87oa7bkqvl.wl%kuninori.morimoto.gx@renesas.com> <1465885934.4001.4.camel@intel.com> User-Agent: Wanderlust/2.15.9 Emacs/24.3 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Tue, 14 Jun 2016 07:03:45 +0000 X-Originating-IP: [211.11.155.144] X-ClientProxiedBy: TYXPR0101CA0007.jpnprd01.prod.outlook.com (10.168.40.145) To PS1PR06MB1706.apcprd06.prod.outlook.com (10.167.53.16) X-MS-Office365-Filtering-Correlation-Id: 897bcb04-f132-4067-e85f-08d3942206fe X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1706;2:86jQbfknxlrlF5/0gTaUrHZvTVIkVcAt9DjH/cMACTFRPsCTnLhtFws5tT2fSxirqAYuZCDNyz+vL0pGn62ixDaNVzSFLOmVhe6olVlK2ztoeyeo5LkcpEE6ne/GnOztieLUZ5AUs/D7Dedt2sPmaHcPnq6qpBjVJNuvpTw7Hw7Csf97uPCeyrgfd9UPBzui;3:3x/DPchnda3FBFzU8G6DMOpXxW2QWdEdMAzNX8F2zVNW1IoVaGpQ37E3KAIMDCCCfPqBVe2tItdezr5xnCM10xwfQ+6gnvAaFZu+iCecSzc9Y5Qe1kzKSqJkQGR9N2Rc;25:ayJhnsmvWCtfUCXdjAxarlsn6q9NVTirU85ZvMBChSQe0OufBXZAY8yjGpxBb69KQBx0IVud3kNHd+92fQk8Znm8lf6PeSUm9dJADWXypwoQ8iVxkHwRxird9YQtqT5Sy1eBjEw0irCUZaet4cDps1p8WEj16z5hjwoSRtZpAt2zxjPpftsZMCv0osuKr2/EL0muOR6mpZxoPRIEeMydAW71/onJVsCh339SZTc8Wud9r6W5ScA5vvtFlZegEAJBKRzSQ/9uVBDbiUMI00OfxsUZ8JtJs/+sF0loIWRBt1R7ln5syE6vgcDaN7PL8fj/ORbTm6iY1NL7TbjBJP077P3ZoF4XRjGCD8I6spEDGeDMklbGiD+QyOTpibPIuwPnbw3TXtVRBjHoLGrpgHLiFYqDhdthgVuhAUCU+uMw1n8= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1706; X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1706;20:qYFHbiMbqFd6nmX0fbhK2P50M0tOkfAExYwU6QVvMEvm+Glc9QQjcHVZ71+c0sjTUzcRBsjeLgvsQikum6LKXEKP4muEhX5oCEqrDKjb6t0tB83BdxP6F8DSetXv3YoxqCp+N6ulvjbdRYDwG+zQq5REU+jhGE9lasjrzdRc2eewrY15BY2YceXefFdCAy+U9nnjiq13DyacpOAoqdbfqFn5FIbeGP5MsIhls0H2fNgjc3VG53Rlr0FaNQA1MEm6MLXYzuIzHDgJ5ScJE21i7kKu0W8mDzTyOGSm3aOl77bz2xOi6Rw26noNe+bN6DUP0T7fsRDsZNPOafLPbjWDuZcqEMwls4z61kI6FCsb5h5VtCKWjooHur5IPj1Ok1tFZs1R85D5XqFoJhDt/XLC3lvpUSeDQ1I3xJm9KOSKN/UnPq9622K027MQYpbyolmGcyV2d2AHwvlpGpXWuFQoso+f67ob3s+RcETlBt5pLelHiGD0ih/xt8Gv6kU425ly;4:4gVbKTAnVz5VktFbuI0/coEOOWGT1l1/+/s2X6EwEjRzgCu6d/6HYW/yEtu1pEMvzYuebfM8k1B++Tll+VJcL52iCzl6C/B+yOygpqhQkJrtgS543lOzXL5RElgqhEWIr2fzN6no8y56Md8hHCfBZRnEwzXejxmRmloMpPtmM2Q501FgwElxlUOyB5co6E6NNtIYojJmf4Jm0tbs1UsvXrW3clonPjk2jK3BGZHiWanha0GgNKgx0APl/+vB7BT7ScQtmgXUbdLakjhi7BgnZ/yNfA4kQo+7a/QgEPiE0mETrHlf2qXT32iqRFdr1Ee/KanY41Txfqxz4lY0n/JJJn5qhb3+BvcG9B5SbXpfTJWmxE0msK17s4sDqCUQa6R6wp8KF5umOwdmGA1LKCrzkg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026);SRVR:PS1PR06MB1706;BCL:0;PCL:0;RULEID:;SRVR:PS1PR06MB1706; X-Forefront-PRVS: 09730BD177 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(199003)(189002)(81156014)(68736007)(101416001)(33646002)(23726003)(586003)(81166006)(3846002)(6116002)(106356001)(105586002)(76176999)(97736004)(54356999)(2906002)(5004730100002)(50986999)(189998001)(345774005)(92566002)(4326007)(110136002)(77096005)(36756003)(4001350100001)(86362001)(8676002)(93886004)(46406003)(47776003)(66066001)(5008740100001)(2950100001)(50466002)(69596002)(83506001)(42186005)(53416004)(16060500001);DIR:OUT;SFP:1102;SCL:1;SRVR:PS1PR06MB1706;H:morimoto-PC.renesas.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;CAT:NONE;LANG:en;CAT:NONE; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;PS1PR06MB1706;23:UUrs3zVDgytoIevDDk6B487rAgI9vjWhEF9xGFRMO?= =?us-ascii?Q?WTi0BIVmjwtsiFYPRZ0kX3hXI9PREj2DOECq/G3vesEFXXEHK9SaBLOOERQg?= =?us-ascii?Q?YhhPsPpvoVjtxP0s9YjX3Ol7Xqk+gmb2q8J5OEYNhoq5nZVxd60XZD/m8eEP?= =?us-ascii?Q?qHdt2BxKRn/bv4++itpT4vYICnm5F/PC0YQ6Ot8HKGVurx5uY80knhNINwZ4?= =?us-ascii?Q?KKDPQLjPJvweEnqnzrYj5lRMrrL4GCcj4C/0sjQz+LkI87+1KwXe6wVJLlfs?= =?us-ascii?Q?SD447stsIIfm3N9348z/H2tMNxukq1CTnd1iuzmMW5KB4FAppxL4FTwdSyXP?= =?us-ascii?Q?ntAa9tk2a17MH6d/PIe4vfcg8w3hSgoEFLKTDZ4dtN5+ujzkHJ2UFzSiMdYK?= =?us-ascii?Q?+GJ5EUlkVBV1/g/SuLO2sLNcfcaldEWTc/ZGSkdzUvVDphLIdjyF2ZKGMpYj?= =?us-ascii?Q?cF2XGAO46TdVhdo8M5qyUcd26vRXMvhv25ILgzLvhtPypB9uGvQlx2pKnS1o?= =?us-ascii?Q?SQE9FrnlFJtcdRLXmiLd43sIVs5RN1LnwiOlaAWGRVJTxPjfQ+9fqYHO4Rzj?= =?us-ascii?Q?a8fCFV5ZXPTrLNclk1K8AFI2+tEqDwVgv4TjQUZEDmiV2fxG9uv+00aQAxtK?= =?us-ascii?Q?DesTv0vQIC7N0zVMzmoDIp2FgLggIBQk6FKZbVc8oXFF6LsMGEyMgODWIiDY?= =?us-ascii?Q?nlJq3U0SIHCs+h5VkemmDA1ZafCIA1aEddJmvOwscNxirm5jxoxccoN9I1pE?= =?us-ascii?Q?wAkB5QNc3DaUaXhD754Y76fO5NDPQPlXLGSg7XvaQyrlziyHbZWMobEWDyoz?= =?us-ascii?Q?1Y+QlLetVvDXl17OLMPuxJTlVTu/D3zEOTf/h3l6wEYGLyqu7z5pAC3b3nrT?= =?us-ascii?Q?1J5ilemcQnon1COMPRw/8qtoMzZ6jRfszR61ekjKnt/IibhBujG2Xtao1rGk?= =?us-ascii?Q?Mslj9GizbpQz0fEoWUYydNEqc2inh0D82So/SrIdafd3RTKqKv7oufuaYwlq?= =?us-ascii?Q?ol874yeMOydGEKATFqLBtcIi2j71cUfatekAfCKFC/sga/b3N7whMz2Kk5nS?= =?us-ascii?Q?jcXuGvo5QVQVLZ86EpWEnjqQ/hWrVv5JdnOL5AyHBEOnWpVeSDV6gYvNi00j?= =?us-ascii?Q?kADqJQd07pCh9QVWVuTvlY4x6hi+7Nn?= X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1706;6:s1dOdLyyYxWKuF/g6QVaXRQmR6BPhtqdvxHGAxhHxsyaCAYYhZlMCn0mG649CXzdbMoGvDkcLGpM/yPRd5U29it5R1zjnfGkutAxqS0P9ShiyoF6j2H5GYjmhmXkp96wOy+HxMGC4Y5FVEpRqCFxOfF92xSx8pcZmpMKN6AlnrAlrezhIUGTgHZyd5//hUAbVuSQSDXVXZgB3Hmlj4xSI4sRx2qCdeegu4oWhSrFX5kqGEWqaYUCReiqKnkgCiAfzymiXwVYpfolEcgoKXzISgXthPMTL2ke7P7bNsMnBnVC4tCbIOGZPvh8GOvKLdk8;5:vcyfKjdbuExHbrNd56qmOw7yIf6YQmzMRsX6BJxGZyMiu8z72Ya1K1i8HafTaTwU4mnuM3aqE5YHgw/mcsegZicm87/OLqVt2Ke6cGsEAuQgaYjmU1z1+VQoKbn5mlsUUO34jv8vWvYDOC53eEZmzw==;24:GjFpsHrpU/8s/G0QDBPJoHbfjHdr56JUtmknleJEikiBe8xp5EWwVDEuCzjv75zwA1BeebRz4TwQAnA11c5cUGiTfxhc7JKHmsUwNQfu3xU=;7:62RGIecChgM6IJ9ID/DQKLJwC8RsdU0wekP6LFcY+mpygPupP+4aHDXCD6jbQYl1V3zdEM31JRpHBRWtWcINees/bnG3rvZtdcrld0TY1TMRuKW44Ut+GZ5wTOZxUOgYZyoLRTeawe+X04ewY4y2OLVlkay5dkjk741rUsN7r5myoZy8V137w7ErJglp90TLLM5/pM2WXuDsFtxkKlRGvw== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;PS1PR06MB1706;20:9usDLRk7Rvov5wSvnB4AjiF/wH0iAGh5zSp7eCYEi+57S7MYwJrRaDmozEn/MgmNv/sIKy6Da2Df5me0e8iunEBYJoaL3b5IBbD7POOmVcveEjxzBUSTbuOXJh/bAlAaYfi4fV6iQ2ZTFSonLW5+sBgnx7VIuXu1xGun7SuegvQ= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jun 2016 07:03:45.1405 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: PS1PR06MB1706 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zhang > > > > struct thermal_zone_device *thermal_zone_device_register(xxxx) > > > > { > > > > ... > > > > if (!tz->tzp || !tz->tzp->no_hwmon) { > > > > result = thermal_add_hwmon_sysfs(tz); > > > > ... > > > > } > > > > ... > > > > } > > > > > > > > Does this mean "thermal_zone doesn't use lm-senser" ? > > I'd prefer to say of_thermal registered thermal_zone doesn't use lm- > sensor. > If you're really want to see hwmon interface, I think you should use > thermal API (thermal_zone_device_register) directly. Thank you for your feedback. My driver is supporting both of_thermal and thermal API. So, switching is not a big deal. But can you teach me why of_thermal doesn't use lm-senser ?? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Return-Path: Message-ID: <877fdscl6o.wl%kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Zhang Rui CC: "edubezval@gmail.com" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-pm@vger.kernel.org" , "yoshihiro.shimoda.uh@renesas.com" , "cm-hiep@jinso.co.jp" Subject: Re: lm-senser can't detect thermal on thermal_zone In-Reply-To: <1465885934.4001.4.camel@intel.com> References: <87posrn1oj.wl%kuninori.morimoto.gx@renesas.com> <1463100287.15071.8.camel@rzhang1-mobl4> <874ma2lnvw.wl%kuninori.morimoto.gx@renesas.com> <87zir89iai.wl%kuninori.morimoto.gx@renesas.com> <87oa7bkqvl.wl%kuninori.morimoto.gx@renesas.com> <1465885934.4001.4.camel@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset="US-ASCII" Date: Tue, 14 Jun 2016 07:03:45 +0000 Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Zhang > > > > struct thermal_zone_device *thermal_zone_device_register(xxxx) > > > > { > > > > ... > > > > if (!tz->tzp || !tz->tzp->no_hwmon) { > > > > result = thermal_add_hwmon_sysfs(tz); > > > > ... > > > > } > > > > ... > > > > } > > > > > > > > Does this mean "thermal_zone doesn't use lm-senser" ? > > I'd prefer to say of_thermal registered thermal_zone doesn't use lm- > sensor. > If you're really want to see hwmon interface, I think you should use > thermal API (thermal_zone_device_register) directly. Thank you for your feedback. My driver is supporting both of_thermal and thermal API. So, switching is not a big deal. But can you teach me why of_thermal doesn't use lm-senser ??