From: Gregory CLEMENT <gregory.clement@free-electrons.com> To: Mark Rutland <mark.rutland@arm.com> Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>, arm@kernel.org, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Jonathan Corbet <corbet@lwn.net>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org, Tejun Heo <tj@kernel.org>, Hans de Goede <hdegoede@redhat.com>, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Date: Wed, 03 Feb 2016 11:44:38 +0100 [thread overview] Message-ID: <877fim5azt.fsf@free-electrons.com> (raw) In-Reply-To: <20160202183436.GE29778@leverpostej> (Mark Rutland's message of "Tue, 2 Feb 2016 18:34:36 +0000") Hi Mark, On mar., févr. 02 2016, Mark Rutland <mark.rutland@arm.com> wrote: >> + memory { >> + device_type = "memory"; >> + /* use only 256 MB on the 512 MB available */ >> + reg = <0x00000000 0x00000000 0x00000000 0x10000000>; >> + }; > > It would be good to comment as to why we can't use 256M of the memory. Actually the comment is wrong and the size too, we do use the 512MB. I will fix it Thanks, Gregory > > Otherwise this looks fine. > > Mark. -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: gregory.clement@free-electrons.com (Gregory CLEMENT) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Date: Wed, 03 Feb 2016 11:44:38 +0100 [thread overview] Message-ID: <877fim5azt.fsf@free-electrons.com> (raw) In-Reply-To: <20160202183436.GE29778@leverpostej> (Mark Rutland's message of "Tue, 2 Feb 2016 18:34:36 +0000") Hi Mark, On mar., f?vr. 02 2016, Mark Rutland <mark.rutland@arm.com> wrote: >> + memory { >> + device_type = "memory"; >> + /* use only 256 MB on the 512 MB available */ >> + reg = <0x00000000 0x00000000 0x00000000 0x10000000>; >> + }; > > It would be good to comment as to why we can't use 256M of the memory. Actually the comment is wrong and the size too, we do use the 512MB. I will fix it Thanks, Gregory > > Otherwise this looks fine. > > Mark. -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
next prev parent reply other threads:[~2016-02-03 10:45 UTC|newest] Thread overview: 85+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-02-02 18:07 [PATCH 00/10] Add support for the Armada 3700 SoC an mvebu ARM64 based Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:19 ` Mark Rutland 2016-02-02 18:19 ` Mark Rutland 2016-02-02 18:21 ` Mark Rutland 2016-02-02 18:21 ` Mark Rutland 2016-02-02 18:19 ` One Thousand Gnomes 2016-02-02 18:19 ` One Thousand Gnomes 2016-02-03 15:58 ` Gregory CLEMENT 2016-02-03 15:58 ` Gregory CLEMENT 2016-02-02 18:28 ` Mark Rutland 2016-02-02 18:28 ` Mark Rutland 2016-02-02 18:28 ` Mark Rutland 2016-02-03 16:32 ` Gregory CLEMENT 2016-02-03 16:32 ` Gregory CLEMENT 2016-02-03 16:56 ` Gregory CLEMENT 2016-02-03 16:56 ` Gregory CLEMENT [not found] ` <87egct4trb.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-03 17:05 ` Mark Rutland 2016-02-03 17:05 ` Mark Rutland 2016-02-03 17:05 ` Mark Rutland 2016-02-02 21:07 ` Arnd Bergmann 2016-02-02 21:07 ` Arnd Bergmann 2016-02-03 16:36 ` Gregory CLEMENT 2016-02-03 16:36 ` Gregory CLEMENT 2016-02-03 16:36 ` Gregory CLEMENT 2016-02-02 21:19 ` Rob Herring 2016-02-02 21:19 ` Rob Herring 2016-02-03 8:05 ` Marcin Wojtas 2016-02-03 8:05 ` Marcin Wojtas 2016-02-03 8:05 ` Marcin Wojtas 2016-02-03 16:43 ` Gregory CLEMENT 2016-02-03 16:43 ` Gregory CLEMENT 2016-02-03 16:43 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 02/10] ata: ahci_mvebu: add support for Armada 3700 variant Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 03/10] arm64: add Armada 3700 architecture entry Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-03 6:24 ` Jisheng Zhang 2016-02-03 6:24 ` Jisheng Zhang 2016-02-03 6:24 ` Jisheng Zhang 2016-02-03 7:55 ` Gregory CLEMENT 2016-02-03 7:55 ` Gregory CLEMENT 2016-02-03 7:55 ` Gregory CLEMENT [not found] ` <87k2mm5itx.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-03 9:11 ` Arnd Bergmann 2016-02-03 9:11 ` Arnd Bergmann 2016-02-03 9:11 ` Arnd Bergmann 2016-02-03 11:13 ` Gregory CLEMENT 2016-02-03 11:13 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 04/10] Documentation: dt-bindings: Add a new compatible for the Armada 3700 Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 21:20 ` Rob Herring 2016-02-02 21:20 ` Rob Herring 2016-02-02 18:07 ` [PATCH 05/10] Documentation: dt: Tidy up the Marvell related files Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT [not found] ` <1454436468-4241-6-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-02 21:26 ` Rob Herring 2016-02-02 21:26 ` Rob Herring 2016-02-02 21:26 ` Rob Herring 2016-02-02 18:07 ` [PATCH 06/10] devicetree: bindings: add DT binding for the Marvell Armada 3700 SoC family Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT [not found] ` <1454436468-4241-7-git-send-email-gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> 2016-02-02 21:24 ` Rob Herring 2016-02-02 21:24 ` Rob Herring 2016-02-02 21:24 ` Rob Herring 2016-02-03 8:02 ` Gregory CLEMENT 2016-02-03 8:02 ` Gregory CLEMENT 2016-02-03 8:02 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:34 ` Mark Rutland 2016-02-02 18:34 ` Mark Rutland 2016-02-03 10:44 ` Gregory CLEMENT [this message] 2016-02-03 10:44 ` Gregory CLEMENT 2016-02-03 6:37 ` Jisheng Zhang 2016-02-03 6:37 ` Jisheng Zhang 2016-02-03 6:37 ` Jisheng Zhang 2016-02-02 18:07 ` [PATCH 08/10] MAINTAINERS: Extend dts entry for ARM64 mvebu files Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 09/10] Documentation: arm: update supported Marvell EBU processors Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT 2016-02-02 18:07 ` [PATCH 10/10] arm64: defconfig: enable Armada 3700 related config Gregory CLEMENT 2016-02-02 18:07 ` Gregory CLEMENT
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=877fim5azt.fsf@free-electrons.com \ --to=gregory.clement@free-electrons.com \ --cc=andrew@lunn.ch \ --cc=arm@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=devicetree@vger.kernel.org \ --cc=gregkh@linuxfoundation.org \ --cc=hdegoede@redhat.com \ --cc=jason@lakedaemon.net \ --cc=jslaby@suse.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-ide@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-serial@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=sebastian.hesselbarth@gmail.com \ --cc=thomas.petazzoni@free-electrons.com \ --cc=tj@kernel.org \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.