From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Date: Wed, 03 Feb 2016 11:44:38 +0100 Message-ID: <877fim5azt.fsf@free-electrons.com> References: <1454436468-4241-1-git-send-email-gregory.clement@free-electrons.com> <1454436468-4241-8-git-send-email-gregory.clement@free-electrons.com> <20160202183436.GE29778@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from down.free-electrons.com ([37.187.137.238]:38113 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751395AbcBCKpM convert rfc822-to-8bit (ORCPT ); Wed, 3 Feb 2016 05:45:12 -0500 In-Reply-To: <20160202183436.GE29778@leverpostej> (Mark Rutland's message of "Tue, 2 Feb 2016 18:34:36 +0000") Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Rutland Cc: Jason Cooper , Andrew Lunn , Sebastian Hesselbarth , arm@kernel.org, Catalin Marinas , Will Deacon , Jonathan Corbet , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Tejun Heo , Hans de Goede , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Thomas Petazzoni , linux-arm-kernel@lists.infradead.org Hi Mark, =20 On mar., f=C3=A9vr. 02 2016, Mark Rutland wrote= : >> + memory { >> + device_type =3D "memory"; >> + /* use only 256 MB on the 512 MB available */ >> + reg =3D <0x00000000 0x00000000 0x00000000 0x10000000>; >> + }; > > It would be good to comment as to why we can't use 256M of the memory= =2E Actually the comment is wrong and the size too, we do use the 512MB. I will fix it Thanks, Gregory > > Otherwise this looks fine. > > Mark. --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 03 Feb 2016 11:44:38 +0100 Subject: [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board In-Reply-To: <20160202183436.GE29778@leverpostej> (Mark Rutland's message of "Tue, 2 Feb 2016 18:34:36 +0000") References: <1454436468-4241-1-git-send-email-gregory.clement@free-electrons.com> <1454436468-4241-8-git-send-email-gregory.clement@free-electrons.com> <20160202183436.GE29778@leverpostej> Message-ID: <877fim5azt.fsf@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Mark, On mar., f?vr. 02 2016, Mark Rutland wrote: >> + memory { >> + device_type = "memory"; >> + /* use only 256 MB on the 512 MB available */ >> + reg = <0x00000000 0x00000000 0x00000000 0x10000000>; >> + }; > > It would be good to comment as to why we can't use 256M of the memory. Actually the comment is wrong and the size too, we do use the 512MB. I will fix it Thanks, Gregory > > Otherwise this looks fine. > > Mark. -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com