From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48384)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1a3khV-0002XH-Pu
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:10:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1a3khQ-0006Jh-3j
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:10:33 -0500
Received: from mail-wm0-x236.google.com ([2a00:1450:400c:c09::236]:38657)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alex.bennee@linaro.org>) id 1a3khP-0006Ja-TZ
	for qemu-devel@nongnu.org; Tue, 01 Dec 2015 08:10:28 -0500
Received: by wmec201 with SMTP id c201so12700392wme.1
	for <qemu-devel@nongnu.org>; Tue, 01 Dec 2015 05:10:27 -0800 (PST)
References: <1448901890-17012-1-git-send-email-marcandre.lureau@redhat.com>
	<1448901890-17012-5-git-send-email-marcandre.lureau@redhat.com>
From: Alex =?utf-8?Q?Benn=C3=A9e?= <alex.bennee@linaro.org>
In-reply-to: <1448901890-17012-5-git-send-email-marcandre.lureau@redhat.com>
Date: Tue, 01 Dec 2015 13:10:25 +0000
Message-ID: <877fkyb9ha.fsf@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH for-2.5 v4 4/4] tests: add vhost-user-test
	when target is x64 only
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: marcandre.lureau@redhat.com
Cc: qemu-devel@nongnu.org, mst@redhat.com


marcandre.lureau@redhat.com writes:

> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> check-qtest-x86_64-y is overwritten by the last assignment. Move
> vhost-user-test addition after.
>
> Reported-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  tests/Makefile | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 0ef00a1..cf1228b 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -198,13 +198,13 @@ check-qtest-i386-y += tests/pc-cpu-test$(EXESUF)
>  check-qtest-i386-y += tests/q35-test$(EXESUF)
>  gcov-files-i386-y += hw/pci-host/q35.c
>  check-qtest-i386-$(CONFIG_VHOST_NET_TEST_i386) += tests/vhost-user-test$(EXESUF)
> -ifeq ($(CONFIG_VHOST_NET_TEST_i386),)
> -check-qtest-x86_64-$(CONFIG_VHOST_NET_TEST_x86_64) += tests/vhost-user-test$(EXESUF)
> -endif
>  check-qtest-i386-y += tests/test-netfilter$(EXESUF)
>  check-qtest-x86_64-y = $(check-qtest-i386-y)
>  gcov-files-i386-y += i386-softmmu/hw/timer/mc146818rtc.c
>  gcov-files-x86_64-y = $(subst i386-softmmu/,x86_64-softmmu/,$(gcov-files-i386-y))
> +ifeq ($(CONFIG_VHOST_NET_TEST_i386),)
> +check-qtest-x86_64-$(CONFIG_VHOST_NET_TEST_x86_64) += tests/vhost-user-test$(EXESUF)
> +endif

So is this limitation due to the guest binary we need to test this?
Surely any KVM enabled build with vhost support should be able to run
the test?

>  check-qtest-mips-y = tests/endianness-test$(EXESUF)
>  check-qtest-mips64-y = tests/endianness-test$(EXESUF)
>  check-qtest-mips64el-y = tests/endianness-test$(EXESUF)


--
Alex Bennée