From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4qbg-00022A-FG for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:08:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Z4qbc-00008y-CD for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:08:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43928) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Z4qbc-00008p-7g for qemu-devel@nongnu.org; Tue, 16 Jun 2015 09:08:44 -0400 From: Markus Armbruster References: <1434205258-1932-1-git-send-email-armbru@redhat.com> <20150615120304.7de9c59f@redhat.com> Date: Tue, 16 Jun 2015 15:08:41 +0200 In-Reply-To: <20150615120304.7de9c59f@redhat.com> (Luiz Capitulino's message of "Mon, 15 Jun 2015 12:03:04 -0400") Message-ID: <877fr3g5ra.fsf@blackfin.pond.sub.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [Qemu-devel] [PATCH 00/11] Sprint to the finish: purge QError List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com, mdroth@linux.vnet.ibm.com Luiz Capitulino writes: > On Sat, 13 Jun 2015 16:20:47 +0200 > Markus Armbruster wrote: > >> After a bit over a year and many patches, QError is finally ripe. All >> that's left of qerror.h after this series is a bunch of QERR_ macros. >> Killing them is left for another day. > > Excellent! > > I did my best to review this series, but unfortunately my review is > a bit weak because I'm not that familiar with some code paths > (like QemuOpts) and I was unable to apply patches starting with patch 04/11. Did you apply on top of my "[PATCH v2 0/7] qdev: Mostly wean off QError"? > But it does look good to me: > > Reviewed-by: Luiz Capitulino Thanks!