All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor
Date: Thu, 17 Apr 2014 12:45:18 +0100	[thread overview]
Message-ID: <877g6ouqlt.fsf@linaro.org> (raw)
In-Reply-To: <20140412002423.3e6bcd0c@skate>


Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

<snip>
>> +diff --git a/Makefile.am b/Makefile.am
>
> You're patching Makefile.am here...
>
>
>> +ZILE_VERSION = 2.4.11
>> +ZILE_SITE = http://ftp.gnu.org/gnu/zile/
>> +ZILE_LICENSE = GPLv1+
>> +ZILE_LICENSE_FILES = COPYING
>> +ZILE_CONF_OPT += --without-help2man
>> +ZILE_DEPENDANCIES += libgc
>
> but you never mark zile as requiring autoreconf using ZILE_AUTORECONF =
> YES. How can this work?

I assume the make machinery picked it up, will fix.

>
> Also, use '=' instead of '+=' above.
>
> And use $(BR2_GNU_MIRROR) for the download URL.
>
> Thanks!

Will send v3 once I've re-built and tested.

>
> Thomas

-- 
Alex Benn?e

      reply	other threads:[~2014-04-17 11:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-11 14:05 [Buildroot] [PATCH 0/3] Add lightweight Zile editor Alex Bennée
2014-04-11 14:05 ` [Buildroot] [PATCH 1/3] package/libatomic: mark as supporting aarch64 Alex Bennée
2014-04-12 21:19   ` Thomas Petazzoni
2014-04-11 14:05 ` [Buildroot] [PATCH 2/3] package/libgc: add Boehm-Demers-Weiser gc library Alex Bennée
2014-04-11 20:03   ` Thomas De Schampheleire
2014-04-11 22:22     ` Thomas Petazzoni
2014-04-16 17:05   ` Thomas Petazzoni
2014-04-11 14:05 ` [Buildroot] [PATCH 3/3] package/zile: add Zile is Lossy Emacs editor Alex Bennée
2014-04-11 15:39   ` Alex Bennée
2014-04-11 20:10   ` Thomas De Schampheleire
2014-04-17 11:44     ` Alex Bennée
2014-04-11 22:24   ` Thomas Petazzoni
2014-04-17 11:45     ` Alex Bennée [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877g6ouqlt.fsf@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.