From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [alsa-devel] [PATCH RFC v2 0/2] Fix simple-card *-master DT	parameter handling
Date: Tue, 11 Mar 2014 18:13:38 -0700 (PDT)
Message-ID: <877g80rzgg.wl%kuninori.morimoto.gx@gmail.com>
References: <cover.1394451329.git.jsarha@ti.com>
Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Return-path: <linux-omap-owner@vger.kernel.org>
In-Reply-To: <cover.1394451329.git.jsarha@ti.com>
Sender: linux-omap-owner@vger.kernel.org
To: Jyri Sarha <jsarha@ti.com>
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, liam.r.girdwood@linux.intel.com, detheridge@ti.com, peter.ujfalusi@ti.com, broonie@kernel.org, bcousson@baylibre.com
List-Id: devicetree@vger.kernel.org


Hi Jyri

> Since RFC:
> - fixed commit msg typo
> - added include/sound/soc.h changes too
> 
> The sematics of bitclock-master and frame-master DT parameters
> should depend on whether they are found from a cpu-dai or codec
> sub-node.
> 
> - bitclock-master in cpu-dai node means Codec-Bitclock-Slave
> - frame-master in cpu-dai node means Codec-Frame-Slave
> - bitclock-master in codec node means Codec-Bitclock-Master
> - frame-master in codec node means Codec-Frame-Master
> 
> For example in a cpu-dai mode bitclock-master parameter should produce
> SND_SOC_DAIFMT_CBS_* daifmt flags and a codec node
> SND_SOC_DAIFMT_CBM_* flags.

SND_SOC_DAIFMT_xxx comment indicates "codec clk/FRM" indeed.
but does this "codec" means "codec chip" ??
I'm not sure.

but anyway, if my understanding is correct,

	simple-audio-card,cpu {
		...
		bitclock-master;
		frame-master;
	};

	simple-audio-card,codec {
		...
		bitclock-master;
		frame-master;
	};

This will be
cpu   : SND_SOC_DAIFMT_CBS_CFS
codec : SND_SOC_DAIFMT_CBM_CFM

but, it is un-understandable/confusable for me,
and it breaks our sound card.

	${LINUX}/arch/arm/boot/dts/sh73a0-kzm9g-reference.dts
        ${LINUX}/arch/arm/boot/dts/r8a7740-armadillo800eva-reference.dts
        
I guess you want like this ?

	codec-bitclock-master;
	codec-frame-master;

	simple-audio-card,cpu {
		...
	};

	simple-audio-card,codec {
		...
	};

# And I guess [1/2] and [2/2] should be 1 patch.
# otherwise, it breaks git-bisect :P


Best regards
---
Kuninori Morimoto