From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52512) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK6t1-00060E-Td for qemu-devel@nongnu.org; Mon, 25 Mar 2013 08:52:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UK6sz-0005RG-S1 for qemu-devel@nongnu.org; Mon, 25 Mar 2013 08:52:27 -0400 Received: from e23smtp06.au.ibm.com ([202.81.31.148]:57799) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UK6sz-0005Qs-B7 for qemu-devel@nongnu.org; Mon, 25 Mar 2013 08:52:25 -0400 Received: from /spool/local by e23smtp06.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 25 Mar 2013 22:47:01 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id AA4182BB0023 for ; Mon, 25 Mar 2013 23:52:15 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r2PCq9nA64552974 for ; Mon, 25 Mar 2013 23:52:11 +1100 Received: from d23av03.au.ibm.com (loopback [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r2PCqDDd020093 for ; Mon, 25 Mar 2013 23:52:13 +1100 From: Anthony Liguori In-Reply-To: <514F40A2.6000202@web.de> References: <1361367806-4599-1-git-send-email-aliguori@us.ibm.com> <1361367806-4599-10-git-send-email-aliguori@us.ibm.com> <5127B788.40701@siemens.com> <5127BBC1.5070607@siemens.com> <512B7B8B.1000402@siemens.com> <87zjys9zcv.fsf@codemonkey.ws> <512B86E7.80603@siemens.com> <514F40A2.6000202@web.de> Date: Mon, 25 Mar 2013 07:51:57 -0500 Message-ID: <877gkvod5e.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Subject: Re: [Qemu-devel] [PATCH v2] gtk: Fix accelerator filtering List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Kevin Wolf , "qemu-devel@nongnu.org" Jan Kiszka writes: > On 2013-02-25 16:44, Jan Kiszka wrote: >> On 2013-02-25 16:39, Anthony Liguori wrote: >>> Jan Kiszka writes: >>> >>>> This is in fact very simply: When the input in grabbed, everything >>>> should be exclusively passed to the guest - except it has our magic >>>> CTRL-ALT modifier set. Then let GTK filter out those accels that are in >>>> use. When checking the modifier state, we just need to filter out NUM >>>> and CAPS lock. >>> >>> Can you explain what you're fixing? >> >> That it's not filtering what it is supposed to. >> >>> >>> We shouldn't hard code modifiers like this. The reason you give >>> accelerators paths like this is so that they can be overridden by a >>> user. >>> >>> That's why I filtered by path. Once we're running, we shouldn't assume >>> that accelerators use the modifiers we started with. >> >> Your path-based filtering does not work as it uses an unsupported >> internal function (see my other mail). >> >> We can make the modifier configurable via QEMU means (command line >> parameter, gconfig, whatever). But let's get the basics working first. > > The bug still exists, my patch still applies. Unless you have some idea > for a better solution, please apply this for now so that CTRL-q inside a > guest doesn't kill more kittens. Hi Jan, Your patch breaks overriding accelerators which as I said before is a critical accessibility feature. The current code works for me but I realize it's using an unsupported interface. I'll spend some time today trying to find a work around. But we definitely cannot assume that the accelerators are using any specific modifiers. Regards, Anthony Liguori > > Jan