Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue

From: Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org>
To: Russ Dill <russ.dill-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: balbi-l0cyMroinI0@public.gmane.org, "Munegowda,
	Keshava" <keshava_mgowda-l0cyMroinI0@public.gmane.org>,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org,
	notasas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	Paul Walmsley <paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] OMAP: USB : Fix the EHCI enumeration and core retention issue
Date: Mon, 02 Jul 2012 10:55:39 -0700	[thread overview]
Message-ID: <877gum6o9w.fsf@ti.com> (raw)
In-Reply-To: <CA+Bv8XaC64NChdcinrxagRYLZyTG7c05nDYy2EbfH-gfZUxnuw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> (Russ Dill's message of "Mon, 2 Jul 2012 10:05:43 -0700")

Russ Dill <russ.dill-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> writes:

> On Mon, Jul 2, 2012 at 9:54 AM, Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org> wrote:
>> Felipe, Keshava,
>>
>> Kevin Hilman <khilman-l0cyMroinI0@public.gmane.org> writes:
>>
>>> Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org> writes:
>>>
>>> [...]
>>>
>>>> Keshava is reverting a fix for a HW errata. I can't accept it as it will
>>>> cause regressions. Granted, regression by regression, there's no change,
>>>> but I simply can't knowingly cause a regression to the driver just to
>>>> have PM working. We need a real fix for this issue.
>>>
>>> Sure, as long as there is a fix in this -rc cycle.
>>>
>>> This driver intoduced changes in v3.5 that break PM for the whole SoC
>>> (by preventing CORE retention.)  These changes were clearly not tested
>>> with PM.
>>>
>>> If you cannot fix this during the -rc cycle, then you need to revert the
>>> driver PM changes that broke PM for the *whole* SoC.
>>
>> What's the status of this regression?
>>
>> This is still broken in v3.5-rc and is preventing CORE retention for the
>> *whole* SoC.
>>
>> Please fix this, either with a proper fix, or a revert for 3.5-rc.
>
> Were you able to merge my patches that at least fix the oops on boot
> and get EHCI working again on omap-3xxx?

I didn't try your patches specifically, but those are not the problems
I'm most worried about.  

I'm mostly worried about the fact that when EHCI is enabled (and
working), it prevents the CORE powerdomain from hitting retention in
idle, and thus prevents the whole chip from hitting retention in idle.

I'm also worried that the owners of this code are running out of time to
fix these several serious regresions for v3.5.

Kevin

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html