Re: [PATCH 3/3] at76c50x-usb: set firmware and hardware version in wiphy

From: Kalle Valo <kalle.valo@iki.fi>
To: Ben Hutchings <bhutchings@solarflare.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	"Luis R. Rodriguez" <mcgrof@gmail.com>
Subject: Re: [PATCH 3/3] at76c50x-usb: set firmware and hardware version in wiphy
Date: Thu, 01 Oct 2009 17:27:17 +0300	[thread overview]
Message-ID: <877hvfqjei.fsf@purkki.valot.fi> (raw)
In-Reply-To: <1254360747.23350.2.camel@localhost> (Ben Hutchings's message of "Thu\, 01 Oct 2009 02\:32\:27 +0100")

Ben Hutchings <bhutchings@solarflare.com> writes:

> On Wed, 2009-09-30 at 21:19 -0400, John W. Linville wrote:
> [...]
>> +	len = sizeof(wiphy->fw_version);
>> +	snprintf(wiphy->fw_version, len, "%d.%d.%d-%d",
>> +		 priv->fw_version.major, priv->fw_version.minor,
>> +		 priv->fw_version.patch, priv->fw_version.build);
>> +	/* null terminate the strings in case they were truncated */
>> +	wiphy->fw_version[len - 1] = '\0';
> [...]
>
> This last statement is unnecessary; snprintf() always null-terminates
> (unless the length is zero).

Yes, the extra null termination is unnecessary. This was my mistake in
the first patchset I sent.

-- 
Kalle Valo