From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B010DC433F5 for ; Thu, 30 Sep 2021 15:55:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B7BD61411 for ; Thu, 30 Sep 2021 15:55:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347086AbhI3P5Q (ORCPT ); Thu, 30 Sep 2021 11:57:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:41698 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346736AbhI3P5Q (ORCPT ); Thu, 30 Sep 2021 11:57:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 003A460F5B; Thu, 30 Sep 2021 15:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633017333; bh=Vw9j2hmYCdVKgROcRVmIajyWW2TGwwU2KUfD/tya3gY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mdsDtOgFK5I7LN8A9tlMyCunBd9gPsry6Nza7Z9uo1l1kU1n1k1TvGZT8qkcx5QYW 4J5HW8FxzMz0TyYMKSf+ki092i9dJ0EOqZfwh1TGrfe/GaEvYkDopNjgLT8NA4/haw hTuTQUo/qnKgzFCQnbDjgnGTU+ikEsvSC9C3UeafjG7Xzi2Bx2o2ImbVCBA1JNLz+W LHZOX7NhUhhsvy69J7U8xzwIF1zFcfKwXuKaeeAuMtYQmqqDYjwXyG80BSMGzeVAe1 Wb/wk1mTn27XeTVG8RyDik9WMAgR+NfdjIJYNpFmTi8CGUxpPabSOUF+WPxKG2ktCi qrGxTqH3bY9ZQ== Message-ID: <878837a91b4174ec2534be7fe2506b975e23d8d1.camel@kernel.org> Subject: Re: [PATCH 5/5] drm/vc4: hdmi: Make sure the controller is powered in detect From: nicolas saenz julienne To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds , Dave Stevenson Date: Thu, 30 Sep 2021 17:55:29 +0200 In-Reply-To: <20210922125419.4125779-6-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-6-maxime@cerno.tech> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > If the HPD GPIO is not available and drm_probe_ddc fails, we end up > reading the HDMI_HOTPLUG register, but the controller might be powered > off resulting in a CPU hang. Make sure we have the power domain and the > HSM clock powered during the detect cycle to prevent the hang from > happening. > > Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder driver") > Signed-off-by: Maxime Ripard > Reviewed-by: Dave Stevenson > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Regards, Nicolas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB73EC433FE for ; Thu, 30 Sep 2021 15:57:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8F10561440 for ; Thu, 30 Sep 2021 15:57:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8F10561440 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Zc5LwT+GhgXNyHE7v8S+6qZjWv6kkGBHeNwmSmdXQ8M=; b=WUKmAX5a3yMhZJ zgTy4JTlE++fqVnxVZQbhuiLUBNzjYayPveF1/Pce7llE6NFp8UBWQ1V0fJ+HSde7dQY/YDOlFZAQ JG8MYxumm89N4G6jNr257iX8K19oo6qhpj3nIlr89b0qg5kfPYxqYMxRWe4PdL1e2A6nW7DPBMAO9 ht2RXblNtzCv922N2rB452+4bmuc5lvyR4MloiixQC2tVjBWKcR9q85+/2yyxI3HlsSftSTSu9L7O p1CsOS0K5ny1kh9SDjp8PLVZH4ko0zNVh6uapCztfoA7lrwgr4rN/y6586xeV13HQWTQRZmz0Cqhv awBoUkUY6bE6+NSsQ9Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyPR-00F3GS-7c; Thu, 30 Sep 2021 15:55:46 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVyPF-00F3CE-OA; Thu, 30 Sep 2021 15:55:35 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 003A460F5B; Thu, 30 Sep 2021 15:55:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1633017333; bh=Vw9j2hmYCdVKgROcRVmIajyWW2TGwwU2KUfD/tya3gY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mdsDtOgFK5I7LN8A9tlMyCunBd9gPsry6Nza7Z9uo1l1kU1n1k1TvGZT8qkcx5QYW 4J5HW8FxzMz0TyYMKSf+ki092i9dJ0EOqZfwh1TGrfe/GaEvYkDopNjgLT8NA4/haw hTuTQUo/qnKgzFCQnbDjgnGTU+ikEsvSC9C3UeafjG7Xzi2Bx2o2ImbVCBA1JNLz+W LHZOX7NhUhhsvy69J7U8xzwIF1zFcfKwXuKaeeAuMtYQmqqDYjwXyG80BSMGzeVAe1 Wb/wk1mTn27XeTVG8RyDik9WMAgR+NfdjIJYNpFmTi8CGUxpPabSOUF+WPxKG2ktCi qrGxTqH3bY9ZQ== Message-ID: <878837a91b4174ec2534be7fe2506b975e23d8d1.camel@kernel.org> Subject: Re: [PATCH 5/5] drm/vc4: hdmi: Make sure the controller is powered in detect From: nicolas saenz julienne To: Maxime Ripard , Maarten Lankhorst , Thomas Zimmermann , Daniel Vetter , David Airlie Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Mike Turquette , Stephen Boyd , Florian Fainelli , Michael Stapelberg , Linus Torvalds , Dave Stevenson Date: Thu, 30 Sep 2021 17:55:29 +0200 In-Reply-To: <20210922125419.4125779-6-maxime@cerno.tech> References: <20210922125419.4125779-1-maxime@cerno.tech> <20210922125419.4125779-6-maxime@cerno.tech> User-Agent: Evolution 3.40.4 (3.40.4-1.fc34) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210930_085533_866164_A3E7C652 X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-09-22 at 14:54 +0200, Maxime Ripard wrote: > If the HPD GPIO is not available and drm_probe_ddc fails, we end up > reading the HDMI_HOTPLUG register, but the controller might be powered > off resulting in a CPU hang. Make sure we have the power domain and the > HSM clock powered during the detect cycle to prevent the hang from > happening. > > Fixes: 4f6e3d66ac52 ("drm/vc4: Add runtime PM support to the HDMI encoder driver") > Signed-off-by: Maxime Ripard > Reviewed-by: Dave Stevenson > --- Reviewed-by: Nicolas Saenz Julienne Tested-by: Nicolas Saenz Julienne Regards, Nicolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel