All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kirill Tkhai <ktkhai@virtuozzo.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
	akpm@linux-foundation.org, hannes@cmpxchg.org,
	shakeelb@google.com, vdavydov.dev@gmail.com, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] mm: Allocate shrinker_map on appropriate NUMA node
Date: Mon, 3 Feb 2020 12:31:13 +0300	[thread overview]
Message-ID: <878c2752-9817-3c37-c9fc-ef46c3a9a256@virtuozzo.com> (raw)
In-Reply-To: <20200131161814.GC4520@dhcp22.suse.cz>

On 31.01.2020 19:18, Michal Hocko wrote:
> On Fri 31-01-20 19:08:49, Kirill Tkhai wrote:
>> mm: Allocate shrinker_map on appropriate NUMA node
>>
>> From: Kirill Tkhai <ktkhai@virtuozzo.com>
>>
>> Despite shrinker_map may be touched from any cpu
>> (e.g., a bit there may be set by a task running
>> everywhere); kswapd is always bound to specific
>> node. So, we will allocate shrinker_map from
>> related NUMA node to respect its NUMA locality.
>> Also, this follows generic way we use for allocation
>> memcg's per-node data.
> 
> I would just drop the last sentence.

I mean we allocate memcg->nodeinfo from specific node,
so shrinker_map also should follow this rule. Though,
I have no objections to remove this on patch merge.

>> Signed-off-by: Kirill Tkhai <ktkhai@virtuozzo.com>
> 
> Acked-by: Michal Hocko <mhocko@suse.com>

Thanks,
Kirill.



  reply	other threads:[~2020-02-03  9:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31 12:09 [PATCH] mm: Allocate shrinker_map on appropriate NUMA node Kirill Tkhai
2020-01-31 14:57 ` David Hildenbrand
2020-01-31 15:00   ` [PATCH v2] " Kirill Tkhai
2020-01-31 15:47     ` Michal Hocko
2020-01-31 15:49       ` Kirill Tkhai
2020-01-31 16:01         ` Michal Hocko
2020-01-31 16:08           ` [PATCH v3] " Kirill Tkhai
2020-01-31 16:18             ` Michal Hocko
2020-02-03  9:31               ` Kirill Tkhai [this message]
2020-01-31 16:20             ` David Hildenbrand
2020-01-31 17:22             ` Shakeel Butt
2020-01-31 17:22               ` Shakeel Butt
2020-01-31 22:37             ` Roman Gushchin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878c2752-9817-3c37-c9fc-ef46c3a9a256@virtuozzo.com \
    --to=ktkhai@virtuozzo.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mhocko@kernel.org \
    --cc=shakeelb@google.com \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.