All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: "Zhang, Rui" <rui.zhang@intel.com>,
	"jsperbeck@google.com" <jsperbeck@google.com>,
	"tip-bot2@linutronix.de" <tip-bot2@linutronix.de>
Cc: "andres@anarazel.de" <andres@anarazel.de>,
	"peterz@infradead.org" <peterz@infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-tip-commits@vger.kernel.org" 
	<linux-tip-commits@vger.kernel.org>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [tip: x86/urgent] x86/acpi: Ignore invalid x2APIC entries
Date: Wed, 13 Dec 2023 15:51:00 +0100	[thread overview]
Message-ID: <878r5yp357.ffs@tglx> (raw)
In-Reply-To: <c1d7e60329a62a9f6d70ffa664632db8db668efe.camel@intel.com>

On Wed, Dec 13 2023 at 07:39, Zhang, Rui wrote:
> Yeah, I agree.
>
> I have posted a patch to do more strict check
> https://lore.kernel.org/all/20231210143925.38722-1-rui.zhang@intel.com/
> in case there are some weird cases that LAPIC fails to probe any
> enabled CPU and we also lose the X2APIC cpus.

The return value of acpi_register_lapic() is not really useful.

It returns an error if

  1) the number of registered CPUs reached the limit.
  2) the APIC entry is not enabled

#1: any further X2APIC CPU will be ignored

#2: the return value is bogus as the CPU is accounted for as disabled
    and will eventually lead to #1

    In fact even 'disabled' entries are valid as they can be brought
    in later (that's what "physical" hotplug uses)

The topology evaluation rework gets rid of this return value completely,
so I really don't want to add an dependency on it.

Thanks,

        tglx




  reply	other threads:[~2023-12-13 14:51 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-02 16:28 [RFC PATCH] x86/acpi: Ignore invalid x2APIC entries Zhang Rui
2023-07-28 12:51 ` Thomas Gleixner
2023-07-28 12:55   ` Thomas Gleixner
2023-07-28 16:47   ` Zhang, Rui
2023-07-29  7:07     ` Thomas Gleixner
2023-07-31 13:04       ` Zhang, Rui
2023-11-09 13:41 ` [tip: x86/urgent] " tip-bot2 for Zhang Rui
2023-11-22 22:17   ` [PATCH] platform/x86: intel_telemetry: Fix kernel doc descriptions John Sperbeck
2023-11-22 22:18   ` [tip: x86/urgent] x86/acpi: Ignore invalid x2APIC entries John Sperbeck
2023-11-22 22:19   ` John Sperbeck
2023-11-23 12:50     ` Zhang, Rui
2023-12-01  3:25       ` Ashok Raj
2023-12-01 18:08         ` Zhang, Rui
2023-12-01 20:23           ` Ashok Raj
2023-12-02  2:53             ` Zhang, Rui
2023-12-01  8:31       ` Zhang, Rui
2023-12-01 23:32         ` John Sperbeck
2023-12-06  6:58         ` Andres Freund
2023-12-07  2:41           ` Zhang, Rui
2023-12-07  5:10             ` Andres Freund
2023-12-12 17:34       ` Thomas Gleixner
2023-12-13  7:39         ` Zhang, Rui
2023-12-13 14:51           ` Thomas Gleixner [this message]
2023-12-14 15:00             ` Zhang, Rui
2023-12-14 21:11               ` Thomas Gleixner
2023-12-15 14:19         ` [PATCH] x86/acpi: Handle bogus MADT APIC tables gracefully Thomas Gleixner
2023-12-15 14:20         ` [tip: x86/urgent] x86/acpi: Ignore invalid x2APIC entries Andres Freund
2023-12-10 11:47     ` Linux regression tracking (Thorsten Leemhuis)
2023-12-18 13:57   ` [tip: x86/urgent] x86/acpi: Handle bogus MADT APIC tables gracefully tip-bot2 for Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878r5yp357.ffs@tglx \
    --to=tglx@linutronix.de \
    --cc=andres@anarazel.de \
    --cc=jsperbeck@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=rui.zhang@intel.com \
    --cc=tip-bot2@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.