Re: [Intel-gfx] [PATCH 8/8] drm/i915/sdvo: Fix debug print

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 26 Oct 2022, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Correctly indicate which outputs we support in the debug print.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Could change that to str_yes_no() or str_enabled_disabled() while at it.

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_sdvo.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_sdvo.c b/drivers/gpu/drm/i915/display/intel_sdvo.c
> index 58d147cc7633..e46b1ee4439d 100644
> --- a/drivers/gpu/drm/i915/display/intel_sdvo.c
> +++ b/drivers/gpu/drm/i915/display/intel_sdvo.c
> @@ -3403,9 +3403,12 @@ bool intel_sdvo_init(struct drm_i915_private *dev_priv,
>  			(intel_sdvo->caps.sdvo_inputs_mask & 0x2) ? 'Y' : 'N',
>  			/* check currently supported outputs */
>  			intel_sdvo->caps.output_flags &
> -			(SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_RGB0) ? 'Y' : 'N',
> +			(SDVO_OUTPUT_TMDS0 | SDVO_OUTPUT_RGB0 |
> +			 SDVO_OUTPUT_LVDS0 | SDVO_OUTPUT_SVID0 |
> +			 SDVO_OUTPUT_CVBS0 | SDVO_OUTPUT_YPRPB0) ? 'Y' : 'N',
>  			intel_sdvo->caps.output_flags &
> -			(SDVO_OUTPUT_TMDS1 | SDVO_OUTPUT_RGB1) ? 'Y' : 'N');
> +			(SDVO_OUTPUT_TMDS1 | SDVO_OUTPUT_RGB1 |
> +			 SDVO_OUTPUT_LVDS1) ? 'Y' : 'N');
>  	return true;
>  
>  err_output:

-- 
Jani Nikula, Intel Open Source Graphics Center